2.5.14+ ALSA OSS emulation

2.5.14+ ALSA OSS emulation

[Bob_Tracy]

In the 2.5.14 patchset, the following change was made in
linux/sound/core/Config.in:

-bool '  OSS API emulation' CONFIG_SND_OSSEMUL $CONFIG_SND
+dep_bool '  OSS API emulation' CONFIG_SND_OSSEMUL $CONFIG_SND

This breaks the OSS API emulation for people building their ALSA sound
drivers as modules (CONFIG_SND == "m").  The following patch applied
against the 2.5.16 kernel accomplishes what I think the author intended:

--- linux/sound/core/Config.in.orig	Sun May 19 18:44:34 2002
+++ linux/sound/core/Config.in	Sun May 19 18:45:30 2002
@@ -13,7 +13,9 @@
 if [ "$CONFIG_SND_SEQUENCER" != "n" ]; then
   dep_tristate '  Sequencer dummy client' CONFIG_SND_SEQ_DUMMY $CONFIG_SND_SEQUENCER
 fi
-dep_bool '  OSS API emulation' CONFIG_SND_OSSEMUL $CONFIG_SND
+if [ "$CONFIG_SND" != "n" ]; then
+  bool '  OSS API emulation' CONFIG_SND_OSSEMUL
+fi
 if [ "$CONFIG_SND_OSSEMUL" = "y" ]; then
   dep_tristate '    OSS Mixer API' CONFIG_SND_MIXER_OSS $CONFIG_SND
   dep_tristate '    OSS PCM API' CONFIG_SND_PCM_OSS $CONFIG_SND

Please apply.

-- 
-----------------------------------------------------------------------
Bob Tracy                   WTO + WIPO = DMCA? http://www.anti-dmca.org
rct@frus.com
-----------------------------------------------------------------------

Re: 2.5.14+ ALSA OSS emulation

[Linus Torvalds]

In article <m179bTr-0005khC@gherkin.frus.com>,
Bob_Tracy <rct@gherkin.frus.com> wrote:
>In the 2.5.14 patchset, the following change was made in
>linux/sound/core/Config.in:
>
>-bool '  OSS API emulation' CONFIG_SND_OSSEMUL $CONFIG_SND
>+dep_bool '  OSS API emulation' CONFIG_SND_OSSEMUL $CONFIG_SND
>
>This breaks the OSS API emulation for people building their ALSA sound
>drivers as modules (CONFIG_SND == "m").  The following patch applied
>against the 2.5.16 kernel accomplishes what I think the author intended:

Good catch.

However, the simpler fix is to use "dep_mbool", which exists exactly for
this reason. 

		Linus