From: Vitaly Wool <vitalywool@gmail.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Alex Dubov <oakad@yahoo.com>,
Artem Bityutskiy <dedekind1@gmail.com>, joern <joern@logfs.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 10/17] MTD: nand: make reads using MTD_OOB_RAW affect only ECC validation
Date: Fri, 5 Feb 2010 09:56:02 +0100 [thread overview]
Message-ID: <acd2a5931002050056l119844f5s30c30ccfc1a15596@mail.gmail.com> (raw)
In-Reply-To: <1265326257-4446-11-git-send-email-maximlevitsky@gmail.com>
On Fri, Feb 5, 2010 at 12:30 AM, Maxim Levitsky <maximlevitsky@gmail.com> wrote:
> This changes the behavier of MTD_OOB_RAW. It used to read both OOB and data
> to the data buffer, however you would still need to specify the dummy oob buffer.
>
> This is only used in one place, but makes it hard to read data+oob without ECC
> test, thus I removed that behavier, and fixed the user.
>
> Now MTD_OOB_RAW behaves like MTD_OOB_PLACE, but doesn't do ECC validation
>
> Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
> ---
> drivers/mtd/nand/nand_base.c | 5 -----
> drivers/mtd/nand/nand_bbt.c | 26 ++++++++++++++++++++++----
> include/linux/mtd/mtd.h | 4 +---
> 3 files changed, 23 insertions(+), 12 deletions(-)
Could you please provide a clearer description of why you think this
is necessary?
Thanks,
Vitaly
next prev parent reply other threads:[~2010-02-05 8:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 23:30 [PATCH V6] Work to enable SmartMedia/xD support Maxim Levitsky
2010-02-04 23:30 ` [PATCH 01/17] MTD: create lockless versions of {get,put}_mtd_device This will be used to resolve deadlock in block translation layer Maxim Levitsky
2010-02-04 23:30 ` [PATCH 02/17] blktrans: nuke mtd_blkcore_priv and make both thread and disk queue be per device Maxim Levitsky
2010-02-04 23:30 ` [PATCH 03/17] blktrans: track open and close calls Maxim Levitsky
2010-02-04 23:30 ` [PATCH 04/17] blktrans: don't free mtd_blktrans_dev, core will do that for you Maxim Levitsky
2010-02-04 23:30 ` [PATCH 05/17] blktrans: add proper locking Maxim Levitsky
2010-02-04 23:30 ` [PATCH 06/17] blktrans: flush all requests before we remove the device Maxim Levitsky
2010-02-04 23:30 ` [PATCH 07/17] blktrans: allow FTL drivers to export sysfs attributes Maxim Levitsky
2010-02-04 23:30 ` [PATCH 08/17] MTD: call remove notifiers before removing the device Maxim Levitsky
2010-02-04 23:30 ` [PATCH 09/17] MTD: nand: make MTD_OOB_PLACE work correctly Maxim Levitsky
2010-02-04 23:30 ` [PATCH 10/17] MTD: nand: make reads using MTD_OOB_RAW affect only ECC validation Maxim Levitsky
2010-02-05 2:48 ` stanley.miao
2010-02-05 8:56 ` Vitaly Wool [this message]
2010-02-05 9:25 ` Maxim Levitsky
2010-02-04 23:30 ` [PATCH 11/17] MTD: nand: fix bug that prevented write of more that one page by ->write_oob Maxim Levitsky
2010-02-05 2:25 ` stanley.miao
2010-02-05 9:44 ` Maxim Levitsky
2010-02-05 2:34 ` stanley.miao
2010-02-04 23:30 ` [PATCH 12/17] MTD: nand: make suspend work if device is accessed by kernel threads Maxim Levitsky
2010-02-04 23:30 ` [PATCH 13/17] MTD: export few functions from nand_base.c Maxim Levitsky
2010-02-05 2:32 ` stanley.miao
2010-02-05 9:30 ` Maxim Levitsky
2010-02-05 17:05 ` Maxim Levitsky
2010-02-04 23:30 ` [PATCH 14/17] MTD: common module for smartmedia/xD support Maxim Levitsky
2010-02-04 23:30 ` [PATCH 15/17] MTD: add few workarounds to nand system for SmartMedia/xD chips Maxim Levitsky
2010-02-04 23:30 ` [PATCH 16/17] MTD: Add nand driver for ricoh xD/SmartMedia reader Maxim Levitsky
2010-02-04 23:30 ` [PATCH 17/17] MTD: Add new SmartMedia/xD FTL Maxim Levitsky
-- strict thread matches above, loose matches on Subject: below --
2010-01-30 15:02 [PATCH V5] Work to enable SmartMedia/xD support Maxim Levitsky
2010-01-30 15:02 ` [PATCH 10/17] MTD: nand: make reads using MTD_OOB_RAW affect only ECC validation Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acd2a5931002050056l119844f5s30c30ccfc1a15596@mail.gmail.com \
--to=vitalywool@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=joern@logfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=maximlevitsky@gmail.com \
--cc=oakad@yahoo.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).