From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32D593AC0EE for ; Mon, 30 Mar 2026 09:35:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774863314; cv=none; b=SUHt1HmksID724Um/bLfNHVNzG8E4AfNDnV+r0GZIGy6bMp9YEm2F1zlAOql/uQyBKCJOP2CoFn5sMnlbzipQW1CUrfCDFkSwLem9I8FhZfaxW5jmjQfNdysr8KPYLkkAOn9IlmfupxfI/BdkurxoipwIXkrcVbkqXtxMqnzss4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774863314; c=relaxed/simple; bh=d1eHUYZVrqhyt2zFBgTI4z9glgcOv/f53BlO/yFQ87k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=djwgHiiEROIzHZUt50jnrFoYp1FIZXlZhkzSynjTqMYNGtthg9+baPHr7vwI4ApXYrMWrbkbEji9y64Eg6CkKf9Nzp6hFZOLfsDPCHtqnu6/fPu8qrjwbLwIkwUXNpZqjNyxAuUbuG+UBFOIC8bZnij+QKHZBYzaMYrfXtYGseM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hMvX26XN; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hMvX26XN" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-38c688bdc71so27614651fa.2 for ; Mon, 30 Mar 2026 02:35:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774863311; x=1775468111; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4QA+DyJyDUPG69YjpkY0E0FsABY3pRGNgm9Kth96nxo=; b=hMvX26XNIA1uSplMOsOR+ERyqrIMi9vLZqdaoTwBoxr0Klh6uEjns9K5Baza4j4Y08 5Xw8aS6TEjQaxStuSKy+XXirEj4GoNDcBdRaPckz5wmLdK6YO5OWKw5yEfpX3pJdq2/o dGMOBblHJMVVL6UC/pQPfYRWd3NyAxvkKZsY5SFnA3g89XH1LYsj0h3E8UbSWn4S0zIz WoO6A0ml0OrMBWF05WC9lTUtKSdSIZyHbKWM7SZ9nLbRE/B7YQkCQ0UKi3j8egEirKoP gWVOnUvAkjvdIzqU+vnKyyIslHd7jO/xHdN5xUa7vwOMvTRIpgpI1zipZSPBF9vB3T8q f4tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774863311; x=1775468111; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4QA+DyJyDUPG69YjpkY0E0FsABY3pRGNgm9Kth96nxo=; b=nIjZY3NBXzKaJBO4a7qMLS7ePmQABRV6Ne5V7bBtHMvyfKytlEQlGjk5SFR6MzDz/+ KdWC8g3OMDSmrpN1k9okoueve5VWReYA2nKwmGo6O9Q2ZcxW7AyWUbvM3Fi/Xacpp9YS +glCkX7nZq4RyR7MsC84Q3f3+Sl4R+lBlfUHA96zBbjSNfUtsbsvR318tVjO8s0TZOlr mxn00CUeoXE9wfylkNH+O3+3sHxUiLHjF1VxCbdCLu3AE4iKJHAtNVdmKa3aH7r+fvcI vRme+49Kwv/n4Ekn4gfN6YZnq76PhOZRIEufAUlZI5T76XRv6khC0R5BLK/h3/414RVs vD6Q== X-Forwarded-Encrypted: i=1; AJvYcCW905Vww9qfC4XhMX5umwWmW1M+r7fgFK/i4lOUpXPr4iOddoMGZHMARU4n8NlfVtwMwBGNbP8EDWInNBQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzMVQa7179BlqPEhtorMCgvvWhLTVkMgdZmk5uczUxbkvAaSiCp +qIG8DVhpKLMorS6YUzhU0BbDPX9Tg5SybPEUJbdSHZLktwGDTymzGU0 X-Gm-Gg: ATEYQzzC/6cTIMhyY8T1+UmZSs5bqIs+1XSRZ9V2Y6yg02LAHn0WDPt2aMqPtJFJ1ER uwI/3ncBcxq8crAORogDLYPPNTBE9NlbPSuWIfvT5pWUeITGoSHbY3kKtqia2JCqj7DfSiAsuzX AIIyxVLgzsN7WG4fM/aQPrRaY8qB+nBQanTZE1sLe8KJYI6Fw5yvFPpjQ1uLxLODUXWc390VByj svWIJ5LxcW7Cy7ykjK+o0ltWCZpd001uj+JsJU75yfDv6QdmEIZ1ChDn96+nRrMIvHRKf+OFiXh xTXN5ns53gyNxmLrs3JGKe8/pgfyIth4UlwWRnneIsWMlCokfIIvNItDe/lFZOnDmaDNdNeg8Pv tkdTw6vp2f38V9+VYmeUc/YOhOUGklfBfgASdeozOpEqwAfIHdsyAAEBHanWy57r8hep6YYWlgY Yt0jWYu2pLbzxFfrmg1sU= X-Received: by 2002:a2e:a9aa:0:b0:383:20cd:52fe with SMTP id 38308e7fff4ca-38c7325fc20mr39611771fa.17.1774863311118; Mon, 30 Mar 2026 02:35:11 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38c83890bbcsm14487271fa.25.2026.03.30.02.35.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 02:35:10 -0700 (PDT) Date: Mon, 30 Mar 2026 12:35:07 +0300 From: Dan Carpenter To: Shivam Gupta Cc: gregkh@linuxfoundation.org, johan@kernel.org, elder@kernel.org, vaibhav.sr@gmail.com, mgreer@animalcreek.com, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: audio_manager: Add missing newline to sysfs_emit outputs Message-ID: References: <20260328044527.10489-1-shivgupta751157@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260328044527.10489-1-shivgupta751157@gmail.com> On Sat, Mar 28, 2026 at 10:15:27AM +0530, Shivam Gupta wrote: > sysfs_emit outputs in audio_manager_module.c do not include a terminating > newline, which is required for proper sysfs formatting. > > Add newline characters to all sysfs_emit format strings. > > Signed-off-by: Shivam Gupta > --- "Proper sysfs format" is all well and good, but this is something which already exists and adding a newline is changing the API. If you were a maintainer of this code, then I would have more confidence that you know all the user space code which uses this API and are able to test it thouroughly. We merged a similar change recently and, whatever, that's fine, probably it doesn't break anything. But the more we do it, the more likely we are to break something so my instinct is that we should discourage this kind of change. regards, dan carpenter