public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Carlos Llamas <cmllamas@google.com>
To: EXtremeExploit <pedro.montes.alcalde@gmail.com>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
	arve@android.com, tkjos@android.com, christian@brauner.io,
	aliceryhl@google.com
Subject: Re: [PATCH] rust_binder: drop startup init log message
Date: Sat, 28 Mar 2026 16:43:53 +0000	[thread overview]
Message-ID: <acgFSeLde7EWUI2A@google.com> (raw)
In-Reply-To: <20260328010250.249131-2-pedro.montes.alcalde@gmail.com>

On Fri, Mar 27, 2026 at 10:02:51PM -0300, EXtremeExploit wrote:
> From: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>
> 
> The "Loaded Rust Binder." message is logged during normal
> initialization and does not indicate an error/warning condition.
> 
> Logging it creates unnecessary noise and is inconsistent
> with other drivers, so this change fixes that
> 
> Signed-off-by: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>
> ---
> This time i have SMTP setup with git, so hopefully there arent any formatting issues

Yeap, this is good now. Thanks.

>  drivers/android/binder/rust_binder_main.rs | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/android/binder/rust_binder_main.rs b/drivers/android/binder/rust_binder_main.rs
> index aa5f2a75adb4..dccb7ba3ffc0 100644
> --- a/drivers/android/binder/rust_binder_main.rs
> +++ b/drivers/android/binder/rust_binder_main.rs
> @@ -292,8 +292,6 @@ fn init(_module: &'static kernel::ThisModule) -> Result<Self> {
>          // SAFETY: The module initializer never runs twice, so we only call this once.
>          unsafe { crate::context::CONTEXTS.init() };
>  
> -        pr_warn!("Loaded Rust Binder.");
> -
>          BINDER_SHRINKER.register(c"android-binder")?;
>  
>          // SAFETY: The module is being loaded, so we can initialize binderfs.
> -- 
> 2.53.0
> 

Acked-by: Carlos Llamas <cmllamas@google.com>

  reply	other threads:[~2026-03-28 16:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-28  1:02 [PATCH] rust_binder: drop startup init log message EXtremeExploit
2026-03-28 16:43 ` Carlos Llamas [this message]
2026-03-30  8:07 ` Alice Ryhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acgFSeLde7EWUI2A@google.com \
    --to=cmllamas@google.com \
    --cc=aliceryhl@google.com \
    --cc=arve@android.com \
    --cc=christian@brauner.io \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pedro.montes.alcalde@gmail.com \
    --cc=tkjos@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox