Re: [PATCH] dt-bindings: power: reset: cortina,gemini-power-controller: convert to DT schema

[Sebastian Reichel <sre@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2502 bytes --]

Hi,

On Sat, Mar 28, 2026 at 10:28:39PM +0100, Linus Walleij wrote:
> On Sat, Mar 28, 2026 at 6:31 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > On 28/03/2026 17:12, Linus Walleij wrote:
> > > On Sat, Mar 28, 2026 at 3:26 PM Rob Herring (Arm) <robh@kernel.org> wrote:
> > >
> > >> dtschema/dtc warnings/errors:
> > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/reset/cortina,gemini-power-controller.example.dtb: power-controller@4b000000 (cortina,gemini-power-controller): '#power-domain-cells' is a required property
> > >>         from schema $id: http://devicetree.org/schemas/power/power-domain.yaml
> > >
> > > Weird, this power controller does not handle power domains whatsoever,
> > > it handles the mains power. So it should not have any power domain
> > > cells.
> > >
> > > Is this the result of some regexp gone stray?
> >
> > The name "power controller" is used for power domain controller, so
> > that's why this name must not be used for other use cases. Usual
> > replacement is power-management, reboot, restart or poweroff, depending
> > on what is the purpose of this device.
> 
> So in this case this is just a conversion of the 9 years old text document
> which is an as valid binding as any:
> 
> commit ba443b5ab454a9b5f49229a94b2dadf06ac8b79e
> Author: Linus Walleij <linusw@kernel.org>
> Date:   Sun Mar 12 23:36:01 2017 +0100
> 
>     power: reset: Add Gemini poweroff DT bindings
> 
>     This adds device tree bindings to the power management controller
>     in the Gemini SoC.
> 
>     Cc: devicetree@vger.kernel.org
>     Cc: Janos Laube <janos.dev@gmail.com>
>     Cc: Paulius Zaleckas <paulius.zaleckas@gmail.com>
>     Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com>
>     Cc: Florian Fainelli <f.fainelli@gmail.com>
>     Acked-by: Rob Herring <robh@kernel.org>
>     Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>     Signed-off-by: Sebastian Reichel <sre@kernel.org>
> 
> The text document was conspiciously named "gemini-poweroff.txt" while the
> compatible is ""cortina,gemini-power-controller".
> 
> I don't know what came first, this binding or the convention of
> *-power-controller, but it's solidly there for a while so we need
> to accomodate this, I guess worst case simply special-casing it?

The problem is the node name (power-controller@4b000000), which is
reserved for power domains. You can keep the compatible.

Greetings,

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]