From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 906EB40DFD3 for ; Sun, 29 Mar 2026 09:06:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774775167; cv=none; b=CmjPLHEGFCjE2HdI4RwovNjpub15TucF4oHfNeDoxy4G0OHFGZXWkR0b2HoRT96juXp5LBIledciEKs0s+tSRZaHteaC9wiSnXl/jgPrswVALTJ4Ysdz5VIGss/thPKJj2+HmvUOW15VI/cekeiGUtFmcZvMDP7sfkmeQzlZ1Ew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774775167; c=relaxed/simple; bh=zhbWVNzCGwK4zrdIuFpmCSyTIu1bGBugMwjB2QxR4VM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=im6qvXngZ/dkR4qFr8YskWMW/lcDBclA22y3U7zXBEBbsjToD2t9YMdgLOjOHKIxa9Npc5E7yYbQDEXF/960ypNjk4xYaloU7T6pHvjOexM8Rf3v3aSa1ChJ2un0nJOWwHO91flSqdr+cQBtXPigFgK3HahTwsGefUVL7TQej3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UtNzlz0z; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UtNzlz0z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774775165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gm9WbX3aGbzz+xm7VEIAM/1LK2XfhplZSKMKkWgFnuo=; b=UtNzlz0zYm89Ns77ASKUJMFNLMuWvoM9pEuhhFgaAjF9cR0fV+q5moKMtg7vouP3FiLick 83j60gG7IOzThCNllWMEFXFEryKQLKZikYF66ytfUkVT/yeDQpI4S/Wx7Rk/jewENtNXR0 a9kDKB0vdpWl4xRs2KwBB0irJ4Ec37A= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-83-jyU18zvWN16pE1pBORFRkQ-1; Sun, 29 Mar 2026 05:06:00 -0400 X-MC-Unique: jyU18zvWN16pE1pBORFRkQ-1 X-Mimecast-MFC-AGG-ID: jyU18zvWN16pE1pBORFRkQ_1774775158 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8B011195608E; Sun, 29 Mar 2026 09:05:57 +0000 (UTC) Received: from gmail.com (unknown [10.72.112.11]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 30ABC19560B1; Sun, 29 Mar 2026 09:05:46 +0000 (UTC) Date: Sun, 29 Mar 2026 17:05:42 +0800 From: Chunyu Hu To: "David Hildenbrand (Arm)" Cc: Andrew Morton , shuah@kernel.org, linux-mm@kvack.org, ljs@kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev Subject: Re: [PATCH v6 0/6] selftests/mm: skip several tests when thp is not available Message-ID: References: <20260324013316.2590422-1-chuhu@redhat.com> <20260324090927.eeacb7987d22ed8ba13fada2@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On Fri, Mar 27, 2026 at 02:24:58PM +0100, David Hildenbrand (Arm) wrote: > On 3/24/26 17:09, Andrew Morton wrote: > > On Tue, 24 Mar 2026 09:33:10 +0800 Chunyu Hu wrote: > > > >> There are several tests requires transprarent hugepages, when run on thp > >> disabled kernel such as realtime kernel, there will be false negative. > >> Mark those tests as skip when thp is not available. > > > > Thanks, I updated mm.git's mm-unstable branch to this version. > > > >> Chagnes in v6: > >> - patch 3 add reviewed-by from Lorenzo > >> - patch 4 handle the errno before and after close(), suggested by AI > > > > Here's how v6 altered mm.git: > > > > > > tools/testing/selftests/mm/vm_util.c | 12 ++++++++++-- > > 1 file changed, 10 insertions(+), 2 deletions(-) > > > > --- a/tools/testing/selftests/mm/vm_util.c~b > > +++ a/tools/testing/selftests/mm/vm_util.c > > @@ -785,15 +785,23 @@ int unpoison_memory(unsigned long pfn) > > > > void write_file(const char *path, const char *buf, size_t buflen) > > { > > - int fd; > > + int fd, saved_errno; > > ssize_t numwritten; > > Empty line? :) Good catch. I will add one empty line in the next version. Thanks! > > > + if (buflen < 1) > > + ksft_exit_fail_msg("Incorrect buffer len: %zu\n", buflen); > > -- > Cheers, > > David >