From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFA9C78F3E for ; Mon, 30 Mar 2026 04:34:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774845290; cv=none; b=rrE0WWdYcT0yMdsD8mZbmhkRyClpeiTWQj6F/oTSnIEZyJOIyASbkSLRKRBn56GngMa9EdQ1493TObGfJ42rEIGfdNIXEzLnoAT1t+IEqaHkhIGbgCw4STZSVZm9IdNjJn2JSkAHiY89p/0r89hmW9/Bok+hnuuDHljxPxNEAgk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774845290; c=relaxed/simple; bh=Xx3npk67IT7VCzqZegedxvkz6FZL8EVL4gMKrAR+NIM=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=amrqzb3C3bvSdvNtQAfcrpslbyos41d79KbZ+8Js/WdwWP+tZ5oLB3PbTfMZc/2BgekPNQwokvAnHAAROYWQ65EFGi5Ew3QRO2PM9u2aQHaZyx1Z44G63CqxWA9LzvhUlytlK5wuDLQ/QjditeCvs5x7NGNsvhUSvaOJf0JvG1Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bKW52EvZ; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bKW52EvZ" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-82a655cfab5so3799970b3a.1 for ; Sun, 29 Mar 2026 21:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774845288; x=1775450088; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=2Jh8RjPwPB56bdE2HifgsXtOaKLdHd9fm9iG5LMOIb4=; b=bKW52EvZqMZXfV2HCCEVcp2kRGQGOTQRS1FhfFuhdMychKoC1NtyXhWxLbLKeHDlk6 tv6e+i/Faxzb0czfLflGeUqdPBbselTaGjGgDUmu5hv76qp004HjBDfIinfiYXJjiggI UPMkM7u+p9rG4SlTzWYnJFrQfz3VlmGl+pAWrKNZNcRxyH2J0BtJRSN+ivhl3lR1WQIX 56ct2rmqDJwd7YJC7EgGcsP2eGAOZXqCuC3jstaIPkfSkhHGgpDVLkvF8SkkgAHtFEvo vfYiZSllFj6D3BMBOq3kEV5bUOHupuYw6oeirAHPMv5i4K48rhvOVTKIF5erQSkhOL91 nbuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774845288; x=1775450088; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2Jh8RjPwPB56bdE2HifgsXtOaKLdHd9fm9iG5LMOIb4=; b=JXhJAG4eq+IQCS3qHpZBXrjVxlAE1F5mlX7T1a9lpu6XZUGQZfW4KtF3S55yXm7L4b fQ+zx+kdVMj4tSaow1cN1JCznM2Lc2hCXAI5+i2oW7Skc+lFwMHKDgw33f2boEf+9vvH sV0YUpJYKhOa+xRIYHtBGzMEgwcj5zBC0CJRhoxVqQzdjetuEnSQu/IVvc3wxLfBQ9Rb btSMzJYpuXocEs3BcvCjsjFCR2uSaMEqHMZppGNmDjqAAUhntj/M9pf71t2nrAq6JXOO NeRn0i4f+oHwX1YDvkyTaAOyE4y+q3zG7aJT+8UzQRWmUVgluLm/o/KlhAjVIEFbW+fJ A62Q== X-Forwarded-Encrypted: i=1; AJvYcCU7t7dJPETQ/LNtlaJO2MNhm2F4TNyL6ebuowDtCs73otTBf/wLiiFxIlCzsjjmMjuu60FD8OqNSJXaf/c=@vger.kernel.org X-Gm-Message-State: AOJu0YzLuAWJVIJs30dOebiSnVcTKLmKZ5Y0rSHMLMs6eG68z4iKq0iR 6QbcU29GwrNlxf05VGG6mZQenbGEY4PM4oi/Lwe6SiuL5RPg5DtTROwi X-Gm-Gg: ATEYQzxFtGo/RStbNqoBGnerpWlF4/MuntJddX5R+o8oQewAT2PEWQSgk2/CTaXwq6f lA0GaJASPxraoIyQxdLHph2AWQk/WZjhaGD+u9i4h/GB3a8LO9yuxsnqhvmneNIH4UIHxPjQXjc pFmqlUY6Ok+HycxVBrqWKUzIJUA6Dzq9GmPvWRioYYwRMpxMm8bsoS49KdWXUpif8JC14W3YM1e H+7oRUrCibUTw9zgj4pVBizNoZF8rn8dYxL9Rz+c2vgj8suJmzpHnURqZAmJJadwqzMuR9k0uYE 4aQTATZDhMkjPDoFO/RjXQf8Bfd+1/L4eiY+bGimYiCOB62owDN6gnmBdQ1beoS4XZ0shlcXJIu z76Vk0uecQVhYbq9M4XkSOxq37aeXS9nxXH3OIUVpO+aUwnDJ9cXA4jLU0qigCoITdDtqhebacO eUDhkYyfGWhX6t7jlRYPsM1XCNMmXFkgaem+cc+OQ= X-Received: by 2002:a05:6a00:bc93:b0:82a:17ee:3c1a with SMTP id d2e1a72fcca58-82c9604fcccmr10472534b3a.53.1774845287982; Sun, 29 Mar 2026 21:34:47 -0700 (PDT) Received: from adminpc-PowerEdge-R7525 ([27.122.242.81]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca8628f44sm5857160b3a.57.2026.03.29.21.34.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 21:34:47 -0700 (PDT) Date: Mon, 30 Mar 2026 13:34:42 +0900 From: Austin Kim To: Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, austindh.kim@gmail.com Subject: [PATCH] riscv: signal: refactor debug logging to use macros Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline From: Austin Kim Replace manual #if DEBUG_SIG blocks with a unified DEBUGP macro. This will improve code readability. Signed-off-by: Austin Kim --- arch/riscv/kernel/compat_signal.c | 10 ++++++---- arch/riscv/kernel/signal.c | 10 ++++++---- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/arch/riscv/kernel/compat_signal.c b/arch/riscv/kernel/compat_signal.c index 6ec4e3425..c82235be7 100644 --- a/arch/riscv/kernel/compat_signal.c +++ b/arch/riscv/kernel/compat_signal.c @@ -12,7 +12,11 @@ #include #include -#define COMPAT_DEBUG_SIG 0 +#ifdef DEBUG_SIG +# define DEBUGP(fmt, args...) pr_info("%s: " fmt, __func__, ##args) +#else +# define DEBUGP(fmt, args...) +#endif struct compat_sigcontext { struct compat_user_regs_struct sc_regs; @@ -233,11 +237,9 @@ int compat_setup_rt_frame(struct ksignal *ksig, sigset_t *set, regs->a1 = (unsigned long)(&frame->info); /* a1: siginfo pointer */ regs->a2 = (unsigned long)(&frame->uc); /* a2: ucontext pointer */ -#if COMPAT_DEBUG_SIG - pr_info("SIG deliver (%s:%d): sig=%d pc=%p ra=%p sp=%p\n", + DEBUGP("SIG deliver (%s:%d): sig=%d pc=%p ra=%p sp=%p\n", current->comm, task_pid_nr(current), ksig->sig, (void *)regs->epc, (void *)regs->ra, frame); -#endif return 0; } diff --git a/arch/riscv/kernel/signal.c b/arch/riscv/kernel/signal.c index 59784dc11..1d7fddcff 100644 --- a/arch/riscv/kernel/signal.c +++ b/arch/riscv/kernel/signal.c @@ -30,7 +30,11 @@ extern u32 __user_rt_sigreturn[2]; static size_t riscv_v_sc_size __ro_after_init; static size_t riscv_zicfiss_sc_size __ro_after_init; -#define DEBUG_SIG 0 +#ifdef DEBUG_SIG +# define DEBUGP(fmt, args...) pr_info("%s: " fmt, __func__, ##args) +#else +# define DEBUGP(fmt, args...) +#endif struct rt_sigframe { struct siginfo info; @@ -471,11 +475,9 @@ static int setup_rt_frame(struct ksignal *ksig, sigset_t *set, regs->a1 = (unsigned long)(&frame->info); /* a1: siginfo pointer */ regs->a2 = (unsigned long)(&frame->uc); /* a2: ucontext pointer */ -#if DEBUG_SIG - pr_info("SIG deliver (%s:%d): sig=%d pc=%p ra=%p sp=%p\n", + DEBUGP("SIG deliver (%s:%d): sig=%d pc=%p ra=%p sp=%p\n", current->comm, task_pid_nr(current), ksig->sig, (void *)regs->epc, (void *)regs->ra, frame); -#endif return 0; } -- 2.34.1