From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8B1A140DFB3 for ; Mon, 30 Mar 2026 00:54:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774832088; cv=none; b=jLFVGyqY5TglZz/FtnMvyJ5pVgzP/2H+GKrpXj0o80lyg82N+wK7u3VXIkuj0Sj6w2zZL/muu/DwoRLMiRia99flYnP7VmrJX3QGPKd9TA54ydzI5VXa4uOAxz/6g7//s+ITUXkEfyXrZb6QNpsU+dw3X6wPkpuPk3KgaDTSteg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774832088; c=relaxed/simple; bh=VybClclAgdMbvh5kr4Jr1MDlw53NtYbXJDj/RmpgTl0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qwl/PUh5ZZbkA4pS3Y3JaGyC+TCO7pM45fIFmLG4DUBvwzN/dAUNcTAghjpbZCYmoLCGrc5o4y41eJsjHuwkRP6iBc7Goh8Zw5aHOvzI5NIjaaCQhaZrx3m+QEzyRNGptunfUCMpqiGjkQAJjwvL4RfJiLLmGw3w6f9laFIeTKI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LpygGnPJ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LpygGnPJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774832085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VeBsHEzxlnMsna5xu42WJbgoECnsygSdobxRGWZZQRA=; b=LpygGnPJF11klz0PSK8u8tbNyNKT8Eg0nC7lqaWQquzlm4fa5PlAwvg9+83N/7Z0GqxmiO Z5V0PzP8ReHbeeO9/j0gwHLbzuM22GoB+iZ+QHKUX0WAZXaHVo8E0dmZvgGGQJGIFAVnCM wwjSl4koF6bUJEry691XRXuUkIlyq9Q= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-230-vBzK6CYLOJ2Dn-0RyBXYow-1; Sun, 29 Mar 2026 20:54:42 -0400 X-MC-Unique: vBzK6CYLOJ2Dn-0RyBXYow-1 X-Mimecast-MFC-AGG-ID: vBzK6CYLOJ2Dn-0RyBXYow_1774832081 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 38731195608E; Mon, 30 Mar 2026 00:54:39 +0000 (UTC) Received: from localhost (unknown [10.72.112.11]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A3B641800361; Mon, 30 Mar 2026 00:54:37 +0000 (UTC) Date: Mon, 30 Mar 2026 08:54:33 +0800 From: Baoquan He To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, baohua@kernel.org, chrisl@kernel.org, kasong@tencent.com, nphamcs@gmail.com, shikemeng@huaweicloud.com, youngjun.park@lge.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] mm/swap: use swap_ops to register swap device's methods Message-ID: References: <20260328075812.11060-1-21cnbao@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260328075812.11060-1-21cnbao@gmail.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 On 03/28/26 at 03:58pm, Barry Song wrote: > From: Barry Song > > -v2: > * lots of cleanup for patch 2/3: renaming, moving data > structures, and using const properly > * collected tags from Kairui, Nhat and Barry Thanks a lot for taking care of this, Barry. I took several days off for family reason. Sorry for the inconvenience caused by my leave. > > -v1: > https://lore.kernel.org/linux-mm/20260302104016.163542-1-bhe@redhat.com/ > > This can simplify the code logic and benefit any new type of swap device > added later. > > And also do renaming in this patchset: > ------- > file renaming: > --- > mm/page_io.c to mm/swap_io.c > > function renaming: > --- > swap_writepage_* to swap_write_folio_* in file mm/swap_io.c > > Baoquan He (3): > mm/swap: rename mm/page_io.c to mm/swap_io.c > mm/swap: use swap_ops to register swap device's methods > mm/swap_io.c: rename swap_writepage_* to swap_write_folio_* > > MAINTAINERS | 2 +- > include/linux/swap.h | 2 + > mm/Makefile | 2 +- > mm/swap.h | 12 ++++- > mm/{page_io.c => swap_io.c} | 101 ++++++++++++++++++++---------------- > mm/swapfile.c | 1 + > mm/zswap.c | 3 +- > 7 files changed, 73 insertions(+), 50 deletions(-) > rename mm/{page_io.c => swap_io.c} (89%) > > -- > 2.39.3 (Apple Git-146) >