From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79DA63B5307 for ; Mon, 30 Mar 2026 09:35:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774863333; cv=none; b=AJUVQsr9wJnPwExwTId/V37j2PoRxbs+t5JkXiBFRJVGorZK4IHQQ/r4uSX0mC+lNKCIkOg38n3w9SstsEU6nOGjBANGaB/MPAnxON4IVVZhXV+B2lIslufT+8SK7GueiS3bqVW54jgvxj1E25h2lb5itwL0BQgfo6iEPjR5anU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774863333; c=relaxed/simple; bh=6wPRRpRwz2x53VrR0QuhpMFsnugh4pAk0CBgUyKRH1k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F9XYjExZHCwyTwMd6l6YLEycq4MiOaCwMFrdglCCvHJcLVVuxtNopYdWRT4yEotYEjGchbmilPJmAik2DnhjZ0l05pWAuknGq3fpdZ/du8dXjtG5PruxoFnY56Pm9dmFtFRCYv1yBHlYDa4t4AsFMgpC8BWaqzLVfmOSM17y22Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fd0WnzoE; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fd0WnzoE" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5a13a06fc85so5293982e87.1 for ; Mon, 30 Mar 2026 02:35:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774863331; x=1775468131; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=DEGfuqxl32v7PBbxgLIMkoQqyZgVqIOPNzYNHtZHgO8=; b=fd0WnzoETwg1F43ItsO3DROmbiiNm9uI8USialB2ZNPJKsLqxehVcDc1myJdREvzCP /kydqJ2wftuquDZwrFO71cWIbl35a0JLpCpHuwOjVEp2ThNy09lfD5OJZk+c9zoABKk3 4WUDR/NIaO6zfMRpV40Rnn6vtOdgADtWRGEXD4gNUSbyjuhQwCqyesylvBpasUnzCIo/ mVCZrSlZ4JklpcEH4yTwn5uLpS5FbcM7sH10yFz7H4JJPlmuuaqc2kdWU1AN/9nk5hGb ji4OI+uTNMsK9R7eCxyzwSRnYVV8V4zLUjScY0s+HnYQMSin52goEpEvzMAcnNah/Zr3 JaMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774863331; x=1775468131; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DEGfuqxl32v7PBbxgLIMkoQqyZgVqIOPNzYNHtZHgO8=; b=m+v2F6IdKGAXH2eP+a1X2/FZ4K9niDMBLMV8UCq2Scf49AySJfeSRsulr8KMJqz6KM FbkFD8B+looIpIrz41tPKFucTnzf+Ssr+rp6WvAw6yOOE1V/UDWYkVfeB9ssOID6Eavv 2MB9vM60nuFu1gVqe78lzXmU5sFOEhihNMP1rZKoSHVwiEQ7MoYa7j8p58oehdQ7ntYI M20LauX8rW+7QCsq4V5obwNIo9iEnZEoiH1a1LAZrrWhWL8pV/JDjoA9wPdfr/015DBb FrQlXlvkWimBdq6NwtStJNzNUgQ9Il8F5roRMVWNWLesHhlJL13nsAFjpWG+p4YwfWhD ak/A== X-Forwarded-Encrypted: i=1; AJvYcCWrFjGpWVwC9QjRIRd7JZeY+1xb6lq1lLd80ONNW2FIKgS0dwGY1DL4Z2BEpSZv3te6UVPtoSp462jnEJk=@vger.kernel.org X-Gm-Message-State: AOJu0Yxu9OWo01svP5bd+VnOpmHOLG/2ci07CIogBHkzH9eY0fbrL5UI 7ukypO0fKJOpEoZ6zmvUD/eGkZaYP8eH+qWU29O8UgnGQy091eQsESWp X-Gm-Gg: ATEYQzy1a3Aaxz7cKmGUP3xkybQHNQH+kGpb6gmDKBr/37PtyS/McYBX18uOwcOaUNV eJLS4olZco3XLBqodg/vSKg0gIXMVYb2RjBu+um5kDlHsNpogePoMjm8D4l3RRI++jCYqMBU0sn QaWTWzu5abc7iNE8mad9KYC12SPJBbCSYCTqDAG5q1tlzmn6BGIrMngNEsWtJT3Ocon5/R5HRGl y041G1nkWhTWFdS9RRm3a39282INznsPzB8hrPWWede+cAIoEFlp430oqUfciaUZ4ad/czZG/1e VlTHZI1a1ck1NjmY+e2qU60B6tW8pjKz7RYABv06n333FEY+gsA8zV4ex2b6/D6HTFEC8qhcIuP UjcUQaKagUVEKcHRi8krca3bsJThdQzAlFIEUqn8k0gUCLyYaM8n3p0rp6PhZhXA2wqrUIvsMha yhnZjhwJrBP34CFb3eIBo= X-Received: by 2002:a05:6512:31c5:b0:5a2:8570:299a with SMTP id 2adb3069b0e04-5a2ab928032mr3211798e87.34.1774863330525; Mon, 30 Mar 2026 02:35:30 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a2b145642dsm1537904e87.65.2026.03.30.02.35.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 02:35:30 -0700 (PDT) Date: Mon, 30 Mar 2026 12:35:25 +0300 From: Dan Carpenter To: Bera =?iso-8859-1?B?Wfx6bPw=?= Cc: gregkh@linuxfoundation.org, filippo.muschera@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: refactor switch-case Message-ID: References: <20260328163357.163332-2-b9788213@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260328163357.163332-2-b9788213@gmail.com> On Sat, Mar 28, 2026 at 07:33:58PM +0300, Bera Yüzlü wrote: > Refactored huge switch-case to lookup table. Used if-else for dynamic > values. > > Signed-off-by: Bera Yüzlü > --- > .../staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 269 +++++------------- > 1 file changed, 69 insertions(+), 200 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c > index b3e34f97cfc6..c02df8e3c398 100644 > --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c > +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c > @@ -989,6 +989,51 @@ static void halbtc8723b1ant_SetFwPstdma( > pBtCoexist->fBtcFillH2c(pBtCoexist, 0x60, 5, H2C_Parameter); > } > > +static const u32 FwPstdma_table[41][5] = { > + {0, 0, 0, 0, 0}, // 0 > + {0, 0, 0, 0, 0}, > + {0, 0, 0, 0, 0}, > + {0x51, 0x1d, 0x1d, 0x0, 0x10}, > + {0x93, 0x15, 0x3, 0x14, 0x0}, > + {0x61, 0x15, 0x3, 0x11, 0x10}, // 5 > + {0x61, 0x20, 0x3, 0x11, 0x11}, > + {0x13, 0xc, 0x5, 0x0, 0x0}, > + {0x93, 0x25, 0x3, 0x10, 0x0}, > + {0, 0, 0, 0, 0}, > + {0x13, 0xa, 0xa, 0x0, 0x40}, // 10 > + {0, 0, 0, 0, 0}, > + {0x51, 0x0a, 0x0a, 0x0, 0x50}, > + {0x51, 0x12, 0x12, 0x0, 0x10}, > + {0, 0, 0, 0, 0}, > + {0x13, 0xa, 0x3, 0x8, 0x0}, // 15 > + {0x93, 0x15, 0x3, 0x10, 0x0}, > + {0, 0, 0, 0, 0}, This patch is sort of a pain in the butt to review... I'm not sure that it improves readability. I had to read until I got to 17 before I found a mistake. > + {0x93, 0x25, 0x3, 0x10, 0x0}, > + {0, 0, 0, 0, 0}, > + {0x61, 0x3f, 0x03, 0x11, 0x10}, // 20 [ snip ] > + else if (type == 0 || type == 17 || type == 19 || type == 37 || type == 38 || type == 39) > + halbtc8723b1ant_SetFwPstdma(pBtCoexist, 0x51, > + 0x1a, 0x1a, > + 0x0, psTdmaByte4Val); In the original code there was no entry for 17 but in the new patch it's treated like a 0. What's the deal with that? $ grep 17 drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c regards, dan carpenter > + else if (type < 41) > + halbtc8723b1ant_SetFwPstdma(pBtCoexist, FwPstdma_table[type][0], > + FwPstdma_table[type][1], FwPstdma_table[type][2], > + FwPstdma_table[type][3], FwPstdma_table[type][4]);