From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AAA73B5832 for ; Mon, 30 Mar 2026 09:35:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774863337; cv=none; b=F6Id07H5eOlX6ujR6fQkt8kCF3Sv78tYpbMl50iyEnPi63apnYhF/7gsTSIxsReKBz8T1omOeNn581mQyH7h8/kDduBLpp8qsJitXl/alaXKXztgBwg0vxoDCD4Pxcka9dJXE4P9In75NhWWxg7Nj83pwSZBCCO85hB+m08kr0s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774863337; c=relaxed/simple; bh=/THPjhtsCKvwzT/E0Ctzftz6Mn22zZmXPK0LI6tBVz0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Dsl5iQrLLjl7+Nbya34px8+1UyEkfguMUpcLasuOcxJdzqBeT8i3jh1v4Klq0dB4gZyHZf1AAekwUMLyEj3kYaL78ZErPy5fXMswYMwq7EoQp9G0LjcRM9H2WnjFfII/o50ylZ5omCBuIPP6/QpV/AxPYm9Q4Nsnh0joCTprmfs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a6w+lIJB; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a6w+lIJB" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b97e6e48b24so724718066b.2 for ; Mon, 30 Mar 2026 02:35:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774863335; x=1775468135; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=T8icbgd+Gvc605wy+mpl63d77z2nXysg0+vXcRUSsPs=; b=a6w+lIJBSWF6YOwyG3CUPzfFtVBd/DCfdsd6smqr5axRN5ET+Am2NeFhF9isPOX81j oiLuynyh9UvGATUVhtmxSYHF0nwREl+myQdhaaGanlKixiS67+pnPe6rcU5qnlfnDk0I 2PuF3CkWrsg6XrOxAQ3/zWrFy4vkF1zunJc7D3h1XCGz5qjU3qbLwPmA2czRbDFB2KpU BJaPOnqijAGwtRJ+cONiNCdd0EfiwiF9kfaXCzZJ5Mj1gKDOhHbcyD+o+bcwp9p+zuMi Yx3kSB05vwAbmDLS37upU9mRvBs3X4uYHXYwze2E2h+3in1p17UhKezrtLStSAr/Kc3e PL+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774863335; x=1775468135; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T8icbgd+Gvc605wy+mpl63d77z2nXysg0+vXcRUSsPs=; b=WA75e6xKV793JYCkFxxGoLCOgTOlXbjEIpJZycG8kjvbAJrPlS51Jn1+7ewZCJegdw pjeDPZZJr4XMCIRvHWTh6YeeLhJelZrrdCsR5RxsiaHaqJkVfPv5ss08Mnr0f9X4Zk3p q4A/UP3jJiiTI2Hc9NNeI9qjJHzPK5c6podv9KqS5CO2/HKcMQAEReoJG4wYeo3BmRN7 V3FWYoccIkQSdoV9kfP+LXJk1uhYCIgxykIYLTCXP4yGbGGoxBF5G1VE5De8we3ifcrx rKliQ97sIQoWh+AH7ak+aSkQIbaM/DSpYQYpeQfiGblqE4S+9xHE5MeXth9kbcOurjbN FDcQ== X-Forwarded-Encrypted: i=1; AJvYcCXRAlLKaNSBz3280NEPb9ubLNzHWagU1l2Z/kAXYnM0rKlE2O4DSYMvGv2EgJTepl39nzUs0t8cFL0K+ZE=@vger.kernel.org X-Gm-Message-State: AOJu0YyoRYRy/bL1KthSMlrVMu0X3X4vrw7xJrTY/l99Aye7jD4K/Ukm HQwXrX104j9GgG/absqp6qX/WZeb4NPJbjqgvDuaKYv18uzQ7UzIwPKO X-Gm-Gg: ATEYQzw2FPcyxvm8DCX59YIpBMVSV74dx5RdAPzE+JTkSxDC+qzvwVlyA8mhaDecWuo j1ROyH/DVyIwLXXCsVEeOwNjBHNdALMjwyZ5km2GLT1WEnTKfXP6VAt0BUckkKw0kYZPpnJSo2j +3vJy+uTBTldOJzgHXDFdYrCsYzQvo09giYYag9grJiFGLbxwvAik9lYNR4Gcl97cAbCHpL7m9v 5mnQVvBQhBlNkilsQkqyPqPXAxTLiWtCZVLVxXG4672WS1ZQOTO6yIhjLSuzVYdLUIgtPSVM3p5 eCD0QUZf8px8foaQ2xwmuwovgNRYiIzmGdFzm9XGeGVS/ONCSDKuqIhH2t+tBnCkaBLtFnG2k8A n+36AqlUEEBvT72P0sH8aPZkwUsgTdEiNzu7B+EVyCQUT6IAx4TBzGfx+lRhOBnfNBLYuwRDm+C jCzdoWSbJb0D0sH1KRwEc9+CCIku9hgg== X-Received: by 2002:a17:907:93c2:b0:b9b:1f3e:fa56 with SMTP id a640c23a62f3a-b9b5094c45fmr423164866b.45.1774863334604; Mon, 30 Mar 2026 02:35:34 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b7b1a65c2sm268002966b.34.2026.03.30.02.35.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 02:35:34 -0700 (PDT) Date: Mon, 30 Mar 2026 12:35:30 +0300 From: Dan Carpenter To: "Jose A. Perez de Azpillaga" Cc: linux-staging@lists.linux.dev, Hans de Goede , Mauro Carvalho Chehab , Sakari Ailus , Andy Shevchenko , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] media: atomisp: fix potential NULL pointer dereference in configure_isp_from_args() Message-ID: References: <20260328192721.255493-1-azpijr@gmail.com> <20260328192721.255493-2-azpijr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260328192721.255493-2-azpijr@gmail.com> On Sat, Mar 28, 2026 at 08:21:37PM +0100, Jose A. Perez de Azpillaga wrote: > The function configure_isp_from_args() incorrectly dereferences > args->delay_frames[0] to configure cropping without checking if the > pointer is valid. However, as noted in a FIXME comment later in the > same function, delay_frames can be NULL in certain pipeline > configurations. The comment comes later in the function and it says "FIXME: args->delay_frames can be NULL here". "args->delay_frames" is different from "args->delay_frames[0]". Obviously args->delay_frames can't actually be NULL there since we dereference it here so the comment is wrong. If the correct response to the FIXME were just to add a NULL check then the original author probably would have done that. regards, dan carpenter