From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84B9D3B6341 for ; Mon, 30 Mar 2026 09:35:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774863341; cv=none; b=Oen7ooCqLlM+Eu7Ys1BpVHSwcHU6zq2hkE/4H1cU2GJI4egCPlV762zyaABXkgZvHWJ8iQe6LdBlEyc5+8ENUuQmYGSq2CyvstFDBaQyMiEzEEuYQtfbVTmlL1Hk3lpYyxtjNXEDo+fOei2+Obx8XJEualSgNEFqHjVoZnO4iSI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774863341; c=relaxed/simple; bh=/XueMGzPm4zPnQnHxrbXHtgv66p4UQa9Q1v05wFCHbY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r/dQvbxVH2rAWXHQGa7eeKP/EX9DlVU7e+qWspdouwAwycGofrAOZTed4TRYqU1S8JmeUqiz9bf75j5pcO0GAO2m9KrrQlBsQmEu9keJKB+cZ7ZdkEkSt65GsfrZCbzEeCxt/EUhNxNuYmIVijh33a9QS5GAfZtLb/87EQVq9zA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cSbglJwk; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cSbglJwk" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-b982d56dac4so726281566b.3 for ; Mon, 30 Mar 2026 02:35:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774863339; x=1775468139; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4BL+71OcAEP7wDYzWwkyQPFAXej1i6XT+ASBhRFYtYs=; b=cSbglJwkaZyBpoLOtMwqFIwPRik+HGZDHt6FKVyGZhs+xw2NrGuUVzguGPGBjvqlqr pxLbSF7XI9faE1/5JsBxybQSXSj8pgKeeucUOAFBpkKX7GgUBrRHlJ8he3XQDZH9939N kXC5T8/87x+B69LeMEsKxrdcpS1jVNq+bRmfnsDm/oIrco5i4eYTtBapmlW3kPMsFGQK B8L+FgGXOtzHwElzUgzevQHHgkgEq34isd7l+dPqmObWPAsXVj1z3DrDspjcVjXrS97B BYLW23i2g19nb20HhdOfwYoAQ/E+3bHTJtKPwZgnCIYwuhyUSj4ncphQP/6NdF80eZ0r tjkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774863339; x=1775468139; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4BL+71OcAEP7wDYzWwkyQPFAXej1i6XT+ASBhRFYtYs=; b=f0X7f7YoRm1lW1TL50jSH9mGq35gks7xekjtXLGg5LK0MvZg6zfeSgruIsuD4RDyyW MCUez87UcAc8hXsrWw8Fy9/tuCOksvz2V9adqUfHBLv4pxE8sUDMVQf8qAjHTkN5ZmYk 4HVk1dIUZyYoiJoaXeI/shJ1pYnpwy3Z2IKBTS3dwqr9n90n8FZHQIyzfZdWlgXfMcag XvdWP7l4u2+eDxlQoLcsM5bD9GiWTy0Pj6GOUvSAmahk/lBAZH9wHIhjX6pzXuhK9BZ+ A8XYR8E8vyMMgE1oGkWOb6MtAjYWJCZMs4X2JGXd/r5yPkIft+uLofCBXm+nbWrcMAqz ZUsg== X-Forwarded-Encrypted: i=1; AJvYcCUjS1k/2hFSDkBBFkckfZgE4ymI3mVKL5Y+4F5OlZKb06X1AxLG5/mPhFZUv2sd/zAn7KC2vi5In7EBxnY=@vger.kernel.org X-Gm-Message-State: AOJu0YxrbVUvKQSrjRNZn4L6WUJloR/TQnDyZ04hmHVhEtH+4G3+A96H Ksz28A3SX7lu0RjrWLta4r8Fbn7kRmYCM2fmn0m5j/c4kZWRZctV7oog X-Gm-Gg: ATEYQzy2NrItMhKKxC8dVgjv9kSZWtxrHoC54At4XldFUQzq+tFwT1GXeD8yv82adld s1YTDiI7EcAHqxzpimdZVqYNORdWqwY8L2xz/KgiUoJIv7B8Nl38oDMZ4b9RadBMlYODUZj2J4z wRTi10cWHTDa2YJv83ozUw4vDKsfgpNAGNgZreNU0hHZ2FEm0Z5BvA1n/k6EsmvSdJYgEms7MQB HtlCHolV8L+uKHVeJkOkYiN7Z0uhQ/qrZu/wsj0b05kA5jyWjVvHgJHE/fa7j5/DtdaTnUFoxu8 9X9+slvA4QKI2ZTx11jjQQzOV7aAxmFnADQD6nvI/37VsYno5S8tb2ppa+RaVkReue5D0P92TnQ qlxKp/VjD6nKmODImS+lm9K0fPannX+szk4q+KjMtYSVUaJoIQ+If8kNpfw9BTtUS8cleWVhHuY FzHIv6Be7ukQwOVRwfhM8= X-Received: by 2002:a17:907:80e:b0:b98:29fb:f32 with SMTP id a640c23a62f3a-b9b502b9148mr792518966b.1.1774863338773; Mon, 30 Mar 2026 02:35:38 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b7b1a6744sm250626466b.30.2026.03.30.02.35.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 02:35:38 -0700 (PDT) Date: Mon, 30 Mar 2026 12:35:34 +0300 From: Dan Carpenter To: "Jose A. Perez de Azpillaga" Cc: linux-staging@lists.linux.dev, Hans de Goede , Mauro Carvalho Chehab , Sakari Ailus , Andy Shevchenko , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] media: atomisp: remove redundant call to ia_css_output0_configure() Message-ID: References: <20260328192721.255493-1-azpijr@gmail.com> <20260328192721.255493-3-azpijr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260328192721.255493-3-azpijr@gmail.com> On Sat, Mar 28, 2026 at 08:21:38PM +0100, Jose A. Perez de Azpillaga wrote: > The function configure_isp_from_args() contained a duplicate call to > ia_css_output0_configure() using the same output frame index. Remove > the redundant call to simplify the configuration path. > > Signed-off-by: Jose A. Perez de Azpillaga > --- This feels like a guess work patch. Sure, it looks like duplicate code but duplicate code isn't always wrong. How do you know which call to remove? How do you know that it's not a copy and paste error and the right fix is just to change the code instead of deleting it? Patch 1 felt like an AI patch, and this patch feels even more strongly like an AI patch. Please don't send guess work patches or if you do add a giant comment at the bottom saying --- "This patch is a GUESS. Review carefully! Untested" regards, dan carpenter