From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011057.outbound.protection.outlook.com [52.101.62.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B643E3C3437 for ; Mon, 30 Mar 2026 13:46:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.57 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774878381; cv=fail; b=iYiGqLl9S6VbIQu1rlbUkuJPoLxt3B4ZZyifBt4adQ+HZdd/7aL5lKhvp9MEddEnBg3xseRWTTtDQbAb8qsaxaguk+TkmMqrXH3/uqkdDW3bj4xIpt4ElQQUfRGUAKqWI/uPsOANOxWyHt+EyR1QBcjrUtUPoBwU1bwBNBL1xjU= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774878381; c=relaxed/simple; bh=Ppqsq2sh/A13eioobhjrtVO9FQ79zrJ75zW3o3zB2Xk=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=tOenOcG8AcFA9EkFmR/SPuqBD3NBmiHcO2mjFJAfIiGvYFfdXiSvZMrEWAm+8aEz8AMqSDw2FA0/jq7Rd+b7cfg89vzuOV5TuIyzjzPJSFvIjW9UGfjSCGS0gn2aa0hGrlS5qMyjrK3v3lAXqIIOMAPRtjzEUklyi+8gXd2lljA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=lQwMAnw2; arc=fail smtp.client-ip=52.101.62.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="lQwMAnw2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BYK02GgwpTSTHgTvuLAfY5lZ2jWYQROE7EV4JQY0CEFkkV8yesMB+DZ0jKjAin+1X/0ZzwNBrSy2bK7ZV1Qnu/9W54Sa1H3df0LiOR8pdj4zD/ttrwednI4aFAduyCEHCbfKCFgNLM7npT8a0beAK1GnpH4ccvYd5EpyTynzAhyfzvw7NLx5uPCjP5d5EUHR4vscM18fHRL8qhR8ibbGqU4/79VYzB97mWtoxkmMTZjIRnfnbfP92BXaV5xmTkl6tPePP7sIgXX+3S93acPfep5vfF2U7xl2adaHLb2WIhtAgdy7mdxyHS8W4qy97xW0i5Wr3kJNAhUbQ79LcXhXXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jffBXNORRD4X/2pwV6muVP4+ZlsoV+ERte8+YWWQkw8=; b=fvzjjzeKZ/QgY10pjSXf2ZisQQGpjarMp8+7/rHxj/VvTPkM3hpd8SZAPAFgVDFNNb92vc9GYi0VCKmahILdvTLrqrDSRfn28sbDUGW5MDaLdwv+T9SttCx2oaN+i8hUO+5OIjdPeIcZ1fjU8Vs4kVls1YKpvYsIY/GfJ6bVBqFxdox8miOL6FF1WphvLWvvbkfZRBrtNQcLpFaInZ1XCydsRfy1eGuHL55a54bQ5yzLN1W5MPgs5OWATovX8yjwNL2b8ponX5rnzRtDLAzlHs5YzD2xhxvc5RYFvb+Mxddz4YN/+P6CY867cN01YGX3ff5wPLRC6sRKNuCxZ7Qi2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jffBXNORRD4X/2pwV6muVP4+ZlsoV+ERte8+YWWQkw8=; b=lQwMAnw2XB1UdclnAvgq1dcgXoJ8oroCSh5hOP8exjuJKfm+EALRS0DWVzc2WMNd55cuE3xh+f/ASF2PgP8BHNI5O8RZhwQC41rZtu+eVetCeuocf1DjF3W6HXW5WTnlRn5hVmfGOvSrfdmls9NJkX1smI10Wcbq4exoSDDIJKoS/czX64xVnHgFKFGtXtfMMhv38k8n91JlXTzOLudbYJjLTizWcdiJ+wNkAZqO8fiTnK1iAEcbqi3U2+fueUM3xBbKqssEYjxaz9W5FxtU0ZbLtkF9E6MVppzO8ZCzKfTUNKIwZLsOhUKXQKN6HeqrW6fLwC1vHiD3rFEF+eu4lQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by SN7PR12MB6767.namprd12.prod.outlook.com (2603:10b6:806:269::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.15; Mon, 30 Mar 2026 13:46:10 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%5]) with mapi id 15.20.9769.014; Mon, 30 Mar 2026 13:46:10 +0000 Date: Mon, 30 Mar 2026 15:46:02 +0200 From: Andrea Righi To: K Prateek Nayak Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Christian Loehle , Koba Ko , Felix Abecassis , Balbir Singh , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] sched/fair: Prefer fully-idle SMT cores in asym-capacity idle selection Message-ID: References: <20260326151211.1862600-1-arighi@nvidia.com> <20260326151211.1862600-2-arighi@nvidia.com> <258e2e94-ee42-4ea4-998c-4770732cbad0@amd.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MI1P293CA0009.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:2::6) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|SN7PR12MB6767:EE_ X-MS-Office365-Filtering-Correlation-Id: aba0db76-8c38-4bb5-3074-08de8e62b34a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: oxhL+v3lL79wxFAn8AZMIxH45McG8JWKmIhLC0EybG6GRpGR6z8BRYZGq6HKi9SodPRRdO0cOGoEEXxBcrpHVLE1kRtlcYUQqdIUPdYyR9VztVpDvLv2YBm9s6daol2kMFmk4bKP1SZh1t0gkvAK7efS6BU4xkPrsu5tJ6U5PPSO7YRy6Lj+5H3l7cjWcUFUfvfQXzSosDXZlaEzrZcykFvee+/tDGbE7XKbtlywgqM6/5tcaaE8id24OXNitsgZju9Uy0L/GkRGsaI5ySaV336ZmjtAMJfOk0Y6ecBWVIMy2f/AYnwN2NfqIXmT2IZA2Q6ckUqk655yb9EhcCaAza+bTze65AYdL4XzVNX1y6zROg5Kzrbuc3XLr0jrfw8XVv7ZEXPnx1F/vYPD+K3QZ5ccqekN707Qe6g+mpdzLHApITHE6rmXlHZRNsTyessSYUGPlGwg+/ucO+iZBj6iQOKrCdvN8LyHlMvP9Dg++M6JVtT1KnZE7ao/zVQYba6sX3mlkGaPu2GH1MrEyOPN5y61pBM86vWfxw33UVo2ffaOQFivz/gk+fXCjYd5jnPVS4cS/8A3Y5U+eQ7AqMn46L9PQdZek99Ix6u7iA7nGzlzq6Le/HesghyfHY0pOrcNyLVuQWyKIlrNXveatvzWAjFd/N7+XEeyrmFHKiF2NCSkatnbqRgaptRYpZonyP2gKnafMknVQFsDTeeyaZ1g2CdzptnMcYm4TpqGpZxT4js= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y1EOfhbtcgn+wJb19ijW/sg/wAP+RCh4yyaoFLLV5iXKJcksWO6utbTuoN5K?= =?us-ascii?Q?iHoxYbCI2NeIxkKMi9Bw6+cBCRlGAV116zD1NLeZqbKt48YW9rAwfgbh5Zge?= =?us-ascii?Q?GzyC9Y4kgcntpBy/u0UXw9l71pG6bZ0aNdm585UAFEvd4/8dFq9Va13Hwtyb?= =?us-ascii?Q?kioEi8EeKRlwHMw7Md4tF/fpOWDs+mSW78V6xKEnX6CP79Rng9d/5AFQAiWY?= =?us-ascii?Q?bXxBBfiw5Mn1KtdOIqy3+m0p1GJTQYXRF2corClI3N/uUqueqRzIXUnmuqWw?= =?us-ascii?Q?RNK5hxh3qMIf8hC+t54xrsym/L2F56HAdvQDeHbrAwIT5uFlyxMUBqyCgYuh?= =?us-ascii?Q?pk5W8gacQ319u9wNnzWnHRxWewjKG2K2rIcG4p3si7LUxH6obDxGh5oPZXsL?= =?us-ascii?Q?Bjb9YDXql+cWE3nt6tGVo9AY50EBHOMi1LcZaE3kmYNaq9XAZM3XCh+KrtN+?= =?us-ascii?Q?8tAxDNBYtKaeIaK85pn53xFRTlyXOVXN+Pq/vL8i4DIggeSwAk3/65kqwdCY?= =?us-ascii?Q?VzeBJLWioGSwjhrzsPD/uzcotGD715M6fx9iYZo99ZaAgNbSsYZ6VWlCXkVy?= =?us-ascii?Q?QcGPSDSn8AdungfH7Y9pWN+vRF2ulTN8GZD7oAAVF55TilDir8ZqGV1LI5lw?= =?us-ascii?Q?otcPHt7TphjUtqnSZqZb4TrC48TrDqehWX5M7Hnq6gnuRjPLBnZ8AmWHybYv?= =?us-ascii?Q?15pZ0cf5n0TrYFBo7DuBu+1YZ4RvxaXxbb6rRf72fzDcAhvhXynGzrFbGX5Y?= =?us-ascii?Q?pqkr6quWYiNZf5i2nDH8ey4QDdSDA6UKRd1PrgGoU7m8cje9/p9W02g8xev7?= =?us-ascii?Q?Hu4YDa7eBk8VZ9aZcm9nQuR+ayjzrKBLcOYjl43Os9MIIHqRizRkUa8+ekI4?= =?us-ascii?Q?M1ywHT3hV3tb72G4siChBCdFSmYzHS+TKZqt/QZDQyIeszXor2G12WQZ/ZZo?= =?us-ascii?Q?QSR9pvzo9zczI0//U6JRID2R40r2//DDMjiWv0y/3YdIJxsMGoCPooAE2E++?= =?us-ascii?Q?n52keamUfNiUNoL+4cW6sUtZ6TBe0NmiAXb4rZ9/yPFRPSdAsJmKNCei3TQv?= =?us-ascii?Q?kYS6T+kxAqcx5mrF5Uxes7h9Z74CJlyiPFT16ttlNbnY0u++JL3E4E1jLEk9?= =?us-ascii?Q?Mooc1jS0RxSz/8mwv0TKvd1dQGxtVqj39yZgdFLbbVn9r1ygWNiDPaWCrCiI?= =?us-ascii?Q?djr5f1MpQ+a032uqP6yJztY8Dtq+bydaQaJ/OlDJZDJUERBhpOLGxeHuESrJ?= =?us-ascii?Q?NXHRQMhUecmMfthmgkX0BmP41gty3EkOcfC/Xt6OkrnSl/F6XDmoHCwK8HwY?= =?us-ascii?Q?l7kjq4xV1Zt0xZwVbn7RZUVzHUeQiVYUujtPd2DRMJZ1YSGIBMBiOYcbEv3r?= =?us-ascii?Q?i7aG7KVkjSNt4XjRwx6TJurl6zpuUbJ5gIHvNMwrxKDwwcsL5IhmAp+N3plF?= =?us-ascii?Q?hM60obPeJDGQ7QHjRshi3GwNJHBAY0pm3Qnsrxh7+NOVvJNJ7cdSjg/ZrqAq?= =?us-ascii?Q?6Imq99RjddSM/mV3kYdN0jjHrRveKUJFSjDF5jSSbqREX8XybqAcWy4JAuTg?= =?us-ascii?Q?3Nujw/5cmBSZ8hpKBNklfJK5NWcstjt1O9nxJAC4clafJ9orM9yWbCNhDFV3?= =?us-ascii?Q?TFb3g1Jt6A2+n9y2BropDbXr0oUWR0nLT60OW7NBc2ui2K30yvonScDYglll?= =?us-ascii?Q?JGRNuMpO5bhGOJWOCYBqkwEsyQ2jIBcnrr7snE4UYPj0PkV9HqTXVhO7VNd4?= =?us-ascii?Q?oe0cu6U4Vg=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: aba0db76-8c38-4bb5-3074-08de8e62b34a X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2026 13:46:10.0685 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q6j60C/GMxMsLEgBgBAsxBmnB1Q3Q0hYy1dkt6FaUB84m+Wt/uWrCBp+haJ3mqi6DLA+ngB2KLK48x5ty0cbhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6767 On Mon, Mar 30, 2026 at 03:22:27PM +0200, Andrea Righi wrote: > Hi Prateek, > > On Mon, Mar 30, 2026 at 03:47:07PM +0530, K Prateek Nayak wrote: > > Hello Andrea, > > > > On 3/27/2026 10:09 PM, Andrea Righi wrote: > > >> My naive eyes say it should be equivalent of what you have but maybe > > >> I'm wrong? > > > > > > It seems correct to my naive eyes as well. Will test this out to make sure. > > > > So I found one small problem with fits > 0 && !preferred_core where even > > though it is an ideal target, we don't end up preferring it because of > > the larger "fits" value. > > > > Here is an updated diff: > > > > (Only build tested) > > I'm getting worse performance with this one (but better than mainline). > I'm trying to understand why. Nevermind... > > BTW, we also need to fix asym_fits_cpu() to do something like this: > > return (!sched_smt_active() || is_core_idle(cpu)) && > (util_fits_cpu(util, util_min, util_max, cpu) > 0); > > ...or we'd return early from select_idle_sibling() with busy SMT cores. ...I was actually missing this piece right here. So, everything looks good with this extra change applied. I'll repeat all my tests just in case and will send a new version with your changes. Thanks! -Andrea