From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 163F833F8B7 for ; Mon, 30 Mar 2026 17:16:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774890999; cv=none; b=nA937zbj8buJSfglgKsyJRkkEDEForniCIY+o8+3FG7Dvc4BSwqssIYHAC7Z7kaicjDodkEmqHRdQI6WE5VHIVFwSHMnuJzlT1DzYaW4I0HrTHZ43HPNK19c23cQlLjJc+OdAbrSrNWzOgPm8ZpS17vlZ7bIrwI9bK7S5+7EQOE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774890999; c=relaxed/simple; bh=/53q4LprWmKV0en0EUfjc+p4vSUV/RR8VwSwgHi03Ug=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nvB4u34q/lKTNHtRyp6eK+7epq/VkThdtlhEj3qAohhgTUiPSLMGc3rxRE6uWA75bVOvbMssDDMj1AbNfT9O0qf3JrPo3ZGwiXVrBxoNZGIeVWX4lxzwVhU/xS0VIYBHB+3F30rKMtRx17Fgw8+3H8N1lOagvaQ15QNUnOGOVSw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eriayQYS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eriayQYS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D55DDC2BC9E; Mon, 30 Mar 2026 17:16:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774890998; bh=/53q4LprWmKV0en0EUfjc+p4vSUV/RR8VwSwgHi03Ug=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eriayQYSBMvAbj2ID6x2IGQVmoJdjzqMeIVdDmmlQELK9Cf4oXTqMzJKQAzzGvZa3 eY4syMgrYQJxDeum/3YXkc1vq6HP0RzjhRNfI3TYdLhyiKaqB4V0/wgRg+JKApLmH5 r/0nM29of4V3808g7YCwen18eO8HG/S3+H++lM+k7Zb3AJ6BYpXKnUTQCajpW6MAqL K7mM8zs2aVyAGLmo7Ys+VPdXnQRThueIrK4kDupN39TEPIqShMNLDZB5YPs/Pl6qYx 4GMcnyzcVW6YnkxlzDkxJAJJuSuUZruxjRjE5N4caaJvfZoOqGtgCGiNPjhsMUzrDL dYVwsfLdnr4Yg== Date: Mon, 30 Mar 2026 20:16:32 +0300 From: Mike Rapoport To: Borislav Petkov Cc: x86@kernel.org, Bert Karwatzki , Dave Hansen , Ingo Molnar , "H. Peter Anvin" , Peter Zijlstra , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/alternative: delay freeing of smp_locks section Message-ID: References: <20260328081634.797552-1-rppt@kernel.org> <20260328114118.GAace-Xu8bEKacpCtZ@fat_crate.local> <20260328195827.GCacgy44vl3_AUvhVr@fat_crate.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260328195827.GCacgy44vl3_AUvhVr@fat_crate.local> On Sat, Mar 28, 2026 at 08:58:27PM +0100, Borislav Petkov wrote: > On Sat, Mar 28, 2026 at 03:39:15PM +0300, Mike Rapoport wrote: > > It's as old as CONFIG_DEFERRED_STRUCT_PAGE_INIT (v4.2) or even before that. > > If you think that fixing this leak is important enough to backport, it > > affects all mainlined stable releases. > > Probably not all but perhaps the last two - 6.12 and 6.18... > > > Yes, I added a WARN() in free_reserved_area() to lure such cases and > > prevent them in the future. > > This warn is supposed to catch the leaks. I guess it is important enough to > add the warning so it is just as important to fix them leaks, right :-) After sleeping on it, I realised there was no leak, and this is only an integration issue of recent memblock changes, so there's no need for cc @stable. Since this fixes a fallout from memblock changes, I can take it together with them via memblock tree with Ack from x86 folks if you prefer. > As to the fix itself, arch_initcall() is the magic time where deferred > initialization is complete, I presume? > > > I'll wait a bit for more comments before rewriting changelog and reposting. > > Yes please. You could also expand on why the arch initcall is the proper fix. > I guess deferred init completes with an earlier initcall. So yeah, it would be > good to have that written down explicitly too. > > On and pls use those tags: > > Tested-by: Bert Karwatzki > Reported-by: Bert Karwatzki > Link: https://lore.kernel.org/r/20260327140109.7561-1-spasswolf@web.de > > Thx. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette -- Sincerely yours, Mike.