From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E7E7395DB4 for ; Mon, 30 Mar 2026 20:06:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774901189; cv=none; b=I8cGn6jT+DmNBgaavSA3C7h/Sg17Mump9AprWQvYqFhVj/pnlMS8J6R65MSpaISl0lNLR+9d4IyKGu8B36MD/RnbD+p7v+pbYezpTUoNyZSwOOhu908HrWOyYgNbbfSnUvIwoVu/aq9GApPZkyIAhIWiL7Gni8YIzerXnkqk6Hs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774901189; c=relaxed/simple; bh=TdIhpxHLvVnFqrwUlI3yJd5w3NzSrEYec63H4+DvE/I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RVJRtiySuq7lAEyBeShREmLy20ehw92lT1W1corFFk44if4h0zaEEfL2lh+4wiBpKAbSG637FHneWouL8WdfMigws6gN19L91+qQlVo66GU8v2cp0z8Mu4P5B+I9QUQELxHXMiMzmg01EgdIenDA09s1IyE9f882snFb4bd9HcU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dOTJInXN; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dOTJInXN" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-48702d51cd0so58873125e9.2 for ; Mon, 30 Mar 2026 13:06:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774901187; x=1775505987; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cLwIMLuhyVAYc+PwPkVk/veDbq1sLle8zjJns1c52Dw=; b=dOTJInXNRgBZb8DJC+4JfdHRhX6hZhmpcpMsjTUpTFfHc84aLL586XWLGBgc+qcyou JTA6pHIGRqqPBaF07Y8UyVsEarX5qviXJX2SPiD2cCpcGFJZdrKdjJuUlWYnAwHFNCsV 2CqYqntiJFoJTiqEFqgiC3di7qq8bMp4tlLB5CRmHfWPneHRgQytYLaliCmGJhQ1vfbp U2pUySoiJdg6cAlr6bs0cO7tBgpqlxt3CHCqYCpHVfJcbFGoADBfSl4N1sJaOEZRxJ4x 7qOII60J0vZMiU37DaQCfASqVmw2hXXtEvmx4yRAhi+YDc4LBpXvqAPpkG9V7luTNgig Ap6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774901187; x=1775505987; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cLwIMLuhyVAYc+PwPkVk/veDbq1sLle8zjJns1c52Dw=; b=NsliNjIKEWq4ApBNyPvLWkvPYkoQOsOTV6GVX8Pf7R5EikWyIqrch6LgSSxwHggz6Q +8sjdQzEJXGm4+YLioh2oAl+e1qBFvsl6NLh1w75b+tWzg0tlMsE1z2A/ZPqWYZU2cLi iSa2CKHh5Z7iRyVj1nYAsZdCUSX3FZ1GLs/Y9N7ttNOm6BwB+yu5yqSV1ugzwHkXnMLG beAi1VTPvJ9ID8oR36lt+8WHOOwYFzD2oxitEG53BnC0oKdaazKRVG7r/KeVs5KVbdaG d50LDQcd2IshHNhQ+Y2i20qN8oMCPbZOhNhQeZlyc37WesVF+MH26EC7mlU0it0w3Rdx gsiA== X-Forwarded-Encrypted: i=1; AJvYcCWfqh7UFyhfN4vHPiDIO2LZqLoWNeGUpXePlmxlJKJLZTHYoQwUGyIGKzARFSOoIYC0wK2PbctJ0u5BZSM=@vger.kernel.org X-Gm-Message-State: AOJu0YzIlJPkzEU+EMXYdH6XOC5fAV1e9cH1/knYNQ6UrdSZB8IJZofN pLKxien2OtN7tKOH7U8tlMIDrmMEIy19c3aUFuC91pecFqUdjjboyAO4 X-Gm-Gg: ATEYQzyQf7g4GRYo9j1YgrZya/v3eBrKVOkxeTudPJxKN1PYKe1efIERsZ+GnsP5k1k AO5uncGI3e4u+gXIh4YvdlQ8KjDln3L4ONjJry2zASc9ZZQxgDfp1pPUCkhHTJs99jvwFbe9iex oWTSFQgRH5DJjBSDE8ipXBZLSFQVVvbS9H+QTy8qS8c03o7nvaRaSitE2xjS2ImDQT9D2smIQSn wmVHUwC+vwegQidP8Qq6zXz6GM/0897HDe7FlZC/CyOk5Ws8U2f8R+oXbGP0etAAYjSMoyvYNLJ JAbVdi+PTp426/3Wy5hq1JTX6jdGPj+M9auZCTT0y0yS7nEjZP1adRlX4L0Ov+CmFs7PTQFOOlt xhbQJyWLWm1lKSwURY3vPVNzuimqvLYxiJcoHQKVNUUPbFyIpHWtGoN5SaSN2L/60kOVWUAkFls P8idnkasqlU9UMeRrMoew= X-Received: by 2002:a05:6000:2489:b0:439:ba75:7dab with SMTP id ffacd0b85a97d-43b9e9d6022mr22752221f8f.9.1774901186597; Mon, 30 Mar 2026 13:06:26 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf21e29b1sm19881947f8f.8.2026.03.30.13.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 13:06:26 -0700 (PDT) Date: Mon, 30 Mar 2026 23:06:23 +0300 From: Dan Carpenter To: Ethan Tidmore Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: rtl8723bs: Remove dead code Message-ID: References: <20260330165510.33134-1-ethantidmore06@gmail.com> <20260330165510.33134-2-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260330165510.33134-2-ethantidmore06@gmail.com> On Mon, Mar 30, 2026 at 11:55:09AM -0500, Ethan Tidmore wrote: > @@ -413,17 +408,14 @@ void update_bmc_sta(struct adapter *padapter) > /* ap mode */ > rtw_hal_set_odm_var(padapter, HAL_ODM_STA_INFO, psta, true); > > - /* if (pHalData->fw_ractrl == true) */ > - { > - u8 arg[4] = {0}; > + u8 arg[4] = {0}; > Now there is a declaration in the middle of the code which isn't normal style unless it's a __cleanup pointer. I would probably just leave this comment as-is so it serves as documentation that something weird and historicaly is going on here. regards, dan carpenter > - arg[0] = psta->mac_id; > - arg[1] = psta->raid; > - arg[2] = 0; > - arg[3] = psta->init_rate; > + arg[0] = psta->mac_id; > + arg[1] = psta->raid; > + arg[2] = 0; > + arg[3] = psta->init_rate; > > - rtw_hal_add_ra_tid(padapter, tx_ra_bitmap, arg, 0); > - } > + rtw_hal_add_ra_tid(padapter, tx_ra_bitmap, arg, 0); > > rtw_sta_media_status_rpt(padapter, psta, 1); >