From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EE3A175A87 for ; Mon, 30 Mar 2026 20:51:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774903918; cv=none; b=P0Cy46Y/QueKRGDIc72plV82V+x6OaLR4Gnp4XHO8kRHj9IPVbznuAtQKGmmIYyqJIGf0ZLkNhR99CRN+3Tqva285m5vjPLhJ1TsAXTDPhfpF1IAh2bFrC7rLNbqDSNN47bFDn8VP1odslb1YF0WBg5bCDBg1plWHOjdZiat3O8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774903918; c=relaxed/simple; bh=RF/l4+Rx48KXPgaZsFriDOiMEON4ybiOtLEySiPla4w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TXtlDjdTLZHsyOQ54WMkLtO0k16P4mh23sbV0+//P6AfQka9/uozNvUlXxmv9rS66uyElQeVeVckl6zNC/7EboW9+aR+hpFGitFXPXwgj0Blpv11TUin/ecFSbbIP0beDk6NN/ecXKFmiLQhvlaMA7RcsfKOFhbttfQLsxhRJfE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=E+0wM7zu; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=E7At7uNb; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="E+0wM7zu"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="E7At7uNb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774903916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=24jNpsvF/f2iekt//6Khf9d6Gc97vDONJaHwgyE2rBk=; b=E+0wM7zu74qbrAgKvv8A/jYpA93sbGFgoYZ01YVdpwlw24TvFAFmN9Vm1GYhQZzxiwrsA/ nFD51Hnl1d/ZgwmKZpmXlsdNtRk6/4765i9BhUx/3ccQoudDN1uIPgKrrxUg1bsw6pGJDN EgG8aS3cMmtDrdx9ux8HGfe8qYurEeI= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-261-1HUj-zKHP-yr6n6HxUhSzQ-1; Mon, 30 Mar 2026 16:51:54 -0400 X-MC-Unique: 1HUj-zKHP-yr6n6HxUhSzQ-1 X-Mimecast-MFC-AGG-ID: 1HUj-zKHP-yr6n6HxUhSzQ_1774903914 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd827a356aso1293878185a.3 for ; Mon, 30 Mar 2026 13:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774903914; x=1775508714; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=24jNpsvF/f2iekt//6Khf9d6Gc97vDONJaHwgyE2rBk=; b=E7At7uNbNvjpeEa4xrJDaYYg7O1Dd3fAg6bhIqx9ZFnHDH7EDOuhwstLjI3vS2XeOM aAqVLuGXdgXJB9s3RgrqxhJ12BCFBv4OAZYxmjpjy7vjeBv6hBUbAO0Kif3L2FfgMSmF kIPegUHqOwjqJj0DEji0bn1co/xe29jHnaP4Aln/v9sX0SI/z7dBn4QL0kFvot2Pk7Q3 BPebru51voNI1M9EZRTb9hkeCJ37hQf5tP0BRdUFqjOhz6nUwbi4idI8iAQrjXx+LZYA gZrY4JBnYmksjzqPLskITfIf4xN+DH65Tm/3lodHX2UjhoifJ8IbmoeWoEadqoeuut7H PftA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774903914; x=1775508714; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=24jNpsvF/f2iekt//6Khf9d6Gc97vDONJaHwgyE2rBk=; b=QhhCYbMRNHgMbEgRxIEbA9l1mCTaK4WEe4LPA1MOTkHDf3c1t2/BXPgOUW7Zjfjvat 3QO/BmFb0uewleW0yQB1k1wr1vDLZ1WJUQCNxmE3YIVNUITVRhOdbqjAdbpSKt69uWdp kKMBEJgyb9EcfucNTGPGl2BYEobt4ErjCKrcb2AvWPRdJfxhW/Y2fqKbQwBV7jHpT6v2 5IQfXJaf4weAbtbW4/U1jsmCMUKYWzrJzrMqwbw0UG9u6sY9LuFwe3auH7c8WUi10wwD B6gCVsReL2otF8yZ3+y5NEKKU1AA0ICpt1GeR4UKGLwmFpyLIK2CqShUs/QWDXLUvezk PJVw== X-Forwarded-Encrypted: i=1; AJvYcCVqO+6b40RvTMAf1dFy2eZ0mnQdoWjiCGmaAZD1DOrqJt3NMWTtHvw51kxkbAyh0zS0KvzWejE5J/DWtQE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6Frc7Cr+pZj7p3d66jrQ2otu95vSlXjgGnWOOMMhkXVf7GHab sL9pwrDpgFH1sSl9P6ekElMvnEXIunNL+nDZyDS77wAfYQZ5cAqkZukK7VWfRlQHHD+GXg/XSrF PFm2GoK9Q5xUKXT9NFO0u3pjGcXwAZB1ohs2ei6AtvHiEAwdWVmVFC9vGNgnzgHhNnw== X-Gm-Gg: ATEYQzz/0VxiYqQjqUWk/Vt7a++7gf67uvhFZErrQHuKXFnNWsQiie7vtcqFbKZMYBP sEcELJG/b/Cz/red3ZEuXVJr4xgJIqMh1EUJ7AFySp3PeVveDRNvcGWrDqqX9Xg2H9Kdqm1YPV3 WiTonq+Nm370GUTIQrFIv4i4HHgEcSlIpL7GaNN297XtqKVLE8p44hMkxW+5UNALBoZnOSxrITf PIohDIO1Le2AoiY4nvdJ2y+vRD8IPpoNlZysmXRuLQd4O+r2SQfA2+NeQjPYkLcukhQ/bOe/70a PzN6wEKCpvYwUx2+10DXH00WuaxXR/1lTgJgCncTUx5G7uCI5x9oYdAbnyacoiOmXzmggKGx3Cy E8MtdZSOtrbHxfg== X-Received: by 2002:a05:620a:4514:b0:8cb:5176:ef8 with SMTP id af79cd13be357-8d01c60e98emr1932212585a.8.1774903914129; Mon, 30 Mar 2026 13:51:54 -0700 (PDT) X-Received: by 2002:a05:620a:4514:b0:8cb:5176:ef8 with SMTP id af79cd13be357-8d01c60e98emr1932209585a.8.1774903913627; Mon, 30 Mar 2026 13:51:53 -0700 (PDT) Received: from x1.local ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8d02803f2c9sm706603385a.23.2026.03.30.13.51.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 13:51:53 -0700 (PDT) Date: Mon, 30 Mar 2026 16:51:52 -0400 From: Peter Xu To: David Carlier Cc: Andrew Morton , Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/userfaultfd: detect VMA replacement after copy retry in mfill_copy_folio_retry() Message-ID: References: <20260330202909.136776-1-devnexen@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260330202909.136776-1-devnexen@gmail.com> On Mon, Mar 30, 2026 at 09:29:09PM +0100, David Carlier wrote: > +struct vma_snapshot { > + struct inode *inode; > + vm_flags_t flags; Note that I used vma_flags_t / memcpy() / memcmp(), explicitly because IIUC we're moving towards deprecating vm_flags_t. Please see vma_flags_to_legacy(). > +}; -- Peter Xu