Re: [RFC PATCH v1 7/7] perf unwind-libunwind: Add RISC-V libunwind support

Ian Rogers
2026-02-26T01:34:30Z

On Wed, Feb 25, 2026 at 1:08 PM Andrew Jones
<andrew.jones@oss.qualcomm.com> wrote:
>
> On Tue, Feb 24, 2026 at 06:29:37AM -0800, Ian Rogers wrote:
> ...
> > +struct unwind_info *__libunwind_arch_unwind_info__new_riscv(struct thread *thread __maybe_unused,
> > + struct perf_sample *sample __maybe_unused,
> > + int max_stack __maybe_unused,
> > + bool best_effort __maybe_unused,
> > + uint64_t first_ip __maybe_unused)
> > +{
> > +#ifdef HAVE_LIBUNWIND_RISCV_SUPPORT
> > + struct x86_64_unwind_info {
> ^ copy+paste issue?

Seems very likely :-) Will fix in v2. I'm still after a way to
generate a compile of libunwind from its github with all the remote
headers built and not just the one for the host I'm on. It seems there
is an Android solution for this, but I was hoping for something more
upstream. At this point it is looking to me that libunwind is a dead
project and we may be better just deleting the associated code.

Thanks,
Ian

> Thanks,
> drew