Re: [PATCH v1 2/2] media: atomisp: remove redundant call to ia_css_output0_configure()

Dan Carpenter
2026-03-30T09:35:40Z

On Sat, Mar 28, 2026 at 08:21:38PM +0100, Jose A. Perez de Azpillaga wrote:
> The function configure_isp_from_args() contained a duplicate call to
> ia_css_output0_configure() using the same output frame index. Remove
> the redundant call to simplify the configuration path.
>
> Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
> ---

This feels like a guess work patch. Sure, it looks like duplicate
code but duplicate code isn't always wrong. How do you know which
call to remove? How do you know that it's not a copy and paste error
and the right fix is just to change the code instead of deleting it?

Patch 1 felt like an AI patch, and this patch feels even more strongly
like an AI patch.

Please don't send guess work patches or if you do add a giant comment
at the bottom saying --- "This patch is a GUESS. Review carefully!
Untested"

regards,
dan carpenter