From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 097062C1593 for ; Tue, 31 Mar 2026 05:49:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774936189; cv=none; b=XoTgCd3mTwowJyl7ROQYpXkFcjSzvHG6svegYpeqKqnlqWvHBKgtVcaCunEhjqeDr9+aJrTG5cziDZ2svgq3bRpqTnCA5fslcFCRutrWGprhbi/WZ4mufqDmfUjR3/SnDxqxN9HC9a0gGRo6Ixa1m0rQnp1BQvFNE5+KMDiVamA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774936189; c=relaxed/simple; bh=s8uPxYPuNODo2d+i6hzGWmLatHFJixudqC42WwqrVl4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lwHPGfWAI4tFE0AUygWMoJ2olx/+6ZF8YwefVLR7c10Tp2TFDCSsdtlWJhTD3wbOIQ4igo7BNi/+fPwq2SlIXMuRyIg69w6L+FsR5GR9gX2fZL/WP95pkXdt35KlRtkS/sUQUagfwly+mHBOAKy23joz7r3kIKYdGeizl7o5xAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bRZOfr5z; arc=none smtp.client-ip=74.125.82.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bRZOfr5z" Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-2c156c4a9efso5057012eec.1 for ; Mon, 30 Mar 2026 22:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774936187; x=1775540987; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=G6ZalXvRcEM7eynFKSA3Ox/Wlzblw8FW9y63x9o9NVw=; b=bRZOfr5zAIt3Ya7vBvT+HufIw5Afyn4RGp4f1HMs3VlNN1qhlEXre7q6iyxMT/7ucZ l68H/kkFBBqLmCmIUVUkN8Ebw6NcwVVt5++aaoXw8VDhwvjrmXFn8tVBAG8WlszUOnh4 F/YtNDxlL4DSp5UIn8us9AG2W02NZ4kSWGGE4VIuZDwMcfuQ2GRZNEe9oupLFo57hvnT YNsz+HrIhKATnCdRHHASByGmfg82rwgXIovf+db7/sa2ny0/wLpgdeSf0BXABKbizrw0 vFbT07sOab+UyUAtYMqFZFJhmJIydFMWMvmbb8cgPFHKjPfKcBxBj9porHH/V+JHevgn EPOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774936187; x=1775540987; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G6ZalXvRcEM7eynFKSA3Ox/Wlzblw8FW9y63x9o9NVw=; b=RGedit5x/6S0UYB4Tnpy8X18jPQk1dvK/mpvMbItSH3UmLfvH43CCWdPFO/fp17So4 Vn7/pe1tJ8GFVjRtxrBNQxRiCGReAyPPgUGaEZ5/Fh6U4MXVOI+yZON8q4pJ6aAv+SdV fGsWpIhYf3ap+EatNGXzKJBU8IoDfFqhnRAAr5C33iechBm96lyn/Ue6OGqHfIDTwmYg EwCzdcg7HVIbVoVthXLisCT7FbP5ohxNRANDmnSe+7PIjPIafsD8/8Z2pswS0FwJwJEX D/3LDWd04ijS8Dein0+EYBb28c7N+JM89HT7lbuKuWs98OGm8kQ1s6euEcXQyogVGbb0 ha5w== X-Gm-Message-State: AOJu0YwdQmn0c1rOlkaWt8NXytwTcFOfSusy3eSFX30LXvJJ0gfBe9ah MGfglv91s1WsQgDwvmPTCPVR1QpP/243yEBSatg0OhxDjvmvM2sercRh X-Gm-Gg: ATEYQzxZFK0CoQTSXflvQkpipSdOsAiHBJr87LB2o8hr7oOeaOniSUGuS/ECCTcM1Sy YIJcTopr0i3S8cv5wrCEboCP/0AGUGQqC/Yk5kTI7G5NMEB2uiKR8KqKczXt3Yd/YeMEifl3gyL Cuas7QN5c1joUst+72Eqk4NmL8ifW8lhPmIV66CZrcjiPaRU2Shf/xn9T5s9aLHCQZqEo8CYzOT U/XakbZI0s+wCe3h9J5PF8eFx4G32dnvFyES8vSTxoxYqmdz01OT552XCktnxO3TxCBzFFd4asW vCrzNkIhUDIT8nWMsGlqsfXp07AV41HR8jWx/UROt/AglC4BWoa42ePI5KX+MiRW71WNJy8zSCR qtFsGf+pDqz2nPYQzuUPWH2E1nbMp4BxSO85JTEY2Mq8JseEmcnxFJ5PnTBTufRYvfRSrnREJlp 6UMorK3NsxXzYxsb06N/vRVdtMoTvohVWuzHi8fEQWPDq/Y++gxYPbtTuPvCqGAV8Q X-Received: by 2002:a05:7300:e60b:b0:2c1:85a:d25d with SMTP id 5a478bee46e88-2c185d74157mr8785111eec.1.1774936187043; Mon, 30 Mar 2026 22:49:47 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:7f4e:2749:b37a:e9d5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c3c3bda13csm9275122eec.6.2026.03.30.22.49.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 22:49:46 -0700 (PDT) Date: Mon, 30 Mar 2026 22:49:42 -0700 From: Dmitry Torokhov To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Hans de Goede , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, stable@vger.kernel.org Subject: Re: [PATCH v2 1/4] x86/geode: fix on-stack property data usage Message-ID: References: <20260329-property-gpio-fix-v2-0-3cca5ba136d8@gmail.com> <20260329-property-gpio-fix-v2-1-3cca5ba136d8@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260329-property-gpio-fix-v2-1-3cca5ba136d8@gmail.com> On Sun, Mar 29, 2026 at 07:27:48PM -0700, Dmitry Torokhov wrote: > The PROPERTY_ENTRY_GPIO macro (and by extension PROPERTY_ENTRY_REF) > creates a temporary software_node_ref_args structure on the stack > when used in a runtime assignment. This results in the property > pointing to data that is invalid once the function returns. > > Fix this by ensuring the GPIO reference data is not stored on stack and > using PROPERTY_ENTRY_REF_ARRAY_LEN() to point directly to the persistent > reference data. > > Fixes: 298c9babadb8 ("x86/platform/geode: switch GPIO buttons and LEDs to software properties") > Cc: stable@vger.kernel.org > Signed-off-by: Dmitry Torokhov While we are discussing with Andy patches 2-4 maybe this one can be picked up? It does fix (I hope)(I hope) a real issue in the field. Thanks. -- Dmitry