From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48410371894 for ; Tue, 31 Mar 2026 06:03:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774937008; cv=none; b=k772caBGlduR/roDMLDZMFOubckkGDqdURyD5ChxhXhbKVDO9ftSgVvq2hWMGHVaC0D/MID6NDn/7y3CffjYQ8fbDCNWhu8gFX9QAr/NhqbgQlISAOgP1t0OAZ9V1SQIe7YH9xt9eHrXruMQxf8pi/81m6EFCvkn5ILT0upepvs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774937008; c=relaxed/simple; bh=Hw2eRWNSq7xRJtzfw9eZamV77ZIiYuWvXdnIMcmHnZw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IMATziIb+tM5FI0IPC8ZP3yBHsLjSyonG4mluhltOcQmQ+d31Ol5iFSCzcNyS2F9fLQR4fZmjSg6QxRCAqqiZ6Bajpx2uUDp/BE6ko4g9bElBto7huQfK7DNe0NgTKO+uJL7c8p4y1uocacq6lZmXJxpWhyi6fMeuc/hMwmfHPk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=snts4bJV; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="snts4bJV" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-43cf7683a28so1169178f8f.2 for ; Mon, 30 Mar 2026 23:03:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774937004; x=1775541804; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Hw2eRWNSq7xRJtzfw9eZamV77ZIiYuWvXdnIMcmHnZw=; b=snts4bJVteUwyLcotZN8JGfE4yhVEh9rA9o5Zgx2HFHJhpl6oKUVoZDOJqlWr3dBEj yfwYu+lRLGvmtjDY1WLTvl+l8zw2cvNRcJnW9LN5W9hBBdJZQKPTQrQgsdovw52J1RmF vA4P9JKmRf8jdvEHMS31w1yVdaRLcdFdd7j6ecRI1eYq82rJMN4ykZ//Wx2wdmC+b1U2 H7LJVw9XEs2RUCF0wOOSOiGYyve0r3y58lCtqv0nyASreeDbUARyLtEeGEqG63JQA6u8 npeaVNkeqtN4NAcqhI6/M7BkkseaQpontZhDuJLeQ9GasdHAVOSvPwN10qK0/hXlvCpA RjFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774937004; x=1775541804; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Hw2eRWNSq7xRJtzfw9eZamV77ZIiYuWvXdnIMcmHnZw=; b=P/xZ7TWG/hLeV93KpJCKJAAf/Uw0gHyw066iF9VnwDSKNgtzid91Id31jbeqfztl4F +a9pYna94pPJCm7AYX6O6BGj9+BBQnjKB8LNaNqKy+sItSgQXkghHHoHw6QCwMh7WJb6 KWfBC4efCi9nOnOyL8ucvgb8AMLri07ZAaE+saMHJnmOt7Pkmk+9W8uhyM2GwAikiL3k ycqwAi2wwjQvETSlla+aooxYUZqaoDFNlAPK8jAzFp3krjbJP5hIrElh2CPpovGvtstR WmB1OjL3Sz/1Uk/UGawi18S07acg0nHI+3L/AiB2d71XmFhpdw6MsXdxqdd9R7ZO1tgC G5Rg== X-Forwarded-Encrypted: i=1; AJvYcCVsii/wTIFL0NUMNLo6xCkWMFN/Wbm73ogzvzs50PU3qhLKAsMjPxrEWs2M5SAb0v+kgP/xYkQ/2raDpsw=@vger.kernel.org X-Gm-Message-State: AOJu0YxuFDNCJlGy/1a/1mP8fgWCEhrZ2OnOqrl184lATbKAde+ndexc labMK/zRf5bihb2XYEJUqKnkzBVOk8Fkqvur/ogpypmvFOAEu6wOjhd2 X-Gm-Gg: ATEYQzxCRJ2DLowMli+MT9kDeNV8sj0buPZMNC499vMkCkeKQgLmTeBjnIRV839A8TT F5i6BxIZOgj8Q67kaMN3zjbYSeal0OW4NsQhBY2ROZ1uCjIdoGfd1biX+vKLX7LSk3tBmkPDhdn a/De1whxSMhZqWSC5NVjg991yq5Vxo96t5FLfG2+qzHaYD2FsO5/uSqyybx1R1pXJUu4qtC6EPQ EzcZyH85n/EK3QBApbTUwgbcxU9Fyyg5OlxWyiv9eSLObYfViHg4Vxe0Yjyp9DtyCcKG/dVXPm5 A97WguodT000zBQTzBdryBXCDcrH6G9CX5ywGiyrFqbime8g5mZIgFDhKEF3fbKR16htcgVEzZ2 2aBB2Cgb6ji3zV1rhmx4c0pYfJLbcokGkP4SQHwFpjL6lHC37pDhHcbwZMmKBg0NMmJp49PtSkU P5U6+BfLThwfugm+eIaa5h4KSF1Ipjtw== X-Received: by 2002:a05:6000:24c6:b0:43b:4582:e90d with SMTP id ffacd0b85a97d-43b9e9fadfbmr26415699f8f.42.1774937004525; Mon, 30 Mar 2026 23:03:24 -0700 (PDT) Received: from gmail.com ([2a00:f41:1882:1f28:c460:96ff:fea3:6e21]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf21e2628sm27245180f8f.6.2026.03.30.23.03.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 23:03:24 -0700 (PDT) Date: Tue, 31 Mar 2026 08:03:21 +0200 From: "Jose A. Perez de Azpillaga" To: Andy Shevchenko Cc: linux-staging@lists.linux.dev, Hans de Goede , Mauro Carvalho Chehab , Sakari Ailus , Andy Shevchenko , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] media: atomisp: remove redundant call to ia_css_output0_configure() Message-ID: References: <20260328192721.255493-1-azpijr@gmail.com> <20260328192721.255493-3-azpijr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Mar 30, 2026 at 12:01:21PM +0300, Andy Shevchenko wrote: > On Sat, Mar 28, 2026 at 9:27 PM Jose A. Perez de Azpillaga > wrote: > > > > The function configure_isp_from_args() contained a duplicate call to > > ia_css_output0_configure() using the same output frame index. Remove > > the redundant call to simplify the configuration path. > > This requires more information, in particular to explain if the order > has no side effects. It might be that double configuration has side > effects and removal (wrong) one may lead to other currently hidden > issues. > mhm... my bad for that, the ia_css_output0_configure() function acts as a configuration setter. it populates a struct ia_css_output0_configuration from the frame info and caches it in the binary parameters. calling it twice with the same out_frame[0] pointer merely overwrites the exact same state with identical values. it has no cumulative state, either does its order matter relative to ia_css_copy_output_configure(). ... regards, jose a. p-a