From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 675013AA1A1 for ; Tue, 31 Mar 2026 10:55:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774954550; cv=none; b=NHhvHzHY6A4hDB69sDNManL3zRtTlepQ/mY/p8vZtYyPHgUIDuFWFu4Fdj6DTcDZtsaKGd9PmA/sFxj+htGJlUixm8vIvxhdYGWgVROc8u4h2v0lLwk+M59uAKNoi5h3jfmxCg0TG8n1ekWfV1q+cqtWCq+NNHpTVP9YnRdT/cY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774954550; c=relaxed/simple; bh=F9bgYMlUcSdEWfqlcZxhQPzu42zhWF8wvMu2b/ef3tQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Er/ITtSGzKwNZ1nCFmI2DUrQ3y2btZdDpr3zId7WO9JihJevP2QXUXFCtmu/OmOSIF2sDVn3WWiokNRx4Z/S6n8IlErjt1UB8VgSgtE2PwrEBXS9ekR7sk2FM0B8Lz1g6YH/I1o94bVYXXkFbtd1M0C6wFPkrtNhkU9paACyY8w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VqebmEKO; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VqebmEKO" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5a133b686f7so6431639e87.0 for ; Tue, 31 Mar 2026 03:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774954547; x=1775559347; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NHyYYaZtY634lUMIpsDDIFlFya4BZQiw23fUYcSR5VU=; b=VqebmEKOJC/CWuqJHfDq+CIpDgHDTFgb7fYJDbdKXWwhAiasLc/8v9P3HGXk8Haz+e 7IecbHdHekx2anlCTP9Yr+cxuGjD0oEPGau1O1DFpv/qWVyTLFpqUMu6emyzlmC8KWNd DQHE6LSS7gfE9JAGfeEbw1mYvlGR9V/JvuyoZvTP9EkJGTyflDpI3k/troa18vMr3S8T dJoEy+k83htpAD/JL//VJK+ba44UKhaFupBf4rHL52ODQnUEomxCMcmiE1AZ+ZQUAzpX 3vrgvlNDheI2tLdQ2Ivcehlrp5tB/AWHukmYIz60Yk+z61i3Eh4Nlfs+g6Jhr3VHWgOY b7IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774954547; x=1775559347; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NHyYYaZtY634lUMIpsDDIFlFya4BZQiw23fUYcSR5VU=; b=hjijWNJJnoj/ZlTLKxdNO29h8Uyl6hbbJHbmIXwiPErkqgEABMg2TITF/xgYNRvdsn JHSkNqMRwMNNvhM6BIvRHqxfmBVEqczKCOIKNzk/WaOQPYLFSqw9RgKozJexOztqGueZ mpaYJ9ugVxhTrjeIauc5AHQwmpI1RAuDhj8dIgiKMM5exRUh1HNJI3uGG7gV6T1ZSDlO uc1pVx1zt9Z7rdI41CSUgau+tBnKcyfwvUeV3DNSBTFKO3Rka39Zknv2nQD0RpwRVRju ZHnODCDEJorRo0jKLM6RJ8RszxVbfk2xfCqiBL6HLkIZgjqBRNaOEJDs6U4bz++4nUGh Vdxw== X-Forwarded-Encrypted: i=1; AJvYcCUe/hW9LHnHEFZEKmuE7dLkxd8xcIY5spB4AZbA4BDi+rXUVSWKi334GMrTa/A2E296oaKhyfeEwylh5u8=@vger.kernel.org X-Gm-Message-State: AOJu0YyicYvGdLzwWBsnFxAY+KXlDoko1/9tSumDL5Xf8pa5wBYk9YgF qtDfozjToifNxevvh6a9YGGU0I/jWNFnvgh4XdF1bYQk7f46Egpbh7hCG//f+bk+ X-Gm-Gg: ATEYQzx7I2VxF6iLF9E5TTrSOvU9WrGYxDGvp/wnlRkTGeAR9teCZ6r09bDN+ryatl4 haDQgv2Ht04opEPF7ltslrgaWtC1oD0CuqLEyCEKD53LA+Tl2+BLzZ1U08PMfl1NR8BockOOtHp uvnTioZkFx0YDHaLZADKjxHRs+MoUTbzrB/SBkk2asF0ntD6WXTmINjNqvODWOqeqizYmT2IRsA zRVfoD0O9ZIsEFhANIWAvlg9XMp00H4LqOcPU7++9ovtQUz3PMpmfYTstOIGav62pFWpe51ZoMi WWFEmLpvXOYUoVmwxy+agjiHgy2KGbTFclcIH1jRBMLJNsoElevCr8kniASdYpg1DWSCZyY98du qPQY9p4CXFANKV5eh5N2BAQlR4AiHGCXW2ZMUmu3ReO/8koPmGtmU27hSZNNiIjk2TwlRgIiL4p lCwzrRue0B69TSnu9O9T0= X-Received: by 2002:a05:6512:2308:b0:5a2:7d84:6a44 with SMTP id 2adb3069b0e04-5a2ab5fa471mr5245936e87.6.1774954547081; Tue, 31 Mar 2026 03:55:47 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a2b1443f46sm2421490e87.43.2026.03.31.03.55.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 03:55:46 -0700 (PDT) Date: Tue, 31 Mar 2026 13:55:43 +0300 From: Dan Carpenter To: grondon@gmail.com Cc: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/5] staging: most: dim2: replace BUG_ON() in service_done_flag() Message-ID: References: <20260330182255.75241-1-grondon@gmail.com> <20260330182255.75241-3-grondon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260330182255.75241-3-grondon@gmail.com> On Mon, Mar 30, 2026 at 07:22:52PM +0100, grondon@gmail.com wrote: > From: Gabriel Rondon > > Replace BUG_ON() calls with an early return since the function returns > void. > > BUG_ON() is deprecated as it crashes the entire kernel on assertion > failure (see Documentation/process/deprecated.rst). > > Signed-off-by: Gabriel Rondon > --- > drivers/staging/most/dim2/dim2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c > index 48315f8cd..b820c3647 100644 > --- a/drivers/staging/most/dim2/dim2.c > +++ b/drivers/staging/most/dim2/dim2.c > @@ -271,8 +271,8 @@ static void service_done_flag(struct dim2_hdm *dev, int ch_idx) > unsigned long flags; > u8 *data; > > - BUG_ON(!hdm_ch); > - BUG_ON(!hdm_ch->is_initialized); > + if (!hdm_ch || !hdm_ch->is_initialized) hdm_ch can't be NULL. It's a pointer to the middle of a struct plus an offset. regards, dan carpenter > + return; > > spin_lock_irqsave(&dim_lock, flags); > > -- > 2.33.0 >