From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F9BB3E0C64 for ; Tue, 31 Mar 2026 14:16:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774966611; cv=none; b=oYEJm4lS4TeajEZJv8Ok1KYsuLUJ4YPSpHGeJwP2JkPOFpGANSc7GBaYcBxEZDPHxJXK2bXkDgB6O803822W0zzlY9LO2zHtu2EcgA2jt0Pyd/jY9hy+U6KfeL8ENVueJBZ5JzgoWKL9bvRTvG5VS4mz0iDM7fm4fLu54YI2heA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774966611; c=relaxed/simple; bh=5Iw9URBB2+huCGNNmJnyie/vcU11kN7G+C2oBsp0qj8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EWWCJ71AW81BZelLeGx6I3/OADLqtMeqTF1CmhkXVMCxdaiS0iylFrNMU1XfyZW06gBGA2VtZwQ640+JKqthMcLJdvK/1DXay+mINCOppOZruxQwO0SfbsdnWXZknBRbi4qRN885PF7zta+F9I9DvS4z27MYP471/UlUGKUQodg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IOh0G8x7; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=B+lFHiwA; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IOh0G8x7"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="B+lFHiwA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774966609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+cvItjsGlgO+YKuRpumctJ3y5xeOoIq89E46KdlSIjg=; b=IOh0G8x7Jb3pamMC08Q0FMf15bzzEab+J5nT3q/ySXOiWm35iOWyzffd6NmexMyBpe4YOV lXs6imvCZBzlmrOSOLrVejOdVGsD4Ig5wjA3AB0Uy9HEo/u9yppL4obawD2D/+3G0ECgay uCTBvGOX91c4I8ClQGJAzOJpRbhu8UU= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-377-C2BlBubPO12-FZW_J8abFA-1; Tue, 31 Mar 2026 10:16:45 -0400 X-MC-Unique: C2BlBubPO12-FZW_J8abFA-1 X-Mimecast-MFC-AGG-ID: C2BlBubPO12-FZW_J8abFA_1774966604 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50b2cbe7223so188076791cf.2 for ; Tue, 31 Mar 2026 07:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774966604; x=1775571404; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=+cvItjsGlgO+YKuRpumctJ3y5xeOoIq89E46KdlSIjg=; b=B+lFHiwAOxGHT67wAKheWt/RTxx/O0LwK53PsBQuKG4xl/loLQNWQltBPGY+jnX/C1 UrvJGJ16BW3ZEF26X9ccZVWOBut15K+qh5cQu+23o9OxyYZ4TmhaicEUA3Z5a9OXvHZT uQllq07OgNuwF62joCKEFBKqfqavQ0NeOSL51wBWSsza4JQWJkF6iBitJOjpSkaaFtLQ MSL8argPQWqhkG+9vU4OMSDvGCxOg/BTe2X/xZZ8j9+8o9OxpGk0QkiU1Exed8JDJoOZ BJxFmh3X7qDqz6+Qi9uI3WIqq5GztjiaOfL4Hb2wb52lm3PdPWPUTHrrsktP6TSklizf D0Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774966604; x=1775571404; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+cvItjsGlgO+YKuRpumctJ3y5xeOoIq89E46KdlSIjg=; b=m+V+1bQdM45UFvZfeU4EqPoL3tO9nHyGlyiV7e6uDLf6W+TTqA71bjp6EnScANqJ+u v0gLZdpWBpLvTvVV9P1sExXzfGzN2pQHa+i0acvTQjU+yd5C3UX03+MzgTtXooskfGEJ rBcUdR5aRdXWcPcyRSdCxn2u7ZfB7kgmA+NN8WIpV9y2H5VN3r0wJQACa/Lw8SFAlMcF NGarQ4dQMgeR7PEaycUqbD4PGrGNn8uMcA4Ccr75lS9Evi3tW4zkJ3LP0Eq7jkYMUFu1 ngsYYwJsqlU+CsIkCYek6IrVUCIU4V1grE1xJVoS9GkbNMKsMwW8AvAVMZG07YNLWVyz GCXw== X-Forwarded-Encrypted: i=1; AJvYcCXiKU6S0giKP3c423jxFtrPwbWHELygI+a34yyAZE5V/qhUseeet5V4CJ98qf5y/7XAcii/nHs6iXyg9zM=@vger.kernel.org X-Gm-Message-State: AOJu0YzqlJ6na7HvyVUo9ov6E/ywXlDlVCbIvrnrwLdgF0nntZWP0tgU WXM0mik9wy+8Hir66ltZD3rXUSY/IhaewoigSI43VqJUuAv/zszrhcFw7yjqsRTnil4BSb/0j0w D3youIhEqNPIqej228tY6tDSkFLnt4Ce3MZ65k+h1HhEcj06TNA5ZUj54Gm3bBF0alQ== X-Gm-Gg: ATEYQzynqaANDhX9PhL5Xa8IPz7yRMeMmXxt+Q2v/Ls9djgIISNjX3y19Cq27UDyLSd PuANu71DGtiNBP5HmT1arHJFwaT0UCrvhxjorHy23iD1HWZHvGdLRW4tRQ+AdrSrGJKZRxcHT31 gH0yGSuRY7IQe8O0+6XRfMNIx38lDG6zAzNCh0b6oAj9M/tuq8G5MfMXfyBsgrhMeOC7/MKeRFq UA3kxCfzu+sUKktBl+FUtuOYpiAFsJQ0ZraMkeqc2mvuA2g6pm5xL4iTiC4oS2TzIsmgkj30+0W GSAy1KSFQnZGTLVfc3jbOqWwGqd9Zj3rNWvh6QthAMJHZ9bufogk/X3KL67pi73RkEkaOCtNxh9 J2Ux+qhY2hOxxx8FT X-Received: by 2002:a05:622a:5e16:b0:50b:51a0:f744 with SMTP id d75a77b69052e-50ba3816a05mr227957561cf.17.1774966604487; Tue, 31 Mar 2026 07:16:44 -0700 (PDT) X-Received: by 2002:a05:622a:5e16:b0:50b:51a0:f744 with SMTP id d75a77b69052e-50ba3816a05mr227957191cf.17.1774966603971; Tue, 31 Mar 2026 07:16:43 -0700 (PDT) Received: from redhat.com ([96.66.166.93]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50bb2c67fefsm86643111cf.4.2026.03.31.07.16.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 07:16:43 -0700 (PDT) Date: Tue, 31 Mar 2026 10:16:41 -0400 From: Brian Masney To: Troy Mitchell Cc: Vinod Koul , Frank Li , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Guodong Xu , Michael Turquette , Stephen Boyd , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v3 4/5] clk: spacemit: k3: mark top_dclk as CLK_IS_CRITICAL Message-ID: References: <20260331-k3-pdma-v3-0-a4e60dd8b4b3@linux.spacemit.com> <20260331-k3-pdma-v3-4-a4e60dd8b4b3@linux.spacemit.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260331-k3-pdma-v3-4-a4e60dd8b4b3@linux.spacemit.com> User-Agent: Mutt/2.3.0 (2026-01-25) On Tue, Mar 31, 2026 at 04:27:07PM +0800, Troy Mitchell wrote: > top_dclk is the DDR bus clock. If it is gated by clk_disable_unused, > all memory-mapped bus transactions cease to function, causing DMA > engines to hang and general system instability. > > Mark it CLK_IS_CRITICAL so the CCF never gates it during the > unused clock sweep. > > Fixes: e371a77255b8 ("clk: spacemit: k3: add the clock tree") > Signed-off-by: Troy Mitchell Reviewed-by: Brian Masney