[PATCH 0/4] kbuild: vdso_install: drop build ID architecture allow-list

[PATCH 0/4] kbuild: vdso_install: drop build ID architecture allow-list

[Thomas Weißschuh]

This list is incomplete. Instead of maintaining it manually,
detect a vDSO with build ID automatically and handle it.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Thomas Weißschuh (4):
      kbuild: vdso_install: split out the readelf invocation
      kbuild: vdso_install: hide readelf warnings
      kbuild: vdso_install: gracefully handle images without build ID
      kbuild: vdso_install: drop build ID architecture allow-list

 scripts/Makefile.vdsoinst | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
---
base-commit: 5acf9666477e24e026c54ded89e69cff6596ced8
change-id: 20260318-kbuild-vdso-install-44a55817ef7f

Best regards,
-- 
Thomas Weißschuh <linux@weissschuh.net>

[PATCH 1/4] kbuild: vdso_install: split out the readelf invocation

[Thomas Weißschuh]

Some upcoming changes to the readelf invocation would create a
very long line otherwise.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 scripts/Makefile.vdsoinst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/Makefile.vdsoinst b/scripts/Makefile.vdsoinst
index ac85f9a4a569..214c561651cf 100644
--- a/scripts/Makefile.vdsoinst
+++ b/scripts/Makefile.vdsoinst
@@ -21,7 +21,8 @@ $$(dest): $(1) FORCE
 
 # Some architectures create .build-id symlinks
 ifneq ($(filter arm s390 sparc x86, $(SRCARCH)),)
-link := $(install-dir)/.build-id/$$(shell $(READELF) -n $(1) | sed -n 's@^.*Build ID: \(..\)\(.*\)@\1/\2@p').debug
+build-id-file := $$(shell $(READELF) -n $(1) | sed -n 's@^.*Build ID: \(..\)\(.*\)@\1/\2@p')
+link := $(install-dir)/.build-id/$$(build-id-file).debug
 
 __default: $$(link)
 $$(link): $$(dest) FORCE

-- 
2.53.0

Re: [PATCH 1/4] kbuild: vdso_install: split out the readelf invocation

[Nicolas Schier]

On Fri, 20 Mar 2026 17:36:53 +0100, Thomas Weißschuh <linux@weissschuh.net> wrote:
> Some upcoming changes to the readelf invocation would create a
> very long line otherwise.

(I get confused frequently if commit description is not self-contained
but only completing the subject.)

Reviewed-by: Nicolas Schier <nsc@kernel.org>

-- 
Nicolas

[PATCH 2/4] kbuild: vdso_install: hide readelf warnings

[Thomas Weißschuh]

If 'readelf -n' encounters a note it does not recognize it emits a
warning. This for example happen when inspecting a compat vDSO for
which the main kernel toolchain was not used.
However the relevant build ID note is always readable, so the
warnings are pointless.

Hide the warnings to make it possible to extrace build IDs for more
architectures in the future.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 scripts/Makefile.vdsoinst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/Makefile.vdsoinst b/scripts/Makefile.vdsoinst
index 214c561651cf..aed153b3120b 100644
--- a/scripts/Makefile.vdsoinst
+++ b/scripts/Makefile.vdsoinst
@@ -21,7 +21,7 @@ $$(dest): $(1) FORCE
 
 # Some architectures create .build-id symlinks
 ifneq ($(filter arm s390 sparc x86, $(SRCARCH)),)
-build-id-file := $$(shell $(READELF) -n $(1) | sed -n 's@^.*Build ID: \(..\)\(.*\)@\1/\2@p')
+build-id-file := $$(shell $(READELF) -n $(1) 2>/dev/null | sed -n 's@^.*Build ID: \(..\)\(.*\)@\1/\2@p')
 link := $(install-dir)/.build-id/$$(build-id-file).debug
 
 __default: $$(link)

-- 
2.53.0

Re: [PATCH 2/4] kbuild: vdso_install: hide readelf warnings

[Nicolas Schier]

On Fri, 20 Mar 2026 17:36:54 +0100, Thomas Weißschuh <linux@weissschuh.net> wrote:
> If 'readelf -n' encounters a note it does not recognize it emits a

,

> warning. This for example happen when inspecting a compat vDSO for

happen -> happens

> which the main kernel toolchain was not used.
> However the relevant build ID note is always readable, so the
> warnings are pointless.
> 
> Hide the warnings to make it possible to extrace build IDs for more

extrace -> extract

>
>
> diff --git a/scripts/Makefile.vdsoinst b/scripts/Makefile.vdsoinst
> index 214c561651cf..aed153b3120b 100644
> --- a/scripts/Makefile.vdsoinst
> +++ b/scripts/Makefile.vdsoinst
> @@ -21,7 +21,7 @@ $$(dest): $(1) FORCE
>  
>  # Some architectures create .build-id symlinks
>  ifneq ($(filter arm s390 sparc x86, $(SRCARCH)),)
> -build-id-file := $$(shell $(READELF) -n $(1) | sed -n 's@^.*Build ID: \(..\)\(.*\)@\1/\2@p')
> +build-id-file := $$(shell $(READELF) -n $(1) 2>/dev/null | sed -n 's@^.*Build ID: \(..\)\(.*\)@\1/\2@p')
>  link := $(install-dir)/.build-id/$$(build-id-file).debug
>  
>  __default: $$(link)

Sound reasonable and the diff looks appropriate.  Thanks!

Reviewed-by: Nicolas Schier <nsc@kernel.org>

-- 
Nicolas

[PATCH 3/4] kbuild: vdso_install: gracefully handle images without build ID

[Thomas Weißschuh]

If the vDSO does not contains a build ID, skip the symlink step.
This will allow the removal of the explicit list of architectures.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 scripts/Makefile.vdsoinst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/Makefile.vdsoinst b/scripts/Makefile.vdsoinst
index aed153b3120b..3de70218b8d4 100644
--- a/scripts/Makefile.vdsoinst
+++ b/scripts/Makefile.vdsoinst
@@ -22,12 +22,15 @@ $$(dest): $(1) FORCE
 # Some architectures create .build-id symlinks
 ifneq ($(filter arm s390 sparc x86, $(SRCARCH)),)
 build-id-file := $$(shell $(READELF) -n $(1) 2>/dev/null | sed -n 's@^.*Build ID: \(..\)\(.*\)@\1/\2@p')
+
+ifneq ($$(build-id-file),)
 link := $(install-dir)/.build-id/$$(build-id-file).debug
 
 __default: $$(link)
 $$(link): $$(dest) FORCE
 	$$(call cmd,symlink)
 endif
+endif
 
 endef
 

-- 
2.53.0

Re: [PATCH 3/4] kbuild: vdso_install: gracefully handle images without build ID

[Nicolas Schier]

On Fri, 20 Mar 2026 17:36:55 +0100, Thomas Weißschuh <linux@weissschuh.net> wrote:
> If the vDSO does not contains a build ID, skip the symlink step.

s/contains/contain/

Reviewed-by: Nicolas Schier <nsc@kernel.org>

-- 
Nicolas

[PATCH 4/4] kbuild: vdso_install: drop build ID architecture allow-list

[Thomas Weißschuh]

Many architectures which do generate build IDs are missing from this
list. For example arm64, riscv, loongarch, mips.

Now that errors from readelf and binaries without any build ID are
handled gracefully, the allow-list is not necessary anymore, drop it.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 scripts/Makefile.vdsoinst | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/scripts/Makefile.vdsoinst b/scripts/Makefile.vdsoinst
index 3de70218b8d4..d9f7243217bc 100644
--- a/scripts/Makefile.vdsoinst
+++ b/scripts/Makefile.vdsoinst
@@ -19,8 +19,6 @@ __default: $$(dest)
 $$(dest): $(1) FORCE
 	$$(call cmd,install)
 
-# Some architectures create .build-id symlinks
-ifneq ($(filter arm s390 sparc x86, $(SRCARCH)),)
 build-id-file := $$(shell $(READELF) -n $(1) 2>/dev/null | sed -n 's@^.*Build ID: \(..\)\(.*\)@\1/\2@p')
 
 ifneq ($$(build-id-file),)
@@ -30,7 +28,6 @@ __default: $$(link)
 $$(link): $$(dest) FORCE
 	$$(call cmd,symlink)
 endif
-endif
 
 endef
 

-- 
2.53.0

Re: [PATCH 4/4] kbuild: vdso_install: drop build ID architecture allow-list

[Nicolas Schier]

On Fri, 20 Mar 2026 17:36:56 +0100, Thomas Weißschuh <linux@weissschuh.net> wrote:
> Many architectures which do generate build IDs are missing from this
> list. For example arm64, riscv, loongarch, mips.
> 
> Now that errors from readelf and binaries without any build ID are
> handled gracefully, the allow-list is not necessary anymore, drop it.
> 
> 
> [...]

Reviewed-by: Nicolas Schier <nsc@kernel.org>

-- 
Nicolas

Re: [PATCH 0/4] kbuild: vdso_install: drop build ID architecture allow-list

[Nicolas Schier]

On Fri, 20 Mar 2026 17:36:52 +0100, Thomas Weißschuh wrote:
> This list is incomplete. Instead of maintaining it manually,
> detect a vDSO with build ID automatically and handle it.

Applied to kbuild/linux.git (kbuild-next-unstable), thanks!

[1/4] kbuild: vdso_install: split out the readelf invocation
      https://git.kernel.org/kbuild/c/9780cef0
[2/4] kbuild: vdso_install: hide readelf warnings
      https://git.kernel.org/kbuild/c/6ba86c59
[3/4] kbuild: vdso_install: gracefully handle images without build ID
      https://git.kernel.org/kbuild/c/5cd6177e
[4/4] kbuild: vdso_install: drop build ID architecture allow-list
      https://git.kernel.org/kbuild/c/80b1f3e6

Please look out for regression or issue reports or other follow up
comments, as they may result in the patch/series getting dropped,
reverted or modified (e.g. trailers). Patches applied to the
kbuild-next-unstable branch are accepted pending wider testing in
linux-next and any post-commit review; they will generally be moved
to the kbuild-next branch in about a week if no issues are found.

Best regards,
-- 
Nicolas

Re: [PATCH 0/4] kbuild: vdso_install: drop build ID architecture allow-list

[Nicolas Schier]

On Tue, Mar 31, 2026 at 06:09:39PM +0200, Nicolas Schier wrote:
> On Fri, 20 Mar 2026 17:36:52 +0100, Thomas Weißschuh wrote:
> > This list is incomplete. Instead of maintaining it manually,
> > detect a vDSO with build ID automatically and handle it.
> 
> Applied to kbuild/linux.git (kbuild-next-unstable), thanks!
> 
> [1/4] kbuild: vdso_install: split out the readelf invocation
>       https://git.kernel.org/kbuild/c/9780cef0
> [2/4] kbuild: vdso_install: hide readelf warnings
>       https://git.kernel.org/kbuild/c/6ba86c59
> [3/4] kbuild: vdso_install: gracefully handle images without build ID
>       https://git.kernel.org/kbuild/c/5cd6177e
> [4/4] kbuild: vdso_install: drop build ID architecture allow-list
>       https://git.kernel.org/kbuild/c/80b1f3e6
> 
> Please look out for regression or issue reports or other follow up
> comments, as they may result in the patch/series getting dropped,
> reverted or modified (e.g. trailers). Patches applied to the
> kbuild-next-unstable branch are accepted pending wider testing in
> linux-next and any post-commit review; they will generally be moved
> to the kbuild-next branch in about a week if no issues are found.
> 
> Best regards,
> -- 
> Nicolas
> 

I didn't want to merge that already; please ignore.  Sorry for the
noise.

-- 
Nicolas