public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Uladzislau Rezki <urezki@gmail.com>
To: shivamkalra98@zohomail.in
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Uladzislau Rezki <urezki@gmail.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Alice Ryhl <aliceryhl@google.com>,
	Danilo Krummrich <dakr@kernel.org>
Subject: Re: [PATCH v8 6/6] lib/test_vmalloc: add vrealloc test case
Date: Tue, 31 Mar 2026 19:45:19 +0200	[thread overview]
Message-ID: <acwIL5BkeZ8IpgWx@milan> (raw)
In-Reply-To: <20260327-vmalloc-shrink-v8-6-cc6b57059ed7@zohomail.in>

On Fri, Mar 27, 2026 at 03:18:42PM +0530, Shivam Kalra via B4 Relay wrote:
> From: Shivam Kalra <shivamkalra98@zohomail.in>
> 
> Introduce a new test case "vrealloc_test" that exercises the vrealloc()
> shrink and in-place grow paths:
> 
>   - Grow beyond allocated pages (triggers full reallocation).
>   - Shrink crossing a page boundary (frees tail pages).
>   - Shrink within the same page (no page freeing).
>   - Grow within the already allocated page count (in-place).
> 
> Data integrity is validated after each realloc step by checking that
> the first byte of the original allocation is preserved.
> 
> The test is gated behind run_test_mask bit 12 (id 4096).
> 
> Signed-off-by: Shivam Kalra <shivamkalra98@zohomail.in>
> ---
>  lib/test_vmalloc.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 62 insertions(+)
> 
> diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c
> index 876c72c18a0c..b23f85e8f8ca 100644
> --- a/lib/test_vmalloc.c
> +++ b/lib/test_vmalloc.c
> @@ -55,6 +55,7 @@ __param(int, run_test_mask, 7,
>  		"\t\tid: 512,  name: kvfree_rcu_2_arg_vmalloc_test\n"
>  		"\t\tid: 1024, name: vm_map_ram_test\n"
>  		"\t\tid: 2048, name: no_block_alloc_test\n"
> +		"\t\tid: 4096, name: vrealloc_test\n"
>  		/* Add a new test case description here. */
>  );
>  
> @@ -421,6 +422,66 @@ vm_map_ram_test(void)
>  	return nr_allocated != map_nr_pages;
>  }
>  
> +static int vrealloc_test(void)
> +{
> +	void *ptr, *tmp;
> +	int i;
> +
> +	for (i = 0; i < test_loop_count; i++) {
> +		int err = -1;
> +
> +		ptr = vrealloc(NULL, PAGE_SIZE, GFP_KERNEL);
> +		if (!ptr)
> +			return -1;
> +
> +		*((__u8 *)ptr) = 'a';
> +
> +		/* Grow: beyond allocated pages, triggers full realloc. */
> +		tmp = vrealloc(ptr, 4 * PAGE_SIZE, GFP_KERNEL);
> +		if (!tmp)
> +			goto error;
> +		ptr = tmp;
> +
> +		if (*((__u8 *)ptr) != 'a')
> +			goto error;
> +
> +		/* Shrink: crosses page boundary, frees tail pages. */
> +		tmp = vrealloc(ptr, PAGE_SIZE, GFP_KERNEL);
> +		if (!tmp)
> +			goto error;
> +		ptr = tmp;
> +
> +		if (*((__u8 *)ptr) != 'a')
> +			goto error;
> +
> +		/* Shrink: within same page, no page freeing. */
> +		tmp = vrealloc(ptr, PAGE_SIZE / 2, GFP_KERNEL);
> +		if (!tmp)
> +			goto error;
> +		ptr = tmp;
> +
> +		if (*((__u8 *)ptr) != 'a')
> +			goto error;
> +
> +		/* Grow: within allocated page, in-place, no realloc. */
> +		tmp = vrealloc(ptr, PAGE_SIZE, GFP_KERNEL);
> +		if (!tmp)
> +			goto error;
> +		ptr = tmp;
> +
> +		if (*((__u8 *)ptr) != 'a')
> +			goto error;
> +
> +		err = 0;
> +error:
> +		vfree(ptr);
> +		if (err)
> +			return err;
> +	}
> +
> +	return 0;
> +}
> +
>  struct test_case_desc {
>  	const char *test_name;
>  	int (*test_func)(void);
> @@ -440,6 +501,7 @@ static struct test_case_desc test_case_array[] = {
>  	{ "kvfree_rcu_2_arg_vmalloc_test", kvfree_rcu_2_arg_vmalloc_test, },
>  	{ "vm_map_ram_test", vm_map_ram_test, },
>  	{ "no_block_alloc_test", no_block_alloc_test, true },
> +	{ "vrealloc_test", vrealloc_test, },
>  	/* Add a new test case here. */
>  };
>  
> 
> -- 
> 2.43.0
> 
> 
Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>

--
Uladzislau Rezki

  reply	other threads:[~2026-03-31 17:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-27  9:48 [PATCH v8 0/6] mm/vmalloc: free unused pages on vrealloc() shrink Shivam Kalra via B4 Relay
2026-03-27  9:48 ` [PATCH v8 1/6] mm/vmalloc: extract vm_area_free_pages() helper from vfree() Shivam Kalra via B4 Relay
2026-03-31 17:44   ` Uladzislau Rezki
2026-03-27  9:48 ` [PATCH v8 2/6] mm/vmalloc: fix vrealloc() grow-in-place check Shivam Kalra via B4 Relay
2026-03-27  9:48 ` [PATCH v8 3/6] mm/vmalloc: zero newly exposed memory on vrealloc() grow Shivam Kalra via B4 Relay
2026-03-27  9:48 ` [PATCH v8 4/6] mm/vmalloc: use READ_ONCE() for vmalloc nr_pages status readers Shivam Kalra via B4 Relay
2026-03-31 17:43   ` Uladzislau Rezki
2026-03-27  9:48 ` [PATCH v8 5/6] mm/vmalloc: free unused pages on vrealloc() shrink Shivam Kalra via B4 Relay
2026-03-27  9:48 ` [PATCH v8 6/6] lib/test_vmalloc: add vrealloc test case Shivam Kalra via B4 Relay
2026-03-31 17:45   ` Uladzislau Rezki [this message]
2026-03-27 18:37 ` [PATCH v8 0/6] mm/vmalloc: free unused pages on vrealloc() shrink Andrew Morton
2026-03-27 19:31   ` Danilo Krummrich
2026-03-30  8:05   ` Alice Ryhl
2026-03-30 12:27     ` Uladzislau Rezki
2026-03-31 17:15       ` Shivam Kalra
2026-03-31 17:50         ` Uladzislau Rezki
2026-03-31 19:23           ` Shivam Kalra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acwIL5BkeZ8IpgWx@milan \
    --to=urezki@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=aliceryhl@google.com \
    --cc=dakr@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shivamkalra98@zohomail.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox