From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EDDA3A0E84 for ; Tue, 31 Mar 2026 19:40:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774986007; cv=none; b=heDK8WlVRGOfDLxv5hqScGLudIFC51SwA2vGwiBfSSYUMhJw/HLEQ9/dENhlPqNuz7Yw3+TwyHporyFjsvY6FAe/gMMqTMozD4/wRfVtRQDIlLFokOZsUreODyKv+VdWwNUl0Mazha1+oo7MiOmg/JnRcYdtOGraPFIkm7cdqwQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774986007; c=relaxed/simple; bh=iQ2YYgdfhInoExshAxj84drfFa9zOehQ1IoOyF24GAc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PmuJlPYkuUvWxecxwse4L5rz5IaNN6bepMsjx2yaCfniLOjaUShFdMBEnWLd0fJWvPSpSAx4eAq18vR9UkQlEpFN3jwokIVz7m/GgE9BTjx+ep/aiZIAIvkbMZjd+VfiwVd9Skk0MoHtwtLwuBuVfw9RyIXme396GPwsQUUXzns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fB7p9kg/; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fB7p9kg/" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4888244e9f9so4253225e9.0 for ; Tue, 31 Mar 2026 12:40:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774986005; x=1775590805; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/Jc/eyAMJuaSt5fDb/LxuewpxfIwRH0DpO/1NNUx9xk=; b=fB7p9kg/d07IwWiPiRsygoUxdMJ+hFKn7UqauIAYrFwiTEo2cxvF63cHWEBzfTx/Kn hE+FMoXpJ1bPSQOQcTYV+EXvGGJQVDWmZhJbQWKJbQym2oVqs3DRJDEZmHaITTJe+fbZ x68+X/+sgmyE+/3JhA42RIj3N3v1uyk7RZM6ZFw2Httqzso8TnenMFcR2oDYruYI4goN V36A6+xb3O8CNJC0n1cTp8Vdb/K2Bj/Hq+dFHpzvwqgLP59Z/V5W7YpZkumVMSFglAaR gGhOnd3deQltoCebFV5HJX6vgt3SG4HcEC7FrpfCfHO9ZXrsFni027/8EoFa2iMqaM5q NDrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774986005; x=1775590805; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Jc/eyAMJuaSt5fDb/LxuewpxfIwRH0DpO/1NNUx9xk=; b=DOXJ3i4pkWTHrnOr7tbviFBjxnCFnTq9xZmD9PZ+a+AtNoYmhuDRVuKOwcd27EVrlN mVHj3mn3kytfN1Fjds5KUCLU6WMM/zB8Gy5o50dtKT6Sz5l+ERUpAxxYdMcZgbHZ4qGg BV2n8C1x0y8c04i5NbE8sHu24ltowRAZytlt+tU6sQvPvtoHI35MT8GqmfJOigCU0RVL SUYXfXsSJ7BFHsgDBrr/RmNJ96Tdl2AQehyMt1XW9kJn7PQleMFpD2ErkI1cpFNQQUXZ xB6SyFQbqpbvnXUES3abtxya3FcrXt2hwXTz8vf8kFYsvpG5rRSBWnc224Yds/V57KL1 iOmQ== X-Forwarded-Encrypted: i=1; AJvYcCX1WEyFmUmQy1+ILfTHmNjH/yrZN+GlGZc7X3DIXrm8bWgaJgx9dFsjd2NRObP1FSgH3hw8Hdvb3kw3YFQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyIAe0jRVlAQfE7XIP6RQ/Mv6CpJzr1EGIZ+XJhH5lPrGPg85aA Sz+aZOs5cP77tY3J9vD6uGr6zzLRM/3vw2+mZaOBAlfHSCFsqsd2j9/aA0Z+Qw== X-Gm-Gg: ATEYQzxtJhBLt8V5RiRIdfBrWmjokvjJH1uHtMEVTJpBuuKJfPtlZZsOx7+anrbe998 yY2jsWcZkhhSZ4pU3yva392dAfVuCBUy0MxZKJIgt9rCr7af42KswVanv7leyyuO3Ob+7i7ZFg2 o/YqDpvKE6KPhbCkMUV2NCGg6zYI0/YWfPuQLoAVIG8o07dhhKAm3nKVacO7VkSsJozdw9fmzmP 5qWIn1gbDJcNNzEiDE4tzEp4mz5g4KD7xq/SP4MMyPdFQRq6kgpEt7DNOcymfFXu0UNosqnc35R aGjTmnD7vAsXW4N9+yJfVzaPle5nd0cfbB8HNsls9DbPOpoi9EcQL85lnuTCoFmthiKvnZBZfh1 hiIbDbZIWBg72uskEc2L15g5/cEVjbK+ayWQM2dW+6RcgAPA0/JpQ8ak7B17K8qJ8R/SHS6L2CY Cl6tXD/oNSaWXXqAAbwFM= X-Received: by 2002:a05:600c:444e:b0:485:35ee:f836 with SMTP id 5b1f17b1804b1-48883569e3dmr10276925e9.2.1774986004433; Tue, 31 Mar 2026 12:40:04 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf2471ee2sm29745701f8f.29.2026.03.31.12.40.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 12:40:03 -0700 (PDT) Date: Tue, 31 Mar 2026 22:40:00 +0300 From: Dan Carpenter To: grondon@gmail.com Cc: gregkh@linuxfoundation.org, christian.gromm@microchip.com, parthiban.veerasooran@microchip.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/5] staging: most: dim2: replace BUG_ON() in service_done_flag() Message-ID: References: <20260331164429.47314-1-grondon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260331164429.47314-1-grondon@gmail.com> On Tue, Mar 31, 2026 at 05:44:29PM +0100, grondon@gmail.com wrote: > From: Gabriel Rondon > > On Tue, 31 Mar 2026 13:55:43 +0300, Dan Carpenter wrote: > > hdm_ch can't be NULL. It's a pointer to the middle of a struct plus > > an offset. > > You're right, the NULL check is unnecessary here. Will send a fix > removing the !hdm_ch check and keeping only !hdm_ch->is_initialized. Check them all, right? Maybe the others are similar? regards, dan carpenter