From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C31A1C84A2 for ; Wed, 1 Apr 2026 00:39:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775003998; cv=none; b=BGmT2k21cdzP5VSOwfElq/hONaW+Z/Z9Wg6nDmqeKpDdpZNDdZfMkkJGcnEQhRmYfmtjb8dLAGD1glHwCX/s6fgSwtsuEEpsLDcDCTdfSv3VF21gy/V5zQ349uqSCUN4WUa/x2IxFs3su5A//uOq5uUi/KcKR+WjPsx0xDm9vp0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775003998; c=relaxed/simple; bh=wmSFvBfh4bZliCkgGsH9ns7uhrjGl8UKSk7zMYjjaMU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z03pk/iCN1kIQRi9F5S66CogUzm7MmCGJGHWreIata1AQ1gSKmTPb5nXjMr3wa989N9WkWb2rdR0WhjPsAzHZsU90hBAaxIhgo1/EROGbibOXIgwx/8jRecMfm5JAlyRpkXIT0rbP7sXT0+LzThS20EH2qU4Llt1an8bEnCwwh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ABIUXRcI; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=DsUaTbES; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ABIUXRcI"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="DsUaTbES" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775003996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZlAyR4IsTCd6Wy9tY8fsi0F7XjnqGFSW2B8UQN2ZazM=; b=ABIUXRcIP0eug69cFyFHCMKfDAXPIpPehV9a8/WEefIm+mNPzjkPNVU+SVtJ9/E5iZ7JDT qVLToeM5cTGyH/rXgCipG3k5DDlfh0dhU1IlCEMZXg5UT8dNNZwKEdpP3mk7OEN185Ybdo s91z/yJIuMlTg8CrDWqOwWCKj4uKYlQ= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-121-shk2mKqcOWSDHpjxNq3_DQ-1; Tue, 31 Mar 2026 20:39:54 -0400 X-MC-Unique: shk2mKqcOWSDHpjxNq3_DQ-1 X-Mimecast-MFC-AGG-ID: shk2mKqcOWSDHpjxNq3_DQ_1775003993 Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c7385a1476aso3997845a12.2 for ; Tue, 31 Mar 2026 17:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775003992; x=1775608792; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZlAyR4IsTCd6Wy9tY8fsi0F7XjnqGFSW2B8UQN2ZazM=; b=DsUaTbESdyWwWwnOcJxuedkKiT20EeVnZqP1BgvtcRtLEVfF4yipsQRW5BXewgL5Z2 +SqsmHm8P8TuySf4SU7QifdFu1m5FYujDTfy/+ZMcnTjNNM4Kiwb1SSX+6HFRaG2CUI5 j6Tl4Ca8S5UiCDFEItGRiod8bCXKdrqpXOOq6DcjB4alrHg6ginQIbl2DJN1qM5bIaHZ 244kvJsl92LSZqzs+hiE9sN5QXM1QGEES4yufMtZFBGliYrKJRgZElkozjcXUw3oKFEO rPkcIlf/sDFLPGmX4OdClGMj/fyqq35JVqmOYQHu7zgdPSSUFxh5zV2v6uG6TkRbx0yl B67Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775003992; x=1775608792; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZlAyR4IsTCd6Wy9tY8fsi0F7XjnqGFSW2B8UQN2ZazM=; b=hc1/DBaLhQhszRX4MRoVylsMCYYc4hAVKVqjVg1ZI4q1OS/2zZJ2XCDD1kwcWGX0xg xBerrbQS6ZVRChWUkaJA116bJ2f4sUjHKenDCCTR8TS7q2DaK0FmqokV1MbfScPoQq1U tOV6VBZBCJSmmHtR6fne5PTOSrQonh4bx42R6X/x9Yhl2rXbH8dGPKUx260EKeIZRRNI ddadh6YLMh2hB0qo59oL7ia/fopes7bDlWgobGrjnk2mK2NPHicNhVZ9voBTAXwg9YDA ad5QHJs8UwQ2kZIIbNZ9grGRit/NerG6IYeLLRQhH8xChHdE7I4TiadxCpbU4OSvYMPZ M3MA== X-Forwarded-Encrypted: i=1; AJvYcCW1mTq22rJxdkvZ7bWsjMIikAJJIcbU6ueKQG7dfzYRFLigAFIJoWsvmiGysj35YGqApwt2N1ITqPxD5TA=@vger.kernel.org X-Gm-Message-State: AOJu0YxanFSaAXNtKEqWVTAYnsvNaaWDnb4y8C2m6OysA9q9ZG7XbYk9 xcGGwcxZBU/l5pZlKv7Ts0Q8Lx05h7TOwh25XiFgYLbanLd0N5R2XL/MI64IoTz15p4dYSxT4fE ogTiTd0aOzk3uVPP1oTXcsyzIL7fagrmrMeBS0x79o0L+fABMBmvv2TwPvkK6lkPN+FnV7bk0sQ == X-Gm-Gg: ATEYQzxMw8lHLcA+vibVkh++Wmlc817NW1kRjCXyswrCX6QETr+jCCODzWbTSLnmize lYs7TqzD3oZZne+v8eLiFNiKgTL4KZ4ZHo/So7VO6PaRTAB/M0ULRSqP+D30ux+ZXv6BWm/eaw7 vp3XWnQEJO3Pe2uChE4Uuph7mresSHTp+Lirs0R/9n4biBq9guL0RSXbXmT0cwQlRiDU4J3yYkp g4/qwRCbhqUFUyx946s4mL8+6marp9YdKgZmvFFP7Ya2ABQxb/tRlfVc2WJXY09jZ6GsaoQbofp diFNDWIbRaspPf+tjtCcpXGyji0JXY67cCR6K9eiu1WRHmDRdQKxq9BVlcTzxwnHc0WmE5pY1xv 1vb4y5atKwclOPgm+Ng== X-Received: by 2002:a05:6a00:94c9:b0:82c:7767:5bb2 with SMTP id d2e1a72fcca58-82ce898c25amr1699802b3a.21.1775003992510; Tue, 31 Mar 2026 17:39:52 -0700 (PDT) X-Received: by 2002:a05:6a00:94c9:b0:82c:7767:5bb2 with SMTP id d2e1a72fcca58-82ce898c25amr1699778b3a.21.1775003992032; Tue, 31 Mar 2026 17:39:52 -0700 (PDT) Received: from redhat.com ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cd706985esm4659303b3a.34.2026.03.31.17.39.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 17:39:51 -0700 (PDT) Date: Wed, 1 Apr 2026 08:39:49 +0800 From: Li Wang To: "David Hildenbrand (Arm)" Cc: akpm@linux-foundation.org, rppt@kernel.org, ljs@kernel.org, Liam.Howlett@oracle.com, vbabka@kernel.org, surenb@google.com, mhocko@suse.com, shuah@kernel.org, aubaker@redhat.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v4] selftests/mm: skip hugetlb_dio tests when DIO alignment is incompatible Message-ID: References: <20260330125307.98581-1-liwang@redhat.com> <96d14f27-ca0f-413d-8b61-768933ee70ba@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <96d14f27-ca0f-413d-8b61-768933ee70ba@kernel.org> > > +static void run_test(int fd, unsigned int start_off, > > + unsigned int end_off, unsigned int align) > > Nit: prefer to-tab alignment in MM land. Yes, I noticed Andrew (thanks!) corrected it and added to -mm mm-new branch. > > +{ > > + if (!check_dio_alignment(start_off, end_off, align)) > > + return; > > Is there a reason we just perform that at the beginning of > run_dio_using_hugetlb(), avoiding run_test() entirely? That will make the run_dio_using_hugetlb() have too many args and uncomfortable to read, yes, it's more likely personal preference. > In general, LGTM, thanks! > > Feel free to add my > > Acked-by: David Hildenbrand (Arm) Thanks a lot! -- Regards, Li Wang