From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f43.google.com (mail-dl1-f43.google.com [74.125.82.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09DAE171CD for ; Wed, 1 Apr 2026 04:50:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775019006; cv=none; b=eEWdRTteTJraBrgvTtm35NI5dz3B2V3SVTzMPVBX1gs3f0CqJIYQko+fJMG90pmIjzUqpvmgGslWmEVhMr9EbPU6gOHBl04FmCJOgc+O9+a1w7UGGTOIKelnCKokMsDjRwFepsGqSp516Mqbd54EfgnBt72HubVVtKjTSbtzHYY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775019006; c=relaxed/simple; bh=cz3Xvg0U0I6Gs5gJ8VAhE+Mmd78tyESPPwAOC1A+rPA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XQcPkCo3KlMR2bA2asuIpCVDLoW2yBzvSRKezO5UfaREHijW9B0hJ7wD7/BW1ywNd9cHN/4poa1pVTNXe73ZzNEjOUegrgvSyKGs31vPWNynX7MK0crlVG1rHbob7CvN5U1/sI2k8VcMnD5NM249Qyuh0RHjoZ681wHNlE6WHsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eRNHZa8I; arc=none smtp.client-ip=74.125.82.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eRNHZa8I" Received: by mail-dl1-f43.google.com with SMTP id a92af1059eb24-128e4d0cc48so7727942c88.1 for ; Tue, 31 Mar 2026 21:50:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775019004; x=1775623804; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fHQEld5+nd41UvOGakypuczq2ymCpPSNo2keMgfXMas=; b=eRNHZa8IMp+7shw6ZAFAgHyGsfwJcU+p1aC6joxKxO42XogFNg+JMZDNITY99Nz+pF rZd8ZSkHFguPjFOXEet6KDtAZYbNKspXyNS3KW+6TXm7wnrUKqMwKpywLBjAUMattBzI Kp+FnGRsiA7nxPrLacd+4B7qtZAsT20nTx7iwYUglGQODH4nmxAD9eOsPrcJrtOQ1VLB R1wZMIC6nU6cdtpr5Q/bLE9vkNsQ540VFCG31C+IK5TpL4AItzNJO9vhMmrYJexJueS4 wN0R6Z4gFpCaNmU7WLEKdjsIWaH0+Avk7CAL1nqdBayy0ZVymed5GfZk61LNyzm4oGSd N2+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775019004; x=1775623804; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fHQEld5+nd41UvOGakypuczq2ymCpPSNo2keMgfXMas=; b=IU+RzSFF2JQF4AEXZrMLNoG/+5uITLqVgC6aATEzXYzyIaZNDcFNB2OjUGhKxi8rHj pjV+jBnp0KxvxTNRuxt7lBoxdmVdKmftvG8oZA7bnNAf4G54mq386hTe+SX0gGrTh4OP dnOKb/PnX/kJ9LmhYdjbyq0PIwD038SJGuZi3+ZYSH67yxxlQaRK8bqI+Ym0S7Lex1QQ Ei60eqU3wuQfR2y/PDlXtxzYY1GNk6rbgfy4OAULjwphBoN9LsTUlnLXBroclB3O8c3m wJ2Lkv0ACcuT9lwe/4cCkHh7BxAUpkCB3SM5FhlbVE3vW2SPpNQ0EqoRNE7EW7MQoXot qQAw== X-Forwarded-Encrypted: i=1; AJvYcCW7sOlLJXFOGS71hBlgk7A6IEyqXXsIzSftbHZ/tr8iTqlVU9tPRKHBe6f1Jk6Poz+QiBw+QpeKgsJoi/A=@vger.kernel.org X-Gm-Message-State: AOJu0YwmtI7Lt53pTe6KixJKpZ2aNYEnciGs+gm/rJT6DfAoeoYgq0Rd dbVbkVCxMcygkwEroKvBLGR837dcCQHG+vfGhihCcn5Tygn6JPqPw/GO X-Gm-Gg: ATEYQzzu9UUeP0QDuQ8ufc7N1FM8OR/c3FrE+Cr6/JpJTXQeEms4F/LstIhLg958GuP rqCufAxr1wkAYJ6qlz/L0+iSKQcJQAJLgSlFXQarPfHcFdv9aRKUFdnaQPUguXGPc4f0CCRuOj2 Y9+EIllZXte3yqcHTm14f3h2pfIgoNal0Vk0UDg5Fu+46IoLMoj57kTmfyL3p/MIsy61B539UGx ESet+cJNrH/lCnmNDEtf/Er65X0kU7iGypTqsS9SwRnfbToQwUywLtSmqKJlauKSR7Hg+OT1iZN kxH/K+FygfsQpWGLw4RlmWLeSuEHeeUb+43KIX6sWmRX7JfpadVrDEW+GO+foVUJEOefo4HjGLy ZhkmRrer7fLZ5q28gawpYul0IWcviJ0v5ppiAPv2rmsrVPeY7119juMJJRbr5n/jM5Vn1vqnCtv ptD1MR2hrfwOv6e12czjImyo4TyKoLoIvywOP1mZYKYfYUzxQzzD0thS+XaFve7tuP X-Received: by 2002:a05:7022:ef18:b0:123:345b:ba05 with SMTP id a92af1059eb24-12be64acde8mr1328345c88.22.1775019004105; Tue, 31 Mar 2026 21:50:04 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:1dbf:b0e0:8ad0:5a2e]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12ab97efb42sm17866414c88.7.2026.03.31.21.50.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 21:50:03 -0700 (PDT) Date: Tue, 31 Mar 2026 21:50:00 -0700 From: Dmitry Torokhov To: Joy Zou Cc: Frank Li , Peng Fan , Jacky Bai , Ye Li , imx@lists.linux.dev, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] snvs_pwrkey - code improvements and add report event Message-ID: References: <20260326-pwrkey-cleanup-v1-0-d85d7c0bf275@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260326-pwrkey-cleanup-v1-0-d85d7c0bf275@nxp.com> On Thu, Mar 26, 2026 at 06:39:37PM +0800, Joy Zou wrote: > This patch series improves the snvs_pwrkey driver with better code quality > and add report press event. > > The main improvements include: > 1. Clean up the code by using local device pointers and dev_err_probe() for > better readability and easier debugging. > > 2. Fix potential event loss during system suspend by reporting key press events > directly in the interrupt handler. > > Signed-off-by: Joy Zou Please address comments form here: https://sashiko.dev/#/patchset/20260326-pwrkey-cleanup-v1-0-d85d7c0bf275%40nxp.com Majority of them seem valid. Thanks. -- Dmitry