From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5DCF39FCC5 for ; Wed, 1 Apr 2026 10:33:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775039625; cv=none; b=ta6K7gpV79qDmQHfuoz8Q5YHCdXPL4pX4SHsbHnjL8/5crqV4rH2iQdD2QC5W3Di1Qf8xWYM7YJZ3AzLGjFeR3njAYTwgDd0z0RYoG/vXq8uFoe15KG7jxNh7ABfIl1/s8ibtDhPYRygd3tuOjKXLcR44QrDwj4HfEDAJGpPlaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775039625; c=relaxed/simple; bh=zGPlVUHCjZoYfFsFOzXJv3t5Gc+5g2Akc/eChqspeEs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U65+8E2iS3m/sW6kjE8Hss2fMXwZI1wVFGSW4m2+iv3piv6n10Xd16OvLjSaLgkCNVbL9fy4hUfMPMDvsphs7Edw9xZ3JyrfB4Bt0gyPLdLmrt55TlqPJGNv88zvUpHugInN64BQ19rQTyqoL99QUm8MqElQBCUM4JvuEmqpyUU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AOm2p4LL; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AOm2p4LL" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-486fe655187so87884045e9.2 for ; Wed, 01 Apr 2026 03:33:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775039622; x=1775644422; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=G34kEBdYg+ZgvngYa+7wgYAY1nzSK95X4oNiuiiqskA=; b=AOm2p4LLsFK7hUN7y1JNCDzJOBdCFf4PfB2B6glwnqVEUe/bpOL7bGHC/CBkKGID/K Hpsahr6bR+i4unw70YKa/VwA4JJFHV41gOajS4ks5tU+HzdH6Qb1JTrtDX5RRn9rxSvc yOpHNi2wy5qh0OxKMZmqhLZPrV6oJuN6dpSzUyRiUbaLzgg1EFypDsGfwGzhGevL5Ykw NWw3ulAEtmqp0Li/RhdzU/BDM+oukrhDFErY3GTuzq31nVC1JEb4L/TBaowreY3ZfnU1 R5A8dZQ7AjiAAFppfycoKvShoMuys8ZCqWv02Ke7sl4UN4pX230ICxEWEUiJRxUASTyO Tf3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775039622; x=1775644422; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G34kEBdYg+ZgvngYa+7wgYAY1nzSK95X4oNiuiiqskA=; b=SX1XbUBdMGWVb653bbwfTmkAW/yyPNvC0iWsUcJIWLce4l68KCri3x9QROrZhoxMqu H5s42JAbZZ9lrkfnYDLhdxGK0sZ5YXRRfv69Z6zwwd53OzEqHDRCHKO7U/UXgYjx6SGV U0ml0GTev592arAs35rvYAC5CRu98Y/LwdaJGWICt8R8RFIlsLtSh7owhBqH1QY23ihm PNG5E7zkENeI0MIVrsj46uDTtsc4NQLF02y3OneqUVMqHmH+rvWcs8CghHkr7+P1Xn4k s553I7ix4UELBwg5EnwadVQhOE0EkQhW9cyjazxETTq1v5bYw1BD3TvJrMvGU+OSKUH+ UlRQ== X-Forwarded-Encrypted: i=1; AJvYcCXAYWRiwJp7SXDNxRLRcKisRyNYAsU7cYkwtlKygm1SB0S0ubMds80BcTEYKVuiYa4PUf+QyHt/JEawATw=@vger.kernel.org X-Gm-Message-State: AOJu0YyGZMl6P0uHD4/FhIDHr10P1ShgbtX/E5K4YudRrS0UYFJUlkyX V9RVO7Hgx5xRchVgyFxwfnugwsKePGIhbEWK8idbA/VUbwWQFYoLK+fL X-Gm-Gg: ATEYQzzvokX+QsJ/pTCLC/YaKEKkUrrN8tqw+EAeGCKLlOSnmPSFkgNdWZs8WB7ttYO R+RfRNN7U/JkSR504Bk75co3EvoHoqZmXJ1RBPA69sURU64PEqG8K6FpJ6H2NGJwlBAt5r2Pmt5 kdeKDBZxYfHLqan+IWtQy82GTmn8jfkIPH6hZ1mBkotFATj3HAFvIh+GJmTHjT+AgUGiSStRkdr aeShvef1Lh/x58fsD5Py6IMBJKsXRItikkxJN2UWdUTgz78k5aABdK9qJ2i0fpaEfdXRnCni3yK uRLZAFEGfxfNs7vkGQpIVrcwsmd5bjpd2XYV1clVLXczJTiUJ7a0PaDRKoLnxZQjgDpTDRktpHD dOvgGrlnI4M/yas+myYiAtFuJx6bu5qQWv7Y55Gca/90sYeciTtuimsX2I9IYi2Bi2iCZfCq+E/ yb0GFzBqY38U/eQMaOdbU= X-Received: by 2002:a05:600c:8184:b0:488:7ff6:1f75 with SMTP id 5b1f17b1804b1-488835904c5mr48079095e9.21.1775039622071; Wed, 01 Apr 2026 03:33:42 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e72da6csm211696485e9.0.2026.04.01.03.33.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 03:33:41 -0700 (PDT) Date: Wed, 1 Apr 2026 13:33:38 +0300 From: Dan Carpenter To: Luka Gejak Cc: omer.e.idrissi@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 0/5] rtw_sdio_if1_init cleanup and small logic tweak Message-ID: References: <272CEB11-DD9C-43BE-B47D-49F8BE1A0392@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <272CEB11-DD9C-43BE-B47D-49F8BE1A0392@linux.dev> On Wed, Apr 01, 2026 at 12:17:41PM +0200, Luka Gejak wrote: > Hi Omer, > Thank you for submitting this patch series. I like the idea, however > during my review I have found that there are several issues. > > Patch 1: > While the patch makes it visually cleaner, this patch introduces a > significant risk of a kernel panic. struct net_device *pnetdev; is > declared on the stack but not initialized to NULL. If the function > fails early, the execution jumps to the free_adapter label. The logic > then evaluates if (pnetdev). Since pnetdev contains uninitialized > stack garbage, this check will likely evaluate to true, causing the > kernel to attempt rtw_free_netdev() on a random memory address. That's not true. regards, dan carpenter