From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B36537BE6F for ; Wed, 1 Apr 2026 07:22:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775028124; cv=none; b=rytk+h9yflty8M1Yk9T5r2+SpEYhJsCh7f5g2os7FvhHTlMK2hDC+UaN+Bzg0SNedjXyzZViSJ2zz+hQXJT3dIQtasM+dE+zLaPLwOED8Z7IyfrOS4QK4uaiHJPffm1SIk5cSKmssYNMXHAip/juzWk6de/BidijlIVuWdSzZKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775028124; c=relaxed/simple; bh=zoMzCwLz58hsOtyKlOVT1dSDiy6GUF38z6feI7bv1Vc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KntY659WQf6sqezD1Ck5sTmrKO448jthMF7nRTSD10SU4lw9t4mtayrKlV3Pz0hLGN5zqidQi3Jv0UyoK0emJiox9NVa9zNGi+xNfg4uGqtIc3IBXagyNQFxP1gDzZNrkpeb+8EopwOOawGZWx6U1EsnXfSBEoL+0M7Ubvl38I0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pj4C94Gl; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pj4C94Gl" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2b2494440f3so13357465ad.2 for ; Wed, 01 Apr 2026 00:22:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775028123; x=1775632923; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jQNznQ9kFgYwHnnqDt5/rCEInESrDADfWL0k3BeYRCU=; b=Pj4C94Gl9cbbI6mKlI5M/W/3gly9FICMboC536Q2Z5YsFmQENo5HTfFcZEaX0H3c5r D+UIgz2iePUa5TQEgha/q87h0ARaPrsEpryRDPFrGSzyVig1VCCLlB4q/C/rTMPBl2+r 5BmmJ+5mTIfqhoh3MhaLdAOdy9U5SRxdvz4BouyvoNh/I1Zfb859oa14UEdJUBH16PBW lt6nXK9VNuomCE3c1EB1QzkHj2esr3QTvOYc4IOGQ+a1gsJ6zzemAhmsgxULVf4BK3Ap NUmQ4j/XoncSS4iOdv3usEF8Je4D46G/wa98TtYh9whs93FY9V4uPCoHzLBj87FrMicv UTDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775028123; x=1775632923; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jQNznQ9kFgYwHnnqDt5/rCEInESrDADfWL0k3BeYRCU=; b=aEEXEy8kHzrDjYE/qDgr0aJpKvnNldASFDMfNn5Rn9Ts2VA4rWGt9baATkTw7kqWCb SB61yzNM89aSyNig43lHfG1VRbuLQw5ieOgNmM6kL0lpONyjMhvNSPmCwQTKUQnoQPD7 1PDjBRprQLeZWunncDXq//+oQ03iMxiFcF2qbMJHQdM/lgnfNyGBwKodMr0hkPa/7FFR hBlFyGHaindZLRtw5pwTaRhPLd2UfRPgmEul0m8ttVM9TR/hpKQRpfInvgd4iREg/tPP oZMRXPzSRRXHCPA2pLfQA1wm/IJ5ZPzKlLX24gbk8QZ5WE9ir0QoXa0+V5MfvYVCnTdy 6aAw== X-Forwarded-Encrypted: i=1; AJvYcCWn7D2c/4l0Xpg1TsfrBeFao1ZwdnQVa+p8qhgS4XDJEK/D73ix/W4picQzr2BdwPADsTfZoFzKf2k7ZnA=@vger.kernel.org X-Gm-Message-State: AOJu0YzpqtGmqsu6zwQn7FU+BMS2CF6W78UCbRaaEm2PwyIQINjCsiqF CE/9gQgF7MpuQAL5b0iDmBO28uInCr252c3Y+qQBIbhooN0FsjSaT4u0 X-Gm-Gg: ATEYQzwzD9fdGFnWkJetsoCtKxO1aJ4Wlpxlyd1fYzKJZdOR5jXHdkpVb32Le2tVrUE w6s6xpwr9+6MKDns3RDVBevF8demaQ5g8rmWYuPvL3tLoptAlnjqWyCa/cj61MVtuYpfNEBQ9Fv LD1LZWjOon1kCwaWfr8igOH/8ei9h0mOxhjHpeN10g32/MzNmQ7Qq5SiESkNRAjBBMvg4nzRDH0 +I3tAsJ8FUSgA7Uaym84t5+D0M/yEhVwoH5laIBAi6evi80aTQsLEFUDybPiCZ4FdeII7fY703d IHapPgRPTBaDfoQ3qWOa46fwEEO+ulkcv4SJeJPUsY+0zBpkNDgOxrxckVn3IDoaMFlutoIcqTw KHFFIV4WcmDRBvpIp9NiMpmB1MuECZNzQLs8e+Osbivejnq+wtYTb3EhwRB7sk06VqQZ9Jn/8Q+ CAVwPd77t/jVj1SHyXoBL9jQSScas= X-Received: by 2002:a17:902:f54f:b0:2ae:4555:479e with SMTP id d9443c01a7336-2b269ac86a1mr22411875ad.18.1775028122935; Wed, 01 Apr 2026 00:22:02 -0700 (PDT) Received: from fedora ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24ddc0afbsm139505495ad.64.2026.04.01.00.21.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 00:22:02 -0700 (PDT) Date: Wed, 1 Apr 2026 07:21:54 +0000 From: Hangbin Liu To: Jakub Kicinski Cc: Donald Hunter , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/4] tools: ynl: ethtool: use doit instead of dumpit for per-device GET Message-ID: References: <20260331-b4-ynl_ethtool-v1-0-dda2a9b55df8@gmail.com> <20260331-b4-ynl_ethtool-v1-1-dda2a9b55df8@gmail.com> <20260331185028.45dffe3a@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260331185028.45dffe3a@kernel.org> On Tue, Mar 31, 2026 at 06:50:28PM -0700, Jakub Kicinski wrote: > On Tue, 31 Mar 2026 11:56:11 +0800 Hangbin Liu wrote: > > +++ b/tools/net/ynl/pyynl/ethtool.py > > We have converted all the samples to selftests so this script is > the last piece of random "PoC" code we still have laying around. > Should we also move it to tests/ ? > > If there's a reason to keep it as is -- could you please add that reason > at the top of the file for my future self? I'm pretty sure I already > questioned this script in the past ;) I have no objection to this. Will you keep it as it is when moving it to tests/ ? Should I wait for your moving first? Hangbin