From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC22B3815CB for ; Wed, 1 Apr 2026 07:27:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775028471; cv=none; b=uz0dplLIYjFpuG8ud98M+Md94bZC6LuGNe7AUm9ewGbqZoYSenZKRW6ZjenLz3LvWxEFInz27j5VtPPPRvFF1l6/S4ZGK6Y3EvgbJA5C45LkEQ+8zE8forEulRD8TmprSKmICsSec9kFntPrnsZkxijcWfflkP6txCrLoWf1Xxo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775028471; c=relaxed/simple; bh=lLMrZQUEbteA7AyBPy0hIsvctO++LyswbB2GaC1xGhA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IFdm301JX+DHiIt4BaIWYtb9T9yM4SUaprZdJc2wZ2D8WE6QQaftwfd/VO5lbHczgAC64hBbhux7LMx4E19P/b4EHdiiEWtvRlpvnSmEVQ7UQcET1/HSa6b9Hliz1BrcaDYpfrYIe+UJpKkOomUaSQzuLvhZV71LAWbPXvrb2Jo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fj2YXAX2; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fj2YXAX2" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-82cd70febc7so1325277b3a.2 for ; Wed, 01 Apr 2026 00:27:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775028468; x=1775633268; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IAcfd5pCRSTlq7Qwg9y5Tc9lUEvaQc2W4YX+tuMIqpI=; b=fj2YXAX2/U8I6L+UcTX/bJGSqZEcIX9woIDs0Za2b8vT7iE4XLCNeB8QZtGoVaiXOV GHSwwvn/RmPuKo9ZxtXGjRECyJniPYUCovkULDDzoA0OBc3WFqux8iQDcyalixuOM6mO r3s+IHhAvqgdWaDVnnpnx9nX6LV6eRRMXdsVqaKVllAOQQo5QVBNzE5HpNM7ziG6gtGr 2kdrH02mDHIVczMByD9SjPh7mKHEB0jFSgh6S++M2Am1n0VVhS4eoVlMRZSqLSRUMke6 u8odBZDpdNHM374pHpGrxwIsBAmkP+BDvaiy7Xrr/h0CjIFF8+VV178zBSho39GB6Z27 Yp6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775028468; x=1775633268; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IAcfd5pCRSTlq7Qwg9y5Tc9lUEvaQc2W4YX+tuMIqpI=; b=jWpTaBMLAs2kVW/2br7wBrgBl8RZV1oFN3un12D7bEK98Mp2s29LgPltqZSGkwLZpy pWMJXdzqX1Hbdq1NwCi5xi2EA9g54jtCzowcSbWLuP1Vnn/Hg0U37Q5R9D7O640znAIK s1eOjB9tyddkAWiDlxvNCfCv22uWbKrOdqxxXcNyXvRF9RlPTJZMX2GlIRykAcf9wb7U I2L/0hDZmJA6bisLcweDr59lPI85PYqxoQVdLVbqtZKoxKQD9XGLhHrJsXKjuhe10yQo Ynb9Tf1MuehGbMKX5EnpMCmTtdsSZBmJR+BfsXWnigPL2/FawELeBi4pKBT3KNn6Wl0Z HkMg== X-Forwarded-Encrypted: i=1; AJvYcCWrcDdecwvUhHyzp/tWlslCia5MK9p4b2SeIl8WRgxG/VdQ1PoE4j5xamLAnDU1tD/ki6OTR/A0HrSS8BU=@vger.kernel.org X-Gm-Message-State: AOJu0Yxv404X6t0W+/qAr8E7ijJjemt4NGKtSerZSofyxSbcVAMd9ZGK 88RdUGA/50QN+0oBW1HcX3WpZHmqDl22a0tn15ugAuMy3/h5J7+9ZvJV X-Gm-Gg: ATEYQzxXDLA9nYxL59yyPz+Dp0KxzT9XNlumVCv1BXxkTsNfntP3s9fXeEBpJmVZ3R9 Uzvb17fifr+JpMsMQ32cYp/75s/M2qe4iLeSAoz++lku0/KBQ0Qxfgr4HbmASY0OW4BhW07D9FE gGcb7Ho8/4B9ROyMlPyOePs7AHDDY3joIYc6C4VPk1j57XqgbW3cgDb3cbf8mP4h61WU9xMYVh8 rQt7CT9y9WQjU1xGTelzqyJdEuHVVOxhky0/qtJ1PxTnt70lzyMAMPDmCbLnU3lgp1KH09966yB lAWr7glqOcpBJcIpC+ikqeuEFXBf93pjxMpv4DKJsQAnizrpsXvfula5s4ZliiIxV+hbBkM5kP7 f1Lmm3FQ9Rt4S4ydBKmunuqY/zCiT2DXFqft0w2eQ9M+AoI79H3ycFP97MC0GCNOpJMmmQB6CjQ 4WpF2DZsgIRRKGc4kyKm7Uy2h8o88= X-Received: by 2002:a05:6a00:bd12:b0:82c:9c90:54cf with SMTP id d2e1a72fcca58-82ce8ae8343mr2708723b3a.43.1775028467978; Wed, 01 Apr 2026 00:27:47 -0700 (PDT) Received: from fedora ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cdd04bb0esm4192403b3a.38.2026.04.01.00.27.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 00:27:47 -0700 (PDT) Date: Wed, 1 Apr 2026 07:27:40 +0000 From: Hangbin Liu To: Jakub Kicinski Cc: Donald Hunter , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 3/4] ethtool: strset: check nla_len overflow before nla_nest_end Message-ID: References: <20260331-b4-ynl_ethtool-v1-0-dda2a9b55df8@gmail.com> <20260331-b4-ynl_ethtool-v1-3-dda2a9b55df8@gmail.com> <20260331184637.58b968ef@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260331184637.58b968ef@kernel.org> On Tue, Mar 31, 2026 at 06:46:37PM -0700, Jakub Kicinski wrote: > On Tue, 31 Mar 2026 11:56:13 +0800 Hangbin Liu wrote: > > + if (skb_tail_pointer(skb) - (unsigned char *)strings_attr > U16_MAX) > > + goto nla_put_failure; > > bit ugly, let's add a variant of nla_nest_end() which can return > an error on overflow (without the warning from patch 4) ? I was tried to not touch nla_nest_end() as it is used everywhere. But it makes sense to me to add a new function to check this. I'm not very good at naming, maybe `nla_nest_end_validate()` ? Or any other name if you have? Thanks Hangbin > > > + > > nla_nest_end(skb, strings_attr);