From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB240211A28 for ; Wed, 1 Apr 2026 08:42:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775032967; cv=none; b=bae3V0BTHiCEGNkbzsXq3EP9sn4vCtPkCFMmp9YpdB7px9Wf9WmHQqtOIeGE16TFrO4RSyf9vhSzyUF66STNZhqAZf5bi0jjEJcKwbHnncJJN0xUStVF0AEhRTCTuBzOq8JfhBlReys31gDhVt+lGpSmAjQz1/BhUrY4Oxp2OFc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775032967; c=relaxed/simple; bh=1IHQcVhdPtrP4RzyGECmc2J6GpJnW4gAE+8BHYTwBHk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XSpfT6KPrffbNy7FKr69B3CDapt4/7CL1csIDla2A3cqTsDwMbNgmvHwDzachlne0C5uH0gxH+6isjSvgtJmzA3yUyd1AG6nEw0FN80F65LulYdc+9FcihsPt3J0asLOAWgU5CkOdUrro66H4BjVygelOTiM5jQYM8chzEzxXxg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZYLHTZjm; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZYLHTZjm" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-487012ce896so40660455e9.0 for ; Wed, 01 Apr 2026 01:42:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775032960; x=1775637760; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8gdmgWEdzunB3PxAHS6gl2YoRWrIXu+b+T+ZmdqwONk=; b=ZYLHTZjm0vQGMiZ3OKjzy8wnugdoRkbFy0cssXG0TMfVDuuepJg1gSHzS/ie2Y0o8F ITaFhdgMQLUtZ1ChOOqd5s/kG3/qsWRp/EqkXNxaSuE7wNBxJK99qDovgygf0OMDauKP RgkBcJ5UAk4Wc31DJmmhv2BlOM6Y7UVqDBaLDMTlZjhW6jFhcD3JqK5Ld7l/dko1H7I6 3lmtGKbNflM9eneCDPb6WnZfwnADbIU3TXsSlECO3HAI3n3ROTgM4KddC5zXFLh1EW1J 4JGVn2amb5a8pxn8FWckBdUIUeAMJn9sZB7/JBz8xEmD8hc3I3Lm9pXxJ73a4rO4saBU 9pbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775032960; x=1775637760; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8gdmgWEdzunB3PxAHS6gl2YoRWrIXu+b+T+ZmdqwONk=; b=BFnY6jwA8FrZwnmesNbFb+BII4HeFr20F06Na3LMI37kuZqyYzwL4z8C+uYvWb4+pq rCzJfhVNfnDF9b/n2/MFyJYPdHL1SPYySJ1R6YqjDKGlyh2IsvKolSVZ/5Afr6x/KaOB tTgv2dcXBoUhoU4g1LAJT709Y0Unh1tsFZAou8khv8pOx36OF/99oguT2WaYeDq18H2m 1HSb+4WrQjwDl6cv8EIz2bpMCpUk8BMSqlN4QKw7s4X03ogssIQWxUMeZIjWavTuC7ti +Wp4wBvZWsA4BxoPNbQKJ/sfZZDBzkZTlhGzn6OSpTl9fvPBdjLQD7OQxF9lcchR4pla pnYQ== X-Forwarded-Encrypted: i=1; AJvYcCUrKqRce9M9gAD110sY1dVm2Jg9h4NG2NX1Z+iKmPVGW2UqpA/iNLoSJME4FzyQiU5m/iZ9/hbRaJrq/dg=@vger.kernel.org X-Gm-Message-State: AOJu0YyneAbYXCOaprueNDQHJ76Ykmv2PF+3fHs52ljp71wfTgxO+xdz lS8fNWCm/fPlNxbX9cDn9HBLfw13DflrtYSTkuB406CgsDaQ7+9FR1S5 X-Gm-Gg: ATEYQzw1bm3O8VWXfybvK0IqzUsAzkQAA0VViO/u15WTc7HdNxysZmImUIz0Nsf5HJd qgkXEsZHr5RyLQgTGIhNYeMpwVJFKfZsAOpXVnrb5tUtgqH80SJvWIt67/wBnm10bUZBMMXe3Da 4f+O4fZqXHCsnGyaUzLvaf+2ApoH6nYIzyWjB9lNhW8ZWYETWrao2rsK1fkLwHntAAKkqTvz4jV Frq2oN5iA4W3MkGQqS2GEyY/1RmDGBJZt3BeaLcsp8J23VT58g9rAXuhnQt6+BueLYgvABkG7ua KG4Rm1NNvJttw+FwqD3RKSDhwYtrvsBV4dGBIcclq9UU20ukv3YluNbMx/QOoZr3MiBzWWXKY4+ 303hzqStxpzKhWeWC30yJTrlo5kjgkoYlYUGEJ01l6axbWKU/kCGLYooQe9wIChYOu5Np0oXyPm ERwDAFpysy+2mSZEGf8GTYa6LHY9CR4Q== X-Received: by 2002:a05:600c:4744:b0:485:2a4b:7bc3 with SMTP id 5b1f17b1804b1-488835684c8mr40060125e9.4.1775032960217; Wed, 01 Apr 2026 01:42:40 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf245e4f5sm36961863f8f.19.2026.04.01.01.42.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 01:42:39 -0700 (PDT) Date: Wed, 1 Apr 2026 11:42:36 +0300 From: Dan Carpenter To: Omer El Idrissi Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] staging: rtl8723bs: remove use of vendor-defined status macros Message-ID: References: <20260331153255.22764-1-omer.e.idrissi@gmail.com> <20260331153255.22764-4-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260331153255.22764-4-omer.e.idrissi@gmail.com> On Tue, Mar 31, 2026 at 05:32:52PM +0200, Omer El Idrissi wrote: > Remove the check for _FAIL macro on two occurrences in rtw_sdio_if1_init > > Signed-off-by: Omer El Idrissi > --- > drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > index 8412331c4949..34ef40a86153 100644 > --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > @@ -262,7 +262,7 @@ static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj, const struct > padapter->intf_alloc_irq = &sdio_alloc_irq; > padapter->intf_free_irq = &sdio_free_irq; > > - if (rtw_init_io_priv(padapter, sdio_set_intf_ops) == _FAIL) > + if (rtw_init_io_priv(padapter, sdio_set_intf_ops)) Here _FAIL is zero so this reverses the condition. You need to change rtw_init_io_priv() before you change the callers. And, in fact, you should change rtw_init_io_priv() at the same time you change the callers. Do it in one patch so it's easier to review. regards, dan carpenter > goto free_hal_data; > > rtw_hal_read_chip_version(padapter); > @@ -275,7 +275,7 @@ static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj, const struct > rtw_hal_read_chip_info(padapter); > > /* 3 7. init driver common data */ > - if (rtw_init_drv_sw(padapter) == _FAIL) > + if (rtw_init_drv_sw(padapter)) > goto free_hal_data; > > rtw_wdev_alloc(padapter, dvobj_to_dev(dvobj));