From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D27A73D47A0 for ; Wed, 1 Apr 2026 09:32:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775035979; cv=none; b=WRKu/XeglaH+pWxkOcy8fip4xeMFSeGOdhEkks34ZI43U6dstU5LInw9YklwqyMcJl1B8Ym2HAqo3VScXI9Cq/iNdwBGfR5YrXWHKiSMJNtVfF79p6OZf10uo0jwyAE4I4Q20bCiHj8vs7wV+GRj8KfKdJ24SR+dUddi3M8pjEQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775035979; c=relaxed/simple; bh=9Y7W41pctDZ86bQLCH3kuhubLiko2Pof2yAkh+IQB2A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Frj9UjxKO0MaldwH6V3FPWHvxIWcZmJ+82RPagB35G4CaiSEiTe/xXKUGta7Dvmfs1af2t5v51TX4jdY7zTN2PywUez00cp6JSm0GK3PzTjrz3y49S/ovvvavZ0IzZgO2gB+7cGxn3BCxMgHN+cZEPKIjW64htMHVbvRIJvQCEQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bVvyssb7; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bVvyssb7" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-486fb14227cso88119835e9.3 for ; Wed, 01 Apr 2026 02:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775035974; x=1775640774; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qDzMOb+8lR1XzsVdZxlSyEr/CwgkYchiH6+SrA9cQBI=; b=bVvyssb7bnHI0nLeCf7ZpISN2W7QWTTa9USaoRlYObpP4Zc7h9CAv+zqUEplaR+mKP c3L0kCWUzVhtACdPuc+XuRuF4HlM5z/fUjcvB9m8R5AG/8RZOk+9/UEytK2VXJaDUOxX X/0d8vpdtksszMHkhl1fjAAdoAHkITVd1boCX5v9ZwLcCjr6B004qvSOjKdCEuQVChNl 76NjFlf08gjz88ouxyI9bUQ+SWbJSAoXpXNJ8Ck9ZXkxI87rpHRE8XewaTHoVeCj+Ycs bHWJD3AzwJ2HgttS2hvL5gW+GvQmSgF9BhMM1OQyJ+ZlIz9Zh25Kb8eVeSWyLZ9929Zj Kzyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775035974; x=1775640774; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qDzMOb+8lR1XzsVdZxlSyEr/CwgkYchiH6+SrA9cQBI=; b=oJKwb/pOhXLSKETOKym9nTF+PIIQxugq00qyJRpDUZjqM/yUJYD1mAQcRrEEPBvIGo pt2zRMKuNywK8+Bd7vrwKN6ycNqvYWM0uEGe9DOz68lUCHLoQyVeuJn16fR+KpkIrIY/ gVHIHl8szcl8M4mQOsd0ld2yRav2gjYK581K29SsS98sFAb9w5NL1fkYA/m+Xi40rU7x sbxriyFisiGIqVr9jrrbgIMYY4mKlV0b7lg8JvlfgERagSaBzkCYCioAcxhHMNeNps9c xvlCUocQFKc5WiTwtiur4L8ziw+hpGTpZ6WWTEzCe3oF2wW72iGwsREwRqw/Lg1lgIA7 n6+Q== X-Forwarded-Encrypted: i=1; AJvYcCULIMipPYLGA/3HHho3Tfkhj+Z1zDotGelZWTUGtKlDX6+ByAsqe/M4v8aX4PDEKTVnMcOyyKSIy59xfc0=@vger.kernel.org X-Gm-Message-State: AOJu0YxYVqDNwdb25IBpkVdmA10GxYr1fRqW6ng9JOQ4sT3UyzWEgeLU 1itpF93jgL7olpUvHUsEvwiE/dol1AvOxDfn2KzH55yd0tIKy5H7iVZV X-Gm-Gg: ATEYQzwgzW69fts2OgjxiZV0C5MfYm4zrzyxlJdF6gUh1AOICT5T0a3mYWPUzPQsOkl SANrxoIe375Yfr7V9cZTcOQMH3Q4Hs0e1fbO9IttKZVx6O6uSJUE0oQwuHXSThKU5NEaJ58YRlZ zwROAVoMW+3IrlsBGzBKU24g9z5KXKA5g/XfjgTG0MeLbEwF5hQtsuDJ7oeIVHpeaJMTJYOteE9 fZTZIM5KfR/gn7XifukYdQmxZXS+RS2mESE2AgOlocUUceqYl3uR/IAXwSLUpzLG9BNoi0+jcet JJO60UnAFCmEJzPWur+TozXQ7ek7ZlSvUXmIMM/78T4Qi4iOnnNTl8PFJ9miBJLlBPe23JKTjpW TuIGkJ7APZ5lP8t2uBPGm7uaIIHBS3QSq8CX5xh1g4MFvB08pGyOxvam+hcXUuFWBpVcEPdL2hU ImCY/+t/C/KdgfPCh3HSc= X-Received: by 2002:a05:600c:4f91:b0:486:fd71:e609 with SMTP id 5b1f17b1804b1-488835b32a4mr40774435e9.25.1775035974146; Wed, 01 Apr 2026 02:32:54 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887eb5aff3sm145259245e9.15.2026.04.01.02.32.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 02:32:53 -0700 (PDT) Date: Wed, 1 Apr 2026 12:32:50 +0300 From: Dan Carpenter To: AyushMukkanwar Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] staging: octeon: ethernet: replace pr_* with dev_* and netdev_* Message-ID: References: <2026033119-endpoint-jimmy-6b83@gregkh> <20260331111757.110703-1-ayushmukkanwar@gmail.com> <20260331111757.110703-3-ayushmukkanwar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260331111757.110703-3-ayushmukkanwar@gmail.com> On Tue, Mar 31, 2026 at 04:47:57PM +0530, AyushMukkanwar wrote: > @@ -783,16 +797,15 @@ static int cvm_oct_probe(struct platform_device *pdev) > dev->max_mtu = OCTEON_MAX_MTU - mtu_overhead; > > if (register_netdev(dev) < 0) { > - pr_err("Failed to register ethernet device for POW\n"); > + netdev_err(dev, "Failed to register ethernet device for POW\n"); > free_netdev(dev); > } else { > cvm_oct_device[CVMX_PIP_NUM_INPUT_PORTS] = dev; > - pr_info("%s: POW send group %d, receive group %d\n", > - dev->name, pow_send_group, > - pow_receive_group); > + netdev_info(dev, "POW send group %d, receive group %d\n", > + pow_send_group, pow_receive_group); > } Please run your patches through checkpatch.pl. regards, dan carpenter