From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16CE636AB50 for ; Wed, 1 Apr 2026 09:57:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775037459; cv=none; b=lU7GN0q7JvnIr8u0hOcU26zIKBkMX9j5RVj5RmJkt+e9rm9NZkq/+t8uvX1a0PpQm61fmaM3Z1hg9fAyHrWwr73YHv2430whBm7c93uIoab7KV/6JjgpW2KvjnyzFBV3Q4AVPE/Hjn0XbyjWry1MmR3vQ73iDcC2rdG1C18NUUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775037459; c=relaxed/simple; bh=+iDpJXBALYRNSiXsLWS2uoU+0TbeRklPCUEuZVLeh7c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rxsq9+yj+x0fU4XtrkjsP9gtQkVwLjR206hK6F0HbhjFmTQjTqNp/021N9x05a2V3yY11LAzfVw3HMBAI6eBMlfSf4e6k00sxkatMwp2BM9JcIYn4uCf5R6l7zQjX3EeDPzbj0SmKro3vvvVMNXivWtYR2BtHv+2QhVD8/1s5Zs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RW11/znt; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RW11/znt" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-3590042fa8eso4451918a91.1 for ; Wed, 01 Apr 2026 02:57:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775037457; x=1775642257; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uyzxBw7QKCfEyQ+SqW1ntj1GkCAU7kXKz3YfdBWpbPc=; b=RW11/zntb7mv9t8UX12aE6RsJyLKyTHvYzc8QZLdaUbYtM6gtUrzsOI4KzdAYWlDAq SLD9kd9vX3Nizx8CPmdMUV1CUgrwGa6hFgFY0++wiIKfn6WUa/Pd6Wrx0G8XySXKiuLl ZxCjABbtGTQQ8VkdInX9Lyeei6xMSUhI6bs50IkHzHbkGxo7lSwDfCQ8c5JatbTwLHy8 4MqiNYMx3KzStrNN/B1Gdh3cynwewIvGVFoPp4VSaXFZDMomfAiNblR8t9ClZbxTNNYA xrtaLmttpNg1+5rQnQ1IWC27VB+Yx7m8NZoCprp2FZSM+qgbYtIlFJk0k0UDhD2RNYR9 CCKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775037457; x=1775642257; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uyzxBw7QKCfEyQ+SqW1ntj1GkCAU7kXKz3YfdBWpbPc=; b=mCFIVunUviVWBYzvtUe1Obf5kh/bzfg3gKyVUAuVScDAKYia2Fvq5jInjfYgrTx52k X3+nEtD+UEDAvYgNKptMbsINoFQeO31wHj4dODUbgz6IPyiXBHHJuGwK+BNfY1AKnVLG XPDbnwihACtvSS0JSXmVAP9VAoE67QQtMXbt2uPpX+qIkaVGS7JcwHikq71tiImEgGqh oUGJlk+RAAo3HfcVIj8jLkQZYKVpnSSN3dBl9vruHeTDQRpCZ4Z94XGa5n0ND9mU2y6U if3S+KmSHKvsaFpgVOmLJlcG2y3M8HbMKtsPVFnBtSkjeDQkFBqQq3yWG1+CtOWrPXPd nq0A== X-Forwarded-Encrypted: i=1; AJvYcCXZ926bV6UJ4/ZU24Q621j3LqTtj0/E6W6QbxghjuyaEs2OxpYEutTkn2vlBOzhfWSUVX1bqtKcaneZlnM=@vger.kernel.org X-Gm-Message-State: AOJu0Yyci+0kfo+NTeCIprKwBEIdqpBGXgFp1osvZ68RRRC1dejyWOcK 9+gZuUAf5DPZZuInMYfIKPSzfXptbMpt8RdK/zqai2OXzx7hMBtN4Z39HsKRGCqbFuA= X-Gm-Gg: ATEYQzwsDgDaSQ+eAiAbnqFtkbkEtIxOX85JVD9Y2zA/vy/wqiGRSRNkziMXy/eCkGm PhJaFqwWcWPQTK1wcGXuJn7fkp7wNYYDDjaF/W5dm1rb29i1Pu7ayKcc/UpwR8Gw+TYODfuorwY gF1PtCwFQOhQhlFQ7ibpHiMcNM4qMkAvh4WeeaV0ojXWuKsRFgjtRvitDv/I97my2qZ5CRis0O5 GxOkgMjZIQZF6CW/ZLfYNEFballfz7k56HMLETs5/KC1CINfR1ltLOvieJU7zVPSK+SSQmsVy7+ +5opWHV545LBBZKknOse5L+hmLp31ZInMdZNIHvhwW6q7K0yhjOU9Lh+G/dBkohVVsJzUJkeeiY YAPcr/ag0eanaJPvtSqLsIhud4DCJ26WbXGnIFSLm06jpbLTTRltvXrHWFrARcDKPmhFloktSBQ FlTMtBNjhsH8gAnCMgB/DAd9OefkwMfs8cHxIa3Bid X-Received: by 2002:a17:903:1246:b0:2b2:42da:25cc with SMTP id d9443c01a7336-2b269a95f89mr31039555ad.1.1775037457330; Wed, 01 Apr 2026 02:57:37 -0700 (PDT) Received: from computer ([2a09:bac5:40b2:a82::10c:35]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b242765d3esm187298735ad.47.2026.04.01.02.57.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 02:57:37 -0700 (PDT) Date: Wed, 1 Apr 2026 15:27:25 +0530 From: Varun R Mallya To: Leon Hwang Cc: andrii@kernel.org, alan.maguire@oracle.com, yonghong.song@linux.dev, song@kernel.org, bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, memxor@gmail.com, eddyz87@gmail.com, martin.lau@linux.dev, jolsa@kernel.org, menglong8.dong@gmail.com, puranjay@kernel.org, bjorn@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH bpf-next v2 2/3] libbpf: Add FEAT_KPROBE_MULTI_LINK feature probe. Message-ID: References: <20260330110019.549079-1-varunrmallya@gmail.com> <20260330110019.549079-3-varunrmallya@gmail.com> <0c82df11-2dc8-4828-bcb6-29114ba91fc6@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0c82df11-2dc8-4828-bcb6-29114ba91fc6@linux.dev> On Mon, Mar 30, 2026 at 10:42:57PM +0800, Leon Hwang wrote: > On 2026/3/30 19:00, Varun R Mallya wrote: > > diff --git a/tools/lib/bpf/libbpf_internal.h b/tools/lib/bpf/libbpf_internal.h > > index 4bcb6ca69bb1..633106a687c7 100644 > > --- a/tools/lib/bpf/libbpf_internal.h > > +++ b/tools/lib/bpf/libbpf_internal.h > > @@ -388,6 +388,8 @@ enum kern_feature_id { > > FEAT_SYSCALL_WRAPPER, > > /* BPF multi-uprobe link support */ > > FEAT_UPROBE_MULTI_LINK, > > + /* BPF multi-kprobe link support */ > > + FEAT_KPROBE_MULTI_LINK, > > Even though it seems good to put FEAT_KPROBE_MULTI_LINK here, better to > put it at last to keep backwards compatibility? > > When users compile application using old libbpf and run it against such > new libbpf.so, will they get incorrect feature support? > > Thanks, > Leon Changing in v3. Thanks! > > /* Kernel supports arg:ctx tag (__arg_ctx) for global subprogs natively */ > > FEAT_ARG_CTX_TAG, > > /* Kernel supports '?' at the front of datasec names */ >