From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FF1320A5F3 for ; Wed, 15 Apr 2026 12:32:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776256375; cv=none; b=VA1Msh0Pz/X2ok8UAb43v3BwqAq6C4h62mOLFtWZ+tlk9GGp+Y59ZlfdyL8a7xBmA0VlC+StYS55Zg7n+wT8YXXvTsYw8g5o2GC8nO0ElN00/FmdqEecCTQHuQXLK/YyorASSq4hEY0OV8/HYUx0CrnpKz5mnemWbGXpXYv38R0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776256375; c=relaxed/simple; bh=4fRC7ugcdpBzmiBi94pawPj2gQ01gH31+CXKdFmV2kc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AHhTMypSwJB6s7ly9dPtNSnovo8lNMvC0VdYiXaaQ2GmnWhe78RUUQU3ykURf5CiBHAzZTKjDnKYcTwwoIuGBwW/9JTn9JiqG0+KASzYLjWPjBWRx+UY9N8eJ1CTb6y+XARem6DxLDiwUoNtUj/n7cyneMWUvLZpm9jBRDcec0E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V3NmrQ3D; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V3NmrQ3D" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-488aa77a06eso110702735e9.0 for ; Wed, 15 Apr 2026 05:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776256373; x=1776861173; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=j4QGKACJwE2/9AKPpC8u6xf56pqFwJttRvP08nI/Ba4=; b=V3NmrQ3DdiO4kJfBZhC0+dtH1UaSVTWHkLCoFDmOLK4Fnxl/xjhubg+X6wiYhwpQx2 ih/vXmlHHBnfn58dtNR+iH+YMcDsfdYde87R+qxDJbMawW0+2YDuW77U38eO6OYbLNH1 seKQcG/NcJinuRGAaU9Ed/SXvqv5wm22/H9iVcYAehLxytVO6oQVcXcH8Xt6zGGti4ri D2jSzqlsUuNifsZY0BBL4jDIcj1YRZvGbeUZfripg8Rejysg2ZV1D1WAK5sBdTQLPcCt CtFN5k1YHO6AfYKXkM+MIhqoYAzZzPLoPMZC0uYuVUbdJKt+Zff0ZliH+k29sEgysc8S o4Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776256373; x=1776861173; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j4QGKACJwE2/9AKPpC8u6xf56pqFwJttRvP08nI/Ba4=; b=N/qp8XY36v2Jfjy2WqRtbPkV2zQFRFUArVANTPyBkBinpdgNEDK0IkmoswzwjgUjWS 4sZ4bsXJhBzzUQbpX/MNVKEY9gQDwlkZHcIhiluJUYvLz9/+Y3qv11HTKOZTxPlCwMHK 01E6A0n6ISpGpjUz9HZ2UupgTQzEpNOfMbnUq6MzI7G11TUU66o1ngbIYErmO+m4ERBb OQ55xEck8heu06CGCxZTNCipS4dtw9Y4wIQlv85iAwIKhQHeyCuFQMQ7Rh7njv+hQaNo ab8wHbbtT1502O14ZM2JVHuOKDIJjnwAyOMqAlcnVEpaNU1St/8TtczftwCenlKMSvhG tRzg== X-Forwarded-Encrypted: i=1; AFNElJ+fHUHK8GkBTqiaPNNCBQleokJtW1fT9AF13HUAcA5ccDQnxdnz1lb8Y1zu8Tq+NCAII19bCfUVM488Ccc=@vger.kernel.org X-Gm-Message-State: AOJu0Yys+vYS1OChExMbd+U71TX/sFBVheNiml5yeBSGJPWmQbms9sVC mtr/R1BeAj3rySum1vnP9p2cYe4FXxFgvqZd4IQ8dJsFK9MlhT4+B49B X-Gm-Gg: AeBDievQ9C5YnJMPJ5IH9cQqSATXHxlxlNYUfB/nyubU3u6hQu2ANUirHIbfnd4p9N7 YXzKUFTmqhDs0ViwkAZQ7HLZzUK4+98AFXfUivbvI/X7iRY+9f/XvH/Wv1hs2QBVO+QlHTPBYxt NQmHfA3KUbv6OSvlGF8Wqz00nfjVMEizqGHzZh5U9Nf8vGoK+ang1kCpvETydvUmNaoNplTB7VR 6Scu020EWCpJXkdMnp6wYUjHZbXcGe3PMGu9DOvJNVjPsSPVc91SXSHyTsnShuC3ui4wWkHgpor 278FwdHwTfRp2tzJvZle4xQhZWbVsW8K80pXlQlFxKRhJwv/2U5161LcNJWEgqKI9c5JYefMoPL fU98dv+EVci4BmB3FVeLxGxqfQmdF0ixErZjE8aI/A91WncsurdpqOdc6vePfe02RayM3+IyBYN eIW5wxT8cEBC8V5QpH8VY= X-Received: by 2002:a05:600c:c0cc:b0:488:8840:e5ae with SMTP id 5b1f17b1804b1-488d686dab1mr208019635e9.24.1776256372924; Wed, 15 Apr 2026 05:32:52 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f1d5dd43sm47579105e9.0.2026.04.15.05.32.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 05:32:52 -0700 (PDT) Date: Wed, 15 Apr 2026 15:32:49 +0300 From: Dan Carpenter To: Maxwell Doose Cc: gregkh@linuxfoundation.org, tsbogend@alpha.franken.de, len.bao@gmx.us, yoelvisoliveros@gmail.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v2] staging: octeon: remove SPI, POW, PKO, and Helper typedef enums Message-ID: References: <20260415122939.77847-1-m32285159@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260415122939.77847-1-m32285159@gmail.com> On Wed, Apr 15, 2026 at 07:29:39AM -0500, Maxwell Doose wrote: > This patch removes custom typedef enums and replaces them with standard > enums to address the "General code review and cleanup" task in TODO. > > The following enums are affected: > > - cvmx_spi_mode_t (now enum cvmx_spi_mode) > - cvmx_helper_interface_mode_t (now enum cvmx_helper_interface_mode_e) Presumably the "_e" stands for enum? Ugh. No. Don't do that. regards, dan carpenter