From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3767E15665C for ; Wed, 15 Apr 2026 15:25:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776266723; cv=none; b=flZJ78pWEyxzqESXrpVwCbq8Br0kMQ0ODBaYhA+YW7eXA0DpLRmeCiJ4R97fWRjSsd2953DNWJm3q/k8vhv15Y6GnHgHGAfg9jl4At9zFHrBWjppZU2rQoIaaZ+2YHV6wd22Eg3RADp3XpYyWX4xbg4QKM4lltihPv9EwhjupO4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776266723; c=relaxed/simple; bh=W6FkZ3uE9mgY0rkq1F3NUbeWKjKQ3Q3syRnv7eeTK44=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NBHwOxxoKzGRCH6v7z3rKxgmmHfDk8reM6tNZqQ5eFoeiquxU+gFBrwey4ajSLO6K8jGpxiO0+9QVxStY3b4oQBETD0QYGSJ+0A0yJka01BVzn/CcsY8pkChY05VRsKu+krq24e03GQyZh50432cTO07u15d+wNL3qcylIppGn0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DQslU1W7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DQslU1W7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06FA9C19424; Wed, 15 Apr 2026 15:25:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776266722; bh=W6FkZ3uE9mgY0rkq1F3NUbeWKjKQ3Q3syRnv7eeTK44=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DQslU1W77yS2kDwgvPs3tsRkKpEsEx+V83F3ickyDpAzG+O5mAWIhOopUZHq22JeH vOQmVniiNDt2Y5KRQcx875bRYBdaL/+LYl9rHOCCAFyte3A967BkhLttZLyUVQF8PF Ma+2UoSml39AKsQutFYCJ+K0MFeQhm8QKPFqlp9sHV7PZSxH55YnQqgjr2WtqpWvJs lgev4JiV5E1d9LjEdHWtk25f5KZC4tQyz9N6S6iJNfrgIR4tNUnUt5BSlKyjP/bDyR 6UkU+N25lCfDmPwlvLMTKyEK+8Xcl/eY9OeI/sub+fTnxZHf1NPInjDa/p2Ua/Dn5+ jGUgpfNCmSTPg== Date: Wed, 15 Apr 2026 18:25:17 +0300 From: Mike Rapoport To: Pasha Tatashin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, dmatlack@google.com, pratyush@kernel.org, skhawaja@google.com Subject: Re: [PATCH v4 03/11] liveupdate: Protect file handler list with rwsem Message-ID: References: <20260413185127.128180-1-pasha.tatashin@soleen.com> <20260413185127.128180-4-pasha.tatashin@soleen.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260413185127.128180-4-pasha.tatashin@soleen.com> On Mon, Apr 13, 2026 at 06:51:19PM +0000, Pasha Tatashin wrote: > Because liveupdate file handlers will no longer hold a module reference > when registered, we must ensure that the access to the handler list is > protected against concurrent module unloading. > > Utilize the global luo_register_rwlock to protect the global registry of > file handlers. Read locks are taken during list traversals in > luo_preserve_file() and luo_file_deserialize(). Write locks are taken > during registration and unregistration. > > Signed-off-by: Pasha Tatashin > Reviewed-by: Pratyush Yadav (Google) Reviewed-by: Mike Rapoport (Microsoft) > --- > kernel/liveupdate/luo_core.c | 6 ++++++ > kernel/liveupdate/luo_file.c | 31 +++++++++++++++++++++++-------- > kernel/liveupdate/luo_internal.h | 2 ++ > 3 files changed, 31 insertions(+), 8 deletions(-) > -- Sincerely yours, Mike.