From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8AAA3DA7C5 for ; Wed, 15 Apr 2026 15:34:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776267246; cv=none; b=bpFxU+/DZKDYRmBEE8pcXZeeiLBPRNRRC2I5KF+Y1/XdEEQC1njAPJ/2OfxroD0DbDBvdTgVgDDQN9iDA88BaiR7M5M4CCTWxwIjLcVX8pKjYy/GfkXHkj2qKIltyidd8FOMsjocNjhSGI9aFO1MrB9BiukaXHIf2SQLKh1YsAs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776267246; c=relaxed/simple; bh=op+9SmwNWu9WUokAubo/m89uRY9vqEFKlbQdtN79HVM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n6JKCs4nT5eQlbQi0n+FBt7gHJJGE0I/f5nLMJjV7baUBUA+GQaVu27A0b/KQ+F0JidmoVEShoORd1lVDaRdliEaXjkXk/42a5/S2KLY9/gOZpgSybcFqmUsge2l/0v0fgAxcX1HKSU5yPm6LBCTBM800vPqBNAF2UPdl2M7nk8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vMJlnArs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vMJlnArs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBED9C19424; Wed, 15 Apr 2026 15:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776267246; bh=op+9SmwNWu9WUokAubo/m89uRY9vqEFKlbQdtN79HVM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vMJlnArsw+4LXD8h8cHFtttm/2EI1x8c47Ja1yMVa/SJ51u6NjRFToVGcXnn095ve 8hqMSd+E4CIndjpkvYErxrpbJIibYCjm/yroL14oRr3J4EmjWHMp8ZY5x16dyHr6YX VP1ZnnEHcpsZa072k3Dj+nbWesIpgnt1w5XTrz2EX+VbfAxTZsx/CIqkZSq6etuJqR DO7NmvZVnVo7npNyWPAVxd5xNJpZNdfQ1uhqv7LODbXAbnVs8zC3LAhDWnRD3szfgg 7LLAWOwn8aAGkbs3dcgyR1TLvZUf793ULwFAAQj3DOF2lsr3BHskFVJ1xhIiIe6Glb dv29G4OUau+8w== Date: Wed, 15 Apr 2026 18:34:00 +0300 From: Mike Rapoport To: Pasha Tatashin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, dmatlack@google.com, pratyush@kernel.org, skhawaja@google.com Subject: Re: [PATCH v4 09/11] liveupdate: Make unregister functions return void Message-ID: References: <20260413185127.128180-1-pasha.tatashin@soleen.com> <20260413185127.128180-10-pasha.tatashin@soleen.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260413185127.128180-10-pasha.tatashin@soleen.com> On Mon, Apr 13, 2026 at 06:51:25PM +0000, Pasha Tatashin wrote: > Change liveupdate_unregister_file_handler and liveupdate_unregister_flb > to return void instead of an error code. This follows the design > principle that unregistration during module unload should not fail, > as the unload cannot be stopped at that point. > > Signed-off-by: Pasha Tatashin > Reviewed-by: Pratyush Yadav (Google) Reviewed-by: Mike Rapoport (Microsoft) > --- > include/linux/liveupdate.h | 14 ++++++-------- > kernel/liveupdate/luo_file.c | 14 ++------------ > kernel/liveupdate/luo_flb.c | 11 +++-------- > 3 files changed, 11 insertions(+), 28 deletions(-) -- Sincerely yours, Mike.