From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4F851BBBE5; Mon, 13 Apr 2026 19:04:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776107064; cv=none; b=K698xCyocAppgS0K8AlQA42K2mGaIuHsRtQQ89H+2u3uRIfsiSk9wsAUXMAWebFVeKmrm67ZfO8icQGIKyzpOZbap9lxNCkFE3KB0Iuy8z+pgaVsZMud0aSWq+IhhE8CZa+HBzaFjByXkdE/NVL9pa5ZqbUpMOwq12hMIvrzwUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776107064; c=relaxed/simple; bh=J6Oy2Os5lNI/CAxu9YtA3xPK4u5JL/xZobEDTIfkwz0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FBzsRG5OptDYpDxhQfslZ6qWxipN9T1KN9f85iUd/sZZLiWlOLREvdwIfXyo6jpfswupeGqjgOJNqK4xmHG9owFMo2mibTM7exy9m3wjenNs3ePr3WyR9dT3KZNU/J5sF0b9snbV71Pu1T1MNVzGvWLCMy9zf1w8AKlXgFul74c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=KK2jcVhY; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KK2jcVhY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776107062; x=1807643062; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=J6Oy2Os5lNI/CAxu9YtA3xPK4u5JL/xZobEDTIfkwz0=; b=KK2jcVhYBNmNCx9yEZB4xsZjkFV3P9wngZpK4SKFaXAxmYeWCdz6PhQI THev/BtvbKKuiqMW4hik3hQPoE1FW8B+C4X/hL5YtIi7GCdK3NAQv7pGl R+mJc2BAAfigCWfbsWPCsB1Fz13CKNQskz5erwGVEB7j/gwhes8NXA5/Y TW4qS6SN8FflB1qxBJGHXjnir+5hidOpIU48c/GbegUuj9K2O0rsLp+fy mlS9rueU3V0nFSxID5tUaOkpVtkuo8wHB3+BCO/1d0EnRXGuHMdK0dwHn GEUobDksv63QHzjUY2OKUsGATnSDZpjPRRfFv4ZMoH0dudKCmUv/wEqMp w==; X-CSE-ConnectionGUID: 3ltgrzQqRxaPT2ZmYMAZAw== X-CSE-MsgGUID: Bzuq+5MbTTO6LelBuda8Hg== X-IronPort-AV: E=McAfee;i="6800,10657,11758"; a="99698020" X-IronPort-AV: E=Sophos;i="6.23,177,1770624000"; d="scan'208";a="99698020" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2026 12:04:21 -0700 X-CSE-ConnectionGUID: s581NXHCRZmMfO6wEfwB2g== X-CSE-MsgGUID: SbIpZcUdT/a1/749YLYoDQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,177,1770624000"; d="scan'208";a="234275702" Received: from abityuts-desk.ger.corp.intel.com (HELO localhost) ([10.245.245.97]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2026 12:04:11 -0700 Date: Mon, 13 Apr 2026 22:04:07 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Nicolas Frattaroli Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring , Jonathan Corbet , Shuah Khan , kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v13 11/27] drm/i915/hdmi: Add YCBCR444 handling for sink formats Message-ID: References: <20260413-color-format-v13-0-ab37d4dfba48@collabora.com> <20260413-color-format-v13-11-ab37d4dfba48@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland On Mon, Apr 13, 2026 at 09:58:22PM +0300, Ville Syrjälä wrote: > On Mon, Apr 13, 2026 at 12:07:25PM +0200, Nicolas Frattaroli wrote: > > In anticipation of userspace being able to explicitly select supported > > sink formats, add handling of the YCBCR444 sink format. The AUTO path > > does not choose this format, but with explicit format selection added to > > the driver, it becomes a possibility. > > > > Check for YCBCR444 support on the sink in both sink_bpc_possible, and > > sink_format_valid. > > > > Signed-off-by: Nicolas Frattaroli > > --- > > drivers/gpu/drm/i915/display/intel_hdmi.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c > > index 874076a29da4..5ab5b5f85cde 100644 > > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c > > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c > > @@ -1966,6 +1966,8 @@ static bool intel_hdmi_sink_bpc_possible(struct drm_connector *_connector, > > > > if (sink_format == INTEL_OUTPUT_FORMAT_YCBCR420) > > return hdmi->y420_dc_modes & DRM_EDID_YCBCR420_DC_36; > > + else if (sink_format == INTEL_OUTPUT_FORMAT_YCBCR444) > > + return info->edid_hdmi_ycbcr444_dc_modes & DRM_EDID_HDMI_DC_36; > > else > > return info->edid_hdmi_rgb444_dc_modes & DRM_EDID_HDMI_DC_36; > > case 10: > > @@ -1974,6 +1976,8 @@ static bool intel_hdmi_sink_bpc_possible(struct drm_connector *_connector, > > > > if (sink_format == INTEL_OUTPUT_FORMAT_YCBCR420) > > return hdmi->y420_dc_modes & DRM_EDID_YCBCR420_DC_30; > > + else if (sink_format == INTEL_OUTPUT_FORMAT_YCBCR444) > > + return info->edid_hdmi_ycbcr444_dc_modes & DRM_EDID_HDMI_DC_30; > > else > > return info->edid_hdmi_rgb444_dc_modes & DRM_EDID_HDMI_DC_30; > > case 8: > > @@ -2038,6 +2042,11 @@ intel_hdmi_sink_format_valid(struct intel_connector *connector, > > > > return MODE_OK; > > case INTEL_OUTPUT_FORMAT_RGB: > > + return MODE_OK; > > + case INTEL_OUTPUT_FORMAT_YCBCR444: > > We'll also want the !has_hdmi_sink check here like for 4:2:0. > > And I think we also want something to mirror the ycbcr_420_allowed > flag. I guess you could just make it something like: > > intel_hdmi_ycbcr_444_allowed(display) > { > return DISPLAY_VER(display) >= 5 && !HAS_GMCH(display); Actually the display version check is redundant there. !HAS_GMCH alone is sufficient. > } > > That can also be reused when setting up the allowed property values. > > > + if (!(info->color_formats & BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR444))) > > + return MODE_BAD; > > + > > return MODE_OK; > > default: > > MISSING_CASE(sink_format); > > > > -- > > 2.53.0 > > -- > Ville Syrjälä > Intel -- Ville Syrjälä Intel