From: "Ahmed S. Darwish" <darwi@linutronix.de>
To: Maciej Wieczor-Retman <m.wieczorretman@pm.me>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
bp@alien8.de, dave.hansen@linux.intel.com, xin@zytor.com,
chang.seok.bae@intel.com, mingo@redhat.com,
elena.reshetova@intel.com, maciej.wieczor-retman@intel.com,
babu.moger@amd.com, sohil.mehta@intel.com,
pawan.kumar.gupta@linux.intel.com, pmladek@suse.com,
nik.borisov@suse.com, ptesarik@suse.com, tglx@kernel.org,
peterz@infradead.org, jpoimboe@kernel.org, ak@linux.intel.com,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v12 4/4] x86/cpu: Clear feature bits whose dependencies were cleared
Date: Mon, 13 Apr 2026 16:42:59 +0200 [thread overview]
Message-ID: <ad0A85v56vupA33E@lx-t490> (raw)
In-Reply-To: <ac02Wl_eJIRDxGC2@wieczorr-mobl1.localdomain>
On Wed, 01 Apr 2026, Maciej Wieczor-Retman wrote:
>
> On 2026-03-30 at 23:41:57 +0200, Ahmed S. Darwish wrote:
> >On Fri, 27 Mar 2026, H. Peter Anvin wrote:
> >>
> >> Thinking about it, if this is discovered at runtime, it is really too late,
> >> because in a sense we have miscompiled the kernel with unwanted code (as we
> >> should have compiled out these features just as with other DISABLED features.)
> >>
> >> This ultimately reflects a failed dependency in Kconfig.cpufeatures, which may
> >> have caused kconfig to do the Wrong Thing[TM]. So at the very least it might
> >> be a good thing to print a message here saying Kconfig.cpufeatures should be
> >> fixed.
> >>
> >> The better option, which I don't know how difficult it would be, would be to
> >> make the dependencies available to Kconfig. This sounds like something that
> >> would fall in the scope of Ahmed's rework rather than this patchset, though
> >> (Ahmed, would you agree?)
> >>
> >
> >Definitely!
> >
> >If the CPUID model sent some days ago is to be merged, (*) then all these
> >dependencies should be encoded within x86-cpuid-db, especially that it now
> >covers all the synthetic X86_FEATURE flags as well.
>
> Hi! I'm still testing/browsing through the cpuid patchset. But I was wondering
> what did you mean about encoding these dependencies? That they are encoded in
> your patchset or that they should be?
>
Just for the sake of archive follow-up, further discussion moved to here:
https://lore.kernel.org/lkml/adz_584vlKivaECq@lx-t490
Thanks!
Ahmed
next prev parent reply other threads:[~2026-04-13 14:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 15:10 [PATCH v12 0/4] x86: Capability bits fix and required bits sanity check Maciej Wieczor-Retman
2026-03-27 15:10 ` [PATCH v12 1/4] x86/cpu: Clear feature bits disabled at compile-time Maciej Wieczor-Retman
2026-03-27 15:10 ` [PATCH v12 2/4] x86/cpu: Check if feature string is non-zero Maciej Wieczor-Retman
2026-03-27 17:50 ` Sohil Mehta
2026-03-27 21:28 ` Maciej Wieczor-Retman
2026-03-30 20:00 ` Borislav Petkov
2026-03-30 20:42 ` Maciej Wieczor-Retman
2026-03-30 21:15 ` Borislav Petkov
2026-03-30 21:44 ` H. Peter Anvin
2026-03-30 22:59 ` Borislav Petkov
2026-03-30 23:42 ` H. Peter Anvin
2026-03-31 2:15 ` H. Peter Anvin
2026-03-31 13:27 ` Borislav Petkov
2026-03-27 15:10 ` [PATCH v12 3/4] x86/cpu: Do a sanity check on required feature bits Maciej Wieczor-Retman
2026-03-27 17:10 ` Pawan Gupta
2026-03-27 17:22 ` Maciej Wieczor-Retman
2026-03-27 15:11 ` [PATCH v12 4/4] x86/cpu: Clear feature bits whose dependencies were cleared Maciej Wieczor-Retman
2026-03-28 2:22 ` H. Peter Anvin
2026-03-30 10:40 ` Maciej Wieczor-Retman
2026-03-30 21:41 ` Ahmed S. Darwish
2026-03-31 11:41 ` Maciej Wieczor-Retman
2026-04-01 15:16 ` Maciej Wieczor-Retman
2026-04-13 14:42 ` Ahmed S. Darwish [this message]
2026-03-30 6:11 ` [PATCH v12 0/4] x86: Capability bits fix and required bits sanity check Andi Kleen
2026-03-30 8:52 ` Maciej Wieczor-Retman
2026-03-30 23:40 ` H. Peter Anvin
2026-03-31 14:02 ` Borislav Petkov
2026-03-31 14:27 ` Maciej Wieczor-Retman
2026-03-31 14:46 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad0A85v56vupA33E@lx-t490 \
--to=darwi@linutronix.de \
--cc=ak@linux.intel.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=elena.reshetova@intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.wieczorretman@pm.me \
--cc=maciej.wieczor-retman@intel.com \
--cc=mingo@redhat.com \
--cc=nik.borisov@suse.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=ptesarik@suse.com \
--cc=sohil.mehta@intel.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox