From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 099AC3DFC66 for ; Mon, 13 Apr 2026 14:44:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776091471; cv=none; b=QLw8JnpsadjV5FhjSfntDIUzgkdPBVwBRZoRyPWjc2C02TXJbP14lnsmOA5rcgqWy0urqw9u3gVsamEtFGVXZFwtaGS0ivrGS/95Ap3c54ub9Ox3XciC/8m03/8rSPz/K3X8ZNKFqfwfnfTZA9yWRy7UbP+WHROlJb5/0t8cV/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776091471; c=relaxed/simple; bh=OiZxwnD9Hxt+1QDbMh/RUvV1q4EWM5v7octJO3HLZuo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CSd2RFiwa+QIhgp0S8WpLVoMLtmysz7UabsK7GbAERMoaYL3VkcK00LEff2IuYMYVFPaeCxVobSRw25rAJc/OTVUdWkyF9PKjDdM6BlC0EmVPhiv+j549xopAojVg2x3h+UkAcCWvLyjde2chc/OcagFpo5HQjCfTtBfNzEj/hU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I8DDApur; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I8DDApur" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-488ba6366a7so56681845e9.0 for ; Mon, 13 Apr 2026 07:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776091468; x=1776696268; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wUSn6JhByTBr9SL0zKoqyVDYGQSakXuLOH5KvBNw/xk=; b=I8DDApurlMorz2BYYaWd7InDhKcJRpAfYp8QMKt/4Lyw8J/0RzSrgdteHGr9CLuY/y LhO3wAryNNtchqs0pJFjScM/ufCaPsVc3t4PploalxQpbUEQqhGs6m2ZtD5WcFucvH6A glvHe4ofX2ASKB/i1RSCYh/DSn8cHBFkhGqRE2kKsbF89Rx3KmCGsP+PwsDKtVNcaTX1 kXVVUZ3VUFBNr/nys9VdBYNFE0dOzOQMn8DmwBOaKUZp0lswGg81k6+gLgDwPuWQJLcI pRHcnA4JnvEou+KAInqV7mbnAUGPqU3PppB4lqDcDPGiNdXyeAMd6AUVf3NXaObokDBC IcWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776091468; x=1776696268; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wUSn6JhByTBr9SL0zKoqyVDYGQSakXuLOH5KvBNw/xk=; b=O0COjPOcf+XA2sdjuXej+fsjEvZVxJcLQJheBrDrGgAwVf5qmu7PtyK8dnI1SkCPBD oa18HoPldSxsH8s0T0xl5U7IFQTYyIb/BsbYqsiJ/bZTGc49bomOiEvLaSpo9FsjhzE6 egQsXKPo/BrwAubf7ZH0bz2NAPAqO02rlcFJS7wCS97w4nNajNRn4VUQRp2+muxP9nOc ZbaJ7f6J61ANfKll0p687+rMjpKyPHsskcyYGmpsNXJDom7D+nQr24CUHzJSl62otaUd IEvFZhzrRRrJBQ05qbe6axxsjQ1XVoFV3yLUszHuTKwBC5wFmBYNucfra+Rxehue9QsA CGBQ== X-Forwarded-Encrypted: i=1; AFNElJ8oF1NRxwZOFanV9CBJJRSpNqKaqvqksyjRt+ZbaYpluNAvQlQI2QyxxjFXzdieeH5xPVYMvoT6CAphB2g=@vger.kernel.org X-Gm-Message-State: AOJu0YxxSNvYHftgkWCniMilbSrErcQWxxpcnrHWC8ITN8bncHOOnFsx E+6oUHDRjjMKPoGPUep1pQbltNqKoFHLKfgPER1sifm0C95MLI136jgN X-Gm-Gg: AeBDievps0kaltCBfNlqqQ1c6XU7TALIkqAD6UMbZRCR93Rn5v/zoW8YK98uxkrIxal ZFRjGof4Ch0OR/7bZudkd8VcyggLAXchesvbqhNq3qeOS+LBrVcBEdfG0bOzZsfKnXfQ25gKD4Z dwGa41BTY10KDdvhbBigGM6K02wIU8ZFLfEbawEyIGLKdbsl1z3mGKtLw4+U9yrkzvtTTuLD8cs gY6624iV9IWX9J3MggN6oy/xeDYMnrQdioopKHPvNnsM8eWjMu5tv6dpN4LDWW3U/2awg4PE9Wc aWB8gncbe8e7zP4eTXKfTy5W3+x1xc2XtlnZcR4PW8XaXyhdIW+sfO4MCQMpHamOXhwGGbi3ui3 nS60CNRfDGCT1NQTNQU3bVOLeF60C+xfey87++WhIRfr80pGQ1K60He7SGebj6smRE92Bb+5luS 90eo98pXNInoElRJDo/9UiSrVFbPbxqw== X-Received: by 2002:a05:600c:5298:b0:488:c014:34da with SMTP id 5b1f17b1804b1-488d688687cmr197754545e9.26.1776091468149; Mon, 13 Apr 2026 07:44:28 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488eaf62cc4sm10624245e9.2.2026.04.13.07.44.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 07:44:27 -0700 (PDT) Date: Mon, 13 Apr 2026 17:44:24 +0300 From: Dan Carpenter To: deep@crimson.net.eu.org Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: convert int16_t to s16 Message-ID: References: <20260413143320.1246385-1-deep@crimson.net.eu.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260413143320.1246385-1-deep@crimson.net.eu.org> On Mon, Apr 13, 2026 at 04:33:20PM +0200, deep@crimson.net.eu.org wrote: > From: Kenet Jovan Sokoli > > The TODO list for the rtl8723bs driver mentions the conversion of > unusual variable types to the preferred kernel style. Convert the > "power_limit" variable in include/wifi.h from int16_t to s16. > > Signed-off-by: Kenet Jovan Sokoli > --- > drivers/staging/rtl8723bs/include/wifi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/include/wifi.h b/drivers/staging/rtl8723bs/include/wifi.h > index 230b2c4ffd3b..8ab0cb6ba344 100644 > --- a/drivers/staging/rtl8723bs/include/wifi.h > +++ b/drivers/staging/rtl8723bs/include/wifi.h > @@ -457,7 +457,7 @@ struct rtw_regulatory { > u32 tp_scale; > u16 current_rd; > u16 current_rd_ext; > - int16_t power_limit; > + s16 power_limit; Generally, variables like s16 and s32 should only be used when they are defined by a hardware or protocol spec. You should just use short and int for normal code. In this case, the rtw_regulatory is never really used. There are a few functions which take it as a parameter they aren't used and we always pass NULL pointers to them. Cleanup the functions and then delete the whole struct rtw_regulatory and struct. regards, dan carpenter > struct regd_pair_mapping *regpair; > };