From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8CCB3E0235 for ; Mon, 13 Apr 2026 14:45:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776091538; cv=none; b=Bw8K2WSvnOFF4oA3xR42Bsv/P3MWiie+ItAKWOX7mktvNCBRxoKTy7tfXYVREx75p/aWemifItsGb5FCQdsv+AEZpZbTm8hfh1pbWts9TCnq66zAPYR/90C8m24dAZAKGzktyZUg9S4MgKibjTx5Cy+cbnNIhVbFZvB4skdEogw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776091538; c=relaxed/simple; bh=kmWyifGeVgfYGBGfDdbKPv9jlbH5T8QcUUNkGM97mxA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tBLTf4wKmEXednWhc4p7dxi9/Cxutzdy/aZKiNH2777Q24xoZP92RKpVGLFD6IpiusYQt8875yFzwU2JXRHu/JU5MwUeJ4LHjc1sHaX1W4muihseCK/87iD+Ug4crGjjpF2xgO+To6F2lJ45uWCfG+ZRJBlVufxsyoYB8n8P3t8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dYUYHNyW; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dYUYHNyW" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-50dedb18ea0so13656691cf.3 for ; Mon, 13 Apr 2026 07:45:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776091536; x=1776696336; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ITvn7X7oXZotCVUuTe9jUnIiIMLcznplUJrhWp9sll0=; b=dYUYHNyW+xNY12DZYqbEo1kAfnxAatmcowLEQFKxHgRS7iScGzpRc36JKxIq5fC2+I dVD4Uwg9k9A/Ww9YrS81AmzPzOk4iIJA7aMxdOIuyIQ490q6YN3k/sf8FhffdeOB1LAf /V0t9iZcdAY5YGiYtWh7pVc5DMz9d5O6xqBRe0UfIjxzjTsX7DcU8LCcWgyw9BKm+iDQ VCDjpNKU1yUDRrxGDF9z/5Karb9QzhPI/xBYp4OOFyHlLivJA4q9tByPZgSGNyhRzapt UWNNnapAdm83MrzdHuaZAThKNkBlX2DAKu4x/qxi7L3qPkAw6FHuwSZwhktp1Zf0y9TF vErg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776091536; x=1776696336; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ITvn7X7oXZotCVUuTe9jUnIiIMLcznplUJrhWp9sll0=; b=VYInwaGcrnttsGv4BwM4XUdIX/eVSwwBl6mBCLPsYLu1KbR6eWm3TB6K0UZ0Lk7GVv luihQFV/LiBn1quENSOy6X0phFIXvD/1rUfCWhiU8GjXqmHsSOGDhzzXaBVrSPnTrI8X Lzy7Xvv+6bPQb/jWBM7WnEHYiPpe7h6HkZkMRBGheUL9lV+Cyyggqk2wIFQM/+KRWCp9 rz4fN+bstTkPDmb453p0BoLyhF/StLkNvfv5d/og4VmueF+VtstKEeA05xM3mbubS6dd t7QDVvAgQvQwwfJhxsTYn0Ou/BBgJsax/guuzzbbisws7I/NDiBE9fkdW1wUUFOGueRQ DthA== X-Forwarded-Encrypted: i=1; AFNElJ+KfRz+OBhcGgNz+OYwdcczVqgY55OPqAjysCI/FXj4LZj4yRBHcknIlpZoRc93bVH03n2SbaEICIXR84E=@vger.kernel.org X-Gm-Message-State: AOJu0YxaVQ1lEM0w1qfB5Hj2MkoCJQ0QlgYWvHGlH4qUGdwDVdFPRA4u 5Lik+iNZldkbk3lX+9qpyVO6Zd6bZXnzUqIpdo+fmqRZxn26YsbFOuGz X-Gm-Gg: AeBDietZeHvfMrsxfldkc25p0Yz9f14LVmhRYWOojRXkey+WVx29+opDdcUbTaJYoC9 4rGcTGsbkSjj8txvTBHi+t5pV+ZcJulOiR1BFmK9EG0rwwZIoc2x0W6QTV5YeUCC3kxSXIkXu+6 90x1Zc4DjipxgdSP9YhJdOY6w8bz+U/3GjydCoCrIrFITeZB9qj2k1t06tQYFNTRsva+YbXBqA0 vqBrQoPHi2XtO6t9MWkjUmIkUHzjNYBla6jGrMghQswEhlptNZ3as7S7C00PsRuwZorPsAoK/jp CKxqq/ruqsSyo6HZjUVGloERE2Y/iuJlJtKVZcjuqvoIDTkFFJ1kNdWKFkddnDDy17WWRAyocgo eDqJN2d5TsLKHmtA1Jfaa5YE76tA29M3TFanGqdTcq1fGgPqePWzTwA3iPd3VhOxG2eKCXUZx0q WVvXQVDTjzipPJOr+KC1qYVtkUGD9tiA== X-Received: by 2002:ac8:5a02:0:b0:50d:8734:ba65 with SMTP id d75a77b69052e-50dd5b95bc8mr221042781cf.11.1776091536454; Mon, 13 Apr 2026 07:45:36 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50dd5616487sm88973761cf.25.2026.04.13.07.45.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 07:45:35 -0700 (PDT) Date: Mon, 13 Apr 2026 17:45:31 +0300 From: Dan Carpenter To: deep@crimson.net.eu.org Cc: gregkh@linuxfoundation.org, ovidiu.panait.oss@gmail.com, gshahrouzi@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: axis-fifo: fix alignment in wait_event_interruptible() Message-ID: References: <20260413140508.1190800-1-deep@crimson.net.eu.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260413140508.1190800-1-deep@crimson.net.eu.org> On Mon, Apr 13, 2026 at 04:05:08PM +0200, deep@crimson.net.eu.org wrote: > From: Kenet Jovan Sokoli > > Signed-off-by: Kenet Jovan Sokoli No commit message. > --- > drivers/staging/axis-fifo/axis-fifo.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c > index aa90b27197cf..9b5b640e53b3 100644 > --- a/drivers/staging/axis-fifo/axis-fifo.c > +++ b/drivers/staging/axis-fifo/axis-fifo.c > @@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf, > mutex_lock(&fifo->write_lock); > > ret = wait_event_interruptible(fifo->write_queue, > - ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write); > + ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= > + words_to_write); The code was better before. Just leave it as-is. regards, dan carpenter > if (ret) > goto end_unlock; > }