From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1908A30DEAC for ; Mon, 13 Apr 2026 16:42:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776098554; cv=none; b=EmdQaR7Bw9EurfIVZ9iPsNIW0S1kYUzalY3uNvvKWBgkry8wBMjW66XSbpT8Y7SISx5YTJPLPVdA+r87lGtmHKSXoiK7EU6lASLuiPnkS5w+RtfLajfa6VvlbDEHGBH4K6pcJ7I7EtaXAYw4eWP2y0WDeElyQA8qLyI0UIaclNE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776098554; c=relaxed/simple; bh=5W6Zy1XK1TAXTv6rQnCiO3JaK6tOysBBxFy1WxXFYSY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rYHWCO6mA/0D4UpVWQu8p5GQXURDj3xK7PZj6No5rMJUqoCEsPuzPgtEz9V5lznzObPyLfIuosjSZ2QS9sOqOUqsfSjlCuQKmkMLlwXD6tYvmXMHMt/RRk28MVyAIuBBXZVTaBO+WTOVEZqCvzVSHouEHnGIq9zORO/boSAeT5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=g8Bra74B; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=j4xancHj; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="g8Bra74B"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="j4xancHj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776098552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WO6WRptWW4sGTxFeojTyUtfweOrswI8hobePqSBWs7Y=; b=g8Bra74BSZKaYaEBT9WRCsdjuKi/S5PMfi80Y3b6v9T2eoBTDnKW5/uPl91RZBtyxM2ICe 2QsZGy38OfLzua9qE65oCQLhu18vrKA7sJWwZ+x9d6FG8kIjPLsH7+4DUlsi236VH24TDr RhbH9dMImApZ4a4pStk8+mgrsvt/LBg= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-2OfhTwCEMdGYP2BisxP5bQ-1; Mon, 13 Apr 2026 12:42:30 -0400 X-MC-Unique: 2OfhTwCEMdGYP2BisxP5bQ-1 X-Mimecast-MFC-AGG-ID: 2OfhTwCEMdGYP2BisxP5bQ_1776098550 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8d5d03ae893so732813785a.3 for ; Mon, 13 Apr 2026 09:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776098550; x=1776703350; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=WO6WRptWW4sGTxFeojTyUtfweOrswI8hobePqSBWs7Y=; b=j4xancHjo6YvJ/fYARrIgKH9X2E3fVNA9IJsh2RSvV2deRkqRmWtRP3uMqF8OhBqCo uAKSojtnfetM1MfR1wYN6jlwhaZ/kqNqLH9JQ3+pwEEI3aUdDtJkxjQ7hwpEg19LDcqv b7Bt3Aih0NYO5zismZIPpftn/atMxwcqZljkvt7kGUqzh7Erx9pOBjz/qkseH3ncX6oP XkBp3dX0eeK6mmF6+GkYt7F8ps7cTKNyyuxAuoWuCU6XhTi+1E2q5KtM+DQVzk1FBlDP SP7BEZLJi9G0qesCG9Akfkuj/DMMNV/rWdrxSmqd/KeAD7SrV283XftqFt6gU4PdepVC PJoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776098550; x=1776703350; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WO6WRptWW4sGTxFeojTyUtfweOrswI8hobePqSBWs7Y=; b=atgVKopDLacZJKib1CAQLLP67/9lODzdNyc7bzb2aPY5SWFwKRGxrjeoqBUFD8IAXP d4O9cJaFo0NVHjF+u9UCVuEH0NIf7V+Xz7amq4hy2oxmnESkDKt0c5YeWrbG1N6OnQXV DrU4CljNNo/WQh4wK8oihBxOqniLMe4FDwToYEz1JerIoZ1YmEyPunw/ZUA2igB1354D tllPJc4I7f7A66D3z2OneW3b7xHYY8VB8IKCy7GTSZaFu/BvJs5a13ni6miFMNTseUFG mqDTISmk2NE8ae0aLSQ+NKq6SAmV/S33bW8f0BQy896H3l0Hqd2CgnkZwHzFhKGO7c/e Ppng== X-Forwarded-Encrypted: i=1; AFNElJ/OuXa9uMdbskOgWUQl2I2MspbPPcDibukcOvHBmWG/qYjORS1I9CwhTqtqfo8+eV/pE+XMvLqcrS9HB0k=@vger.kernel.org X-Gm-Message-State: AOJu0YzZdwdBJobrCknq2bdePaGACRQEB3JdlTgHYLM9R2JD/vfD5PC9 7gX08YSi6/Gbz22qEPH3+47Vc4qdNJA33tOEsVecC6eeuEwjH19JLBYafokBEoChGWoGN5t392B 4DU+HS6sD6ll742L2SkuM/y/xtwVpvd3BmpEB3j4L5p1PzPHFtYi8jwyEkNbuDj6HZg== X-Gm-Gg: AeBDietJaVmDgngeg+zrVjjbCyrf0C1rIsTrljabDhu1x2KJmbqJMDCG4XeM8E5AQDv XPNLAgQod26KhcB/tGZE4C4scFKULpc8u0yKQlnF7Rnvb4mG7cCKwZ9xBPF39mTzBfYj+fHUGlF pPX81R1OrDM+BUrvZX2Vi2F2fu2JXE/sHqtfNK1L+MNWoqL1KQGOq8wKR23SslOkmdx3abBG2vM eANtnJypJrxJBTUZvtGgW6ncxJqDpQHkKEzAbHIqIHQ5fD/+YOELfn9CLpzo7nyc9ZfZxqBcyBn alkfjPDUbHesXvKSi1JjPNYg18MvCgWiSkciekGx0juiI2hMvtsYJ3y/1rQLg6qvufvA9S6mdnp fTN8TexM4gFNIoWsS7Vbumq7+3Bvi2VIZ3BBAB5zliiVy1XlEJ7DOCtCK X-Received: by 2002:a05:620a:4055:b0:8da:384b:9545 with SMTP id af79cd13be357-8ddccb2f661mr1997595185a.12.1776098550190; Mon, 13 Apr 2026 09:42:30 -0700 (PDT) X-Received: by 2002:a05:620a:4055:b0:8da:384b:9545 with SMTP id af79cd13be357-8ddccb2f661mr1997589685a.12.1776098549609; Mon, 13 Apr 2026 09:42:29 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8ddb9833c6asm908617885a.42.2026.04.13.09.42.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 09:42:28 -0700 (PDT) Date: Mon, 13 Apr 2026 12:42:27 -0400 From: Brian Masney To: Guangshuo Li Cc: Vladimir Kondratiev , Gregory CLEMENT , =?iso-8859-1?Q?Th=E9o?= Lebrun , Michael Turquette , Stephen Boyd , linux-mips@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] clk: eyeq: fix memory leak in eqc_auxdev_create() error path Message-ID: References: <20260412124247.2494971-1-lgs201920130244@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260412124247.2494971-1-lgs201920130244@gmail.com> User-Agent: Mutt/2.3.1 (2026-03-20) Hi Guangshuo, On Sun, Apr 12, 2026 at 08:42:46PM +0800, Guangshuo Li wrote: > eqc_auxdev_create() allocates an auxiliary_device with kzalloc() before > calling auxiliary_device_init(). > > When auxiliary_device_init() returns an error, the function exits > without freeing adev. Since the release callback is only expected to > handle cleanup after successful initialization, adev should be freed > explicitly in this path. > > Add the missing kfree(adev) before returning from the > auxiliary_device_init() error path. > > Fixes: 25d904946a0b ("clk: eyeq: add driver") > Cc: stable@vger.kernel.org > Signed-off-by: Guangshuo Li > --- > drivers/clk/clk-eyeq.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/clk-eyeq.c b/drivers/clk/clk-eyeq.c > index ea1c3d78e7cd..a48ecec4c9a5 100644 > --- a/drivers/clk/clk-eyeq.c > +++ b/drivers/clk/clk-eyeq.c > @@ -346,8 +346,10 @@ static int eqc_auxdev_create(struct device *dev, void __iomem *base, > adev->id = id; > > ret = auxiliary_device_init(adev); > - if (ret) > + if (ret) { > + kfree(adev); > return ret; > + } > > ret = auxiliary_device_add(adev); > if (ret) There is a leak in the error path here as well. I think this code should be converted to devm_kzalloc(). There is no devm_kzalloc_obj() yet, however according to [1] that should be coming soon. [1] https://lore.kernel.org/lkml/20260330154108.GA3389518@killaraus.ideasonboard.com/ Brian