From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6B9C30BF4E for ; Mon, 13 Apr 2026 16:38:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776098327; cv=none; b=PCR2h1ZAKIm1mQcG/vxTjOfGOsuZkcbVgqTe9LCdQGIRf1KVHqVVZI6wbZpQ6tBHvHiWFwUzAdrAs0mUc6xWi2LYAqSQvrav6i9NNlGMstT9b5H/bn76MLjfb5L54Mg67dUuD74pA6QN6jR9u6RHgIASRu3r9T1pyrAWSlq7K1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776098327; c=relaxed/simple; bh=hrzx/dvbEJpnRQ0vhxEwjvSnC2pT23xrRo3AuEIFtfM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IGEr20Xa1+75NI1MsNobNKr8OW3ZGFe8+kUT5GmplC/YT1vK+QoQ+KZZw3Mbc2UKFBtsxze23FMxkdk6jnwjBvPVGhc8zs7wl6vDoDTKGwjWzYRcplwE+xMzfsmafipTvPOdsCAVnBMerFQDUF530dxq4YyXx72PkrToQn4zweY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WrI/lNur; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=smAY3nfw; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WrI/lNur"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="smAY3nfw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776098324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MwH/TKeUG4gKy0pVdjPrCTUeZNlRp2XeMAZFKzWMR4U=; b=WrI/lNurZ+r2e/p7Ui4vGhYqTnHgKfAtJTL2qCu5yk3ZUzKuR/3dtH7DxErUszuSeIvsd0 p05/tiKM9mSC7iFnIgfv54u3Xenw8kSLNTKROXVTIVxa+hEWiIuEyDR69QZFuYmeIQrf0a RQHQinqvux2IvBl95RWqNOn4AkcSWqw= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-614-1ho1KkVEPGG64FdwkR9a0g-1; Mon, 13 Apr 2026 12:38:40 -0400 X-MC-Unique: 1ho1KkVEPGG64FdwkR9a0g-1 X-Mimecast-MFC-AGG-ID: 1ho1KkVEPGG64FdwkR9a0g_1776098320 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50d84b5f73bso59464171cf.0 for ; Mon, 13 Apr 2026 09:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776098320; x=1776703120; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=MwH/TKeUG4gKy0pVdjPrCTUeZNlRp2XeMAZFKzWMR4U=; b=smAY3nfw2AD8a99Ogc4+G623bOzDNm2v4s051JZpUeOVsG3ms8jmxhKr7L24LM8WI/ e+WMg06FNq+0qqP0sgLxHKn/TwrtbZfhcXKp32HaAKrabeSpSDPDzQ2bmnOVztf1QUX2 Z+FC3K3OaJRIJJYajUVor+bLxzW4AUIHA/zp84BSh5evh3kePL60uqLBLAFaxAxo8c2u Mndh2JSR+Uq994hlqWFb0keR72CS1BX47fP3mPq8yr/QM5OXQAQO/ADyoWj5YKuzQ86b xqR1ExfKuFaoF1xbK0BIdFCMb8unJSfZg4FJ+i1Qy+ygJHMKPaOz3R3zCdsKqLipZzI2 m8vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776098320; x=1776703120; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MwH/TKeUG4gKy0pVdjPrCTUeZNlRp2XeMAZFKzWMR4U=; b=IntonEZr4a8wEuIiq113NOE+4UHWS776gz6Fu8GhZpSl1hzBJOmhKt4tIUao1MhioA hAP7kflTwGLTMgv1dEJWOYeGAfV9y8FgQhVg+onlQur94DHSgqjuKzgxX7YfvFWvaSkj TIPvJXXJZii14BKL1xLPKwp83JAvEWCCi4OIklMisTTHJIh1Ll+5ZgqqfV95yRt1jf5f d8ywxJB+4m3vz4QvOcmDtQpVVonKVvZ5mgdSOeAAXw/br65SCbF0dZhT8khjkWYV/cal zxewRZOdQwwPIhxIoD0VdUemI8dJoAnZfFCLCx5+XuJCQjWM22CrVvbZvIEpLoxPbHir eGpw== X-Forwarded-Encrypted: i=1; AFNElJ+6axXJ/gUcU5U0x/zipA4xgPE+b/iUx/uJElhhPrBIWvIObVgs9l73wGJLIHxMbsN6ucvnZcXu2qPngTE=@vger.kernel.org X-Gm-Message-State: AOJu0YyoT785tgTf9O6pz7tfWm5j5Aqva0E8rnvOKOqQxqmyavZ0MbKq mZMk/VSu/bFNXQnRr5bbdUz3lu6yaoLZnKqbE1XoWoceM8S2jpLZEgRT0mK29S6nnB1ehHD6+lv GKo5CMRKi/wzKBJSGy0YKfq2EnIa3gj+v6LaK7J/YBLeVj7vM+VCP1DPjYYSy7ASDJA== X-Gm-Gg: AeBDiev1aENlwLqs034sBEy4zPNDKyk14KbhsAMCDc4jSiVXrIay4j/b0Q+HLA8qhCr aZNk96HgiJFNOs2L/IJCpejOZpFd4QJE+9s54tjYdM4fRwpoITJTCcAbehV0UOc+mnm530kKIHL N7fzpEfSZfHgfhU5YviDc7MP/DXR3g5pYsvthuGXzg0MoZPWSJhVqmXkV484RMdHgxIPg0QcgKU JMlo43OS29ILZksGBgB9eNyJ3WlCc2fz0IjehsxJxreRDsgWKmqcrpa0MsGsASaTOvgAi19CuhC 4YtcVsfAMaCArHhdNcQO96fh6QxECqgq2YU/GH+iuDUmuShFsOKxo9J+9UGqf/Faowg2RfibIQ3 6TYq1iOZll5jCK7fEI9hstCrZ6dw/gEM4YGyA9l1KAkjp9erzP7uD4o+N X-Received: by 2002:a05:622a:19a9:b0:509:4198:5468 with SMTP id d75a77b69052e-50dd5b104d2mr213512521cf.8.1776098319829; Mon, 13 Apr 2026 09:38:39 -0700 (PDT) X-Received: by 2002:a05:622a:19a9:b0:509:4198:5468 with SMTP id d75a77b69052e-50dd5b104d2mr213511921cf.8.1776098319324; Mon, 13 Apr 2026 09:38:39 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50dd54fcaa4sm87789731cf.20.2026.04.13.09.38.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 09:38:38 -0700 (PDT) Date: Mon, 13 Apr 2026 12:38:37 -0400 From: Brian Masney To: Guangshuo Li Cc: Emil Renner Berthing , Hal Feng , Michael Turquette , Stephen Boyd , Conor Dooley , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] clk: starfive: jh7110: fix memory leak in jh7110_reset_controller_register() error path Message-ID: References: <20260412125450.2509092-1-lgs201920130244@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260412125450.2509092-1-lgs201920130244@gmail.com> User-Agent: Mutt/2.3.1 (2026-03-20) Hi Guangshuo, On Sun, Apr 12, 2026 at 08:54:50PM +0800, Guangshuo Li wrote: > jh7110_reset_controller_register() allocates a jh71x0_reset_adev with > kzalloc() before calling auxiliary_device_init(). > > When auxiliary_device_init() returns an error, the function exits > without freeing rdev. Since the release callback is only expected to > handle cleanup after successful initialization, rdev should be freed > explicitly in this path. > > Add the missing kfree(rdev) before returning from the > auxiliary_device_init() error path. > > Fixes: edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock driver") > Cc: stable@vger.kernel.org > Signed-off-by: Guangshuo Li > --- > drivers/clk/starfive/clk-starfive-jh7110-sys.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/starfive/clk-starfive-jh7110-sys.c b/drivers/clk/starfive/clk-starfive-jh7110-sys.c > index 52833d4241c5..55cd0ccbdb84 100644 > --- a/drivers/clk/starfive/clk-starfive-jh7110-sys.c > +++ b/drivers/clk/starfive/clk-starfive-jh7110-sys.c > @@ -360,8 +360,10 @@ int jh7110_reset_controller_register(struct jh71x0_clk_priv *priv, > adev->id = adev_id; > > ret = auxiliary_device_init(adev); > - if (ret) > + if (ret) { > + kfree(rdev); > return ret; > + } > > ret = auxiliary_device_add(adev); > if (ret) { There's actually another leak in the error path for auxiliary_device_add(). I think this code should be converted to devm_kzalloc(). There is no devm_kzalloc_obj() yet, however according to [1] that should be coming soon. [1] https://lore.kernel.org/lkml/20260330154108.GA3389518@killaraus.ideasonboard.com/ Brian