From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5841D289367 for ; Tue, 14 Apr 2026 05:55:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776146141; cv=none; b=KTo6iVcLirS9Aix7Jhd0aIXTPyBLQqHo34z0mXZVoc5HwHM7Dh1VW/ryRJiZUoUsW4HDMytz0rYUcm7H8Gt4E2OGoHzMXKM4ILrffSqJ28Li/dZaCNKqzhdcoR05gP6oBAvQ3dBgVPLw4gc0GdUhaRN9y8Csh4OxZhtVOr823gQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776146141; c=relaxed/simple; bh=eFgpG5XXrLGfjWK4+59o6UJCdvu13kGkewQ9THtuuBQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lnejgUIgQ9kr1xHI2Bok5OQ5h/G0W90ab9AMdGGYKouISXg0roP1+yMKwodm4qRvp6A2Ea64XuI9hEvPurxNbqFZ71yJshoyDvtLLJkhDO/REB6sHslIqxj6HifMDOi7BT7rV+jTLtA8FoBJ1UoJrOaKUVdwBikldCvFrlZWCDo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n1pD0n97; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n1pD0n97" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-43cf5ad500fso4394143f8f.0 for ; Mon, 13 Apr 2026 22:55:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776146139; x=1776750939; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Nm5Ol5Uu+OCWExdsarfSE4sd8AD9UYzFlJf1BTFal2k=; b=n1pD0n9713MWWbh1eRFebZ/2HiFEESmT0HKGNqLt1JjmCe8WvR4PAObN4fuTN/lAM6 Bt/3HPaMkWQxfBwrBTKJvYR/Rwb1zk4fPNStQKTFli/WV7Jj1jQu+O1xFvzJ2YVcFFvC nYVT28ZggbK69c4EBOCvKo5/rzqYLZTWMTLd0bxr4wk9mwiJvvAb4PXHVLSxD9DTeTAW 4PLMkzTU5VU3cjcF4V96ZDLoZKi9CMNRwP5V5AhGvwG7YlX/MGdbMUt7uqun2jR9+Kyn +nB+GlQbE6Zi05kB99NuH8c8c6b7Jx5PFTUjg3J6F9ilZzW+Sa7/Zt8/CCvQ5Gu785w7 dCOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776146139; x=1776750939; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nm5Ol5Uu+OCWExdsarfSE4sd8AD9UYzFlJf1BTFal2k=; b=jczejFJGGFU+bMFRFlOOR9qzr25FClz/+PVgRBZMjMtMrKFVxTEDhGwwAROtCipd75 7twW3WIqwYu/1TZPcmT0v0T8CTXbNaqmathrR/E84Fys7YVRnl4hYXYys6dbdttKXLjm lpxYDIiIhG4uHw/T6cZ2YurgaNQBPqS4w6cAM1Y2dQbrJGNiF+ur3aZoRCRAA6be9v3J 7SPpiefJsqU+3uCc4ROARfe6waEJal8VfBTg/rIk1dr2To05ml6FMlP5XQqVn517NRA7 OXV0hUctjUsMsfHXkbmVR7XdypLDYaSNrTzeip92W3xR4Md9q7GWR3n6gItZxSQVbExs aj8g== X-Forwarded-Encrypted: i=1; AFNElJ/8Pk3MIDZOuk+97hXaYt++6Uq21Hyir+8LDl4EQZ+XpFEEA/88YiBGEnXb4W0iDSnGwfnNLvp6xMHmn1E=@vger.kernel.org X-Gm-Message-State: AOJu0Yyvdv3xTCKPolMDX48f+9iHpPr7QIcKe6ThgZK0aeEgqtTlsN9m eqc9lK5GvFZBwdW8xZ2FRIxKx0WTgZUVHJtQ7eWpKkcLK0BFwFAN7gHT X-Gm-Gg: AeBDieszSQBn4gQ8MLP3hb9lwvvs7Lxerad25ukC7NkbWPK5bhEezy7n4l8q7qLYOwC kWrEaYx8xnnHhTyN3tpJf2feaxeiy2fBQtAKSn2neQl8SR2XXEdry4zjU6L7hPr/Gj1umCDaMX9 IRmN+dNZua5cvLZ9Ff9Rpim6HQV0OmPAU+98No2IdWgJmlMS3yJEp9btpMkbKrgXaNHf4nAzIFi fLcXBAv33j3GczzuxWs6Q4UbQaMOCW/aZ3/ctmbaOAisJ/oh0PDxI8b8zW+Al/O6sm61X27eZY3 wETtQqihT6PPwKSJ+aCLK6rD9NEJ+JWergG8fLcUfJ7hTQhPQkmSI+P00TIztPwvbMycXjhUS2n /Z6RykFnT2lpdBsmey5/jv2tPz9P4bNQ39VCWRrA9KjOAaI5OXJRj9U5TG2xQvCQMIT3l9qaxen /wIjTpTxryAAdVK5il X-Received: by 2002:a05:6000:2c0c:b0:43d:2ffc:2f6c with SMTP id ffacd0b85a97d-43d6427b958mr24093181f8f.5.1776146138720; Mon, 13 Apr 2026 22:55:38 -0700 (PDT) Received: from localhost ([41.210.143.51]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e46a85sm39084865f8f.24.2026.04.13.22.55.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 22:55:38 -0700 (PDT) Date: Mon, 13 Apr 2026 20:51:33 +0300 From: Dan Carpenter To: Alexandru Hossu Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] staging: nvec: fix unconditional pm_power_off teardown Message-ID: References: <20260413151229.612301-1-hossu.alexandru@gmail.com> <20260413151236.612404-1-hossu.alexandru@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260413151236.612404-1-hossu.alexandru@gmail.com> On Mon, Apr 13, 2026 at 05:12:36PM +0200, Alexandru Hossu wrote: > tegra_nvec_remove() unconditionally sets pm_power_off = NULL, even if > nvec was not the one that registered it. This breaks any other driver > that may have set pm_power_off to its own handler. > > Replace the unconditional assignment with a guarded check so that > pm_power_off is only cleared if nvec was the one that set it. > > Also remove the stale FIXME comment, as the guard addresses exactly > what it was asking for. > > Fixes: 3f8d52ba1c49 ("staging: nvec: Remove nvec_power module") > Signed-off-by: Alexandru Hossu > --- > v2: > - Drop nvec_power_handle = NULL; after pm_power_off = NULL is set, > nvec_power_off() is unreachable via pm_power_off, so there is no > dangling-pointer risk there (Dan Carpenter) Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter