From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E40C7242D88 for ; Mon, 13 Apr 2026 21:08:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776114526; cv=none; b=EFifp31v2glaGmkXBy5Q8K514xucqxF8Al5nsasuhW7Pz3dy81w0vqQC7TwOOIyOg3cc8fGFnCDKE+UXSlOZ6x3gFKnfUCrM5XHYAhmT95wrhEJBE/aWJ2dQoD++dThBsv4XHKjNCGKssBbjE5OpmvFEOxAkR6Qvdvs53horf1g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776114526; c=relaxed/simple; bh=uzaVRNE1m2XUCN2Kv9goPe8pl1LVJCme+29/B83c9pY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=h9Sk9bxx3JzWgv6B4SozGpz6t55idk7khjUUoGWQzowAMWCg5ORM3SwbXmi066Ifq7RMcZxnbICMC8kca5LYKDcCJZFBNBC+nDAi9XdwWm43DxQ2TIORkzRXMz/n7AInR0XoCKmDeozXtieKpahQaJlm7GLWkZKRUxhRGWbHfQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=OObYOkUh; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OObYOkUh" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2adc527eaf5so34524155ad.0 for ; Mon, 13 Apr 2026 14:08:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1776114523; x=1776719323; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=kdsNO9c2Q5NZsN7hZZ5BDljOzEMaKqWGBnMOCrBmEmM=; b=OObYOkUhBdlAjqmIlDRIKBc4m/mXOHDYOwJsS9Ip566cebqPA8Yr1S8QlsbgCjpWjz npfZ+tw7NZ2RPdhwWehBG/5a5TiidwnmTDSz6fxFXP422ZzEioLHXJsuZffiFf6ywZD2 gZLIfzLgX3iyJpbTyX8v8q/9KDlzVXoNlg4q9jn/W8dgW7eOOsy4+Rusi5rL+avtpqKa j+E6oKfpD894oXoWAqiIqP/02Lg45MGqD4w1e+U0qJuzcMdZA6lKYt+IwvxxwjLXzg1r rCK/2WUM+Qij8tFwuG+jWb8H/M83YnxldKEpPtf0ffrVPnK9RfWk4UNuNzXv9/oDW+SU B3NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776114523; x=1776719323; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kdsNO9c2Q5NZsN7hZZ5BDljOzEMaKqWGBnMOCrBmEmM=; b=eDdGp9UFPk0zL86yACpiWQsJbl4iKGS3NfB12iocxTSrPt+ms8sxh/Qt+ZEiqpV8cw 72uFTuo5eQHOoZYuQGA8pgymkZqFexkmyZ4ZQScpd+Iugp7wPeRShcGIIlOv2cKc/pSl GD5bv5vCjtuM9sIhw+TTz0n2yIvwR2bCwpgLPb4LARq/H6g0+pFt20rl5BtS/HAgtQ49 EFoslGcSBGhPmJTp7Ywc2Hx8Zypri+eDba9DOboxs6MjVcsCJMm0eTRlEJIYIvQYFOiM Svk24JdivQj9QtnY92eANnKrIR2szkrnSCz5HpqTzZe59f9cAgmkfEXTGp/2Mgpt4BYF aniQ== X-Forwarded-Encrypted: i=1; AFNElJ9LfsObOdGtlmm5paL3S7Bt0uYIo9bCE6Sb8iYnZ32l23S5q+Ettbjur8+90CzPbhtEofQ2t+Wi9sh0NZQ=@vger.kernel.org X-Gm-Message-State: AOJu0YygQFZaI4QbRozE/nf3osRQUjsYRKW1nIr0KODshhWuNx3Guc1M gsfjxdnXDnz2F8gFhfAyoKtDGkGwkTN1muii08n96rn4RAJt1AC7NAFhZSyswY+m0lcO50o/KVq GsncaJg== X-Received: from pfwz16.prod.google.com ([2002:a05:6a00:1d90:b0:824:a65c:adf]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:3384:b0:398:aea8:a9bc with SMTP id adf61e73a8af0-39fe3d0e025mr17171043637.18.1776114522737; Mon, 13 Apr 2026 14:08:42 -0700 (PDT) Date: Mon, 13 Apr 2026 14:08:41 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260408-memory-failure-mf-delayed-fix-rfc-v3-v3-0-718f45eb7c75@google.com> <20260408-memory-failure-mf-delayed-fix-rfc-v3-v3-6-718f45eb7c75@google.com> Message-ID: Subject: Re: [PATCH RFC v3 6/7] KVM: selftests: Add memory failure tests in guest_memfd_test From: Sean Christopherson To: Ackerley Tng Cc: Lisa Wang , Miaohe Lin , Naoya Horiguchi , Andrew Morton , Paolo Bonzini , Shuah Khan , Hugh Dickins , Baolin Wang , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, rientjes@google.com, vannapurve@google.com, michael.roth@amd.com, jiaqiyan@google.com, tabba@google.com, dave.hansen@linux.intel.com Content-Type: text/plain; charset="us-ascii" On Mon, Apr 13, 2026, Ackerley Tng wrote: > Lisa Wang writes: > > > > > [...snip...] > > > > tools/testing/selftests/kvm/guest_memfd_test.c | 168 +++++++++++++++++++++++++ > > 1 file changed, 168 insertions(+) > > > > Hey Sean, what do you think of adding even more tests to > guest_memfd_test.c? Would you prefer adding memory failure tests > somewhere else? I recall you mentioning something about there being too > many tests in guest_memfd_test.c already. Hmm, we're definitely accumulating a lot of individual testcases, but up until this one, they're all quite small and so there hasn't been much motiviation to split up guest_memfd_test. But this one's quite the chonker, so I'd say yeah, put the memory failure stuff in it's own test, especially since testing the debugfs path will require elevated permissions for many environments.