From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 773EC27470 for ; Mon, 13 Apr 2026 22:46:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776120391; cv=none; b=KGDvGZaSOErUTc7NR9Cldb2PiiOR2dAvxEtWIJeim4VHWziN0mWtnPkNmdT1Z9n03wPdCU0D/S/fMRNIE7LHwZBFP1jy6A70P6jXL2FNsOP5gYiVQmCN1VJNqynnMYPLTggmLgUsqrjhxMwmVLkmjFM5OW5wlJq9y/wNq2UYtCE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776120391; c=relaxed/simple; bh=uSNfWH9CexRDvlTXr+w3luyUgQKOD+ai2y34931n82Q=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Hh1PhjtXPGkVAl2Jc71hj+dzpT5+M1jbm4+xmQPMkKU99Xz7SE63Ld9MbrpzcdDEVZolyRkWsEKRAgVteIsfsGKLJ8R73rAdzhIenMe/FDWhTgXypbfX8LThcpP2ThH+/p+wXtE0hDaTjNlRt4heeKZ/82t+oYhWQmNDkSeT0eg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PKV7TAIi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PKV7TAIi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01058C2BCAF; Mon, 13 Apr 2026 22:46:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776120391; bh=uSNfWH9CexRDvlTXr+w3luyUgQKOD+ai2y34931n82Q=; h=Date:From:To:Subject:References:In-Reply-To:From; b=PKV7TAIiy0JVDpUk0FS2caf9bsF9AEoLbaJyJjQtklB2KRXDhgJsbs2dIrU4GZBlF Ypavspx0BewVfd4k5XDktLvw9lmz4NQaOt0cyhJBqteNmNe38cpI5IaHBlRDITH98e Z7uCoEYpc/hQLi16WTtZntL37yaVsX7Qg4HoZDtmEWJRnM+b3cY5k1L0C1fytNkg6o nk6pZkZP5Z7BsSlhh0OWUosZZmuwHsxFsV5dcfdEZkj7e40Ue17HjvvBTSbSfx7k4/ HI3UOV6OPTMn80g+w4AEj/9a6DXO4dsB7RYbxjDkDJSkW9P9HDWla3v2wAxuLjqBj8 l9x18ewim58/A== Date: Mon, 13 Apr 2026 22:46:29 +0000 From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v4] f2fs: do not support mmap write for large folio Message-ID: References: <20260406154940.2407853-1-jaegeuk@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Let's check mmap writes onto the large folio, since we don't support writing large folios. Reviewed-by: Daeho Jeong Signed-off-by: Jaegeuk Kim --- - add f2fs_err to catch any issue fs/f2fs/file.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 2c4880f24b54..e917342cb828 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -82,8 +82,17 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf) int err = 0; vm_fault_t ret; - if (unlikely(IS_IMMUTABLE(inode))) + /* + * We only support large folio on the read case. + * Don't make any dirty pages. + */ + if (unlikely(IS_IMMUTABLE(inode)) || + mapping_large_folio_support(inode->i_mapping)) { + f2fs_err(sbi, "Not expected: immutable: %d large_folio: %d", + IS_IMMUTABLE(inode), + mapping_large_folio_support(inode->i_mapping)); return VM_FAULT_SIGBUS; + } if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) { err = -EIO; -- 2.54.0.rc0.605.g598a273b03-goog