From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 341C1271464 for ; Tue, 14 Apr 2026 05:55:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776146134; cv=none; b=AWOcRQ51hf1RywFtfMRUDxzBUNuqdd9LeapP0dBlL4rLtkqZZWzTN3liLgEps0WZ8MpvmHWExTPDco8p1OwHabVWW2wvZq9BkJKFcGya6Dz1FeV0eqEIJbofeOPqTlmjnqK4LE/jpUXN8GjsyjmflGFnXTS1qjEpFUotPEnaD58= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776146134; c=relaxed/simple; bh=KzEIosqJxP4BHkPpu4NHlIIuRW007FtiscoyUTKS2X0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hOixextm7lx/brwNTub5/EZ0nGLY5GnlPBpHe6fjwMCRqaM5OETeMTGkTizP6UBLacsxTXTtU4uRjmg7GxFTyr8lH/t86kqh09CzZ1vY0hs47aOcU9Oi0nuXw+D5Ytn1iN6y2n3ag7M0ca8XQnSeQCE68Da6xfV3m2CWtbunDn4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FHmBsjus; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FHmBsjus" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-488ba840146so49709755e9.1 for ; Mon, 13 Apr 2026 22:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776146132; x=1776750932; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=muj8PCwO3shpp/+65atzohj5RcAGvKdQQoRXJ2xczQc=; b=FHmBsjusUWFynJHc9UWszRpsI4j7SUZ/zVBfR04oUG8hE8HxZs1mV8y6+1ElULcpph ka145SiW8/Dm4YjbYKr+dm8UECXUul6bVABM5ijsB23Gr8eA9PxYbGpdqdzIJtTU0EtG fd9CwPKhjRQpJZr0Gke/sIRCH+/YeaLQ2C7IZYywMqebOxru5Qy1bWV+cIozGTDpWdio o9GK+PT1yGr70dqKGWhuyAF85eQ4f6Z/KDFFpQOod2ofbhi0JHajkfhD0Xp17X69K5a1 j3E2xkEY3lIuqP4EnyHQT6Uqv6+gb5OORdXWKYEFKflxG9ZaSOP1vEQS9hQuGOClnxnR Z/qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776146132; x=1776750932; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=muj8PCwO3shpp/+65atzohj5RcAGvKdQQoRXJ2xczQc=; b=Ugkcayk7EsXX/dHfSvzDyAm2mbUN9Dt2peMbZnT0w19MsVw525a4E+pUbrNa51YS8s TuCsht5CZF/4eHOVKo27l+6vhWKoXd5OSeZi21G2AIJYP63Fct26s0Z6J7Dp0d1pN5fe bGTC2fQfL/DkUyTKr0hUzPpqHITULUpRjvwEoKE6sPIRe1q7eWVH2YVu54FmOm86NaqH VILUa7X33kJWUs2swLyWfOQmGTpGzrfoudCaUkxyboSiyxAXCevd3/7xCr3oWbdMEHIW wQwPOIvSlqsBOOjlFTa9VV9OmnoYlpTBRtY7pK+yfdEcy0mDpfn5ZKoT+3e9ocG+UAfL NN3w== X-Forwarded-Encrypted: i=1; AFNElJ9UvCPyiEtD6loWM28uvoNw1E3fxK/jlKG1p4syP8zJURELTmV5rHoS6cfXoIzcTT93pQezrTP+w3nGl9c=@vger.kernel.org X-Gm-Message-State: AOJu0Yxh0QqSU0oPLzISLsMr2Xq6RjQtygsWaPWHIaK7mFesR77F3vGk kU9V3I6VX5Qszt9Js3wc+aBqy+nasfg3LReObXhy1FfJ8a6qbJA/4Fbh X-Gm-Gg: AeBDiesG0O5zC0jl8DiTc0OyT48idDP5dVbYeYWBDdAED91EN07Lk6irn8KOQbGTXjW y9nRv8v0+OsCXqIxWyMjqW++X4QApO9escpPRHGe3HwYybPdivbbswvxlRbru4j+5s6nnGNU+6l Yl9f7GD4YEjPBrOb5X/1NmrIQ0sBsZ5qL/M0WnYeM81s0DoS5TMbQk6OhlQmO9JYrOoVBDzWCUV Fga6SSXJrqSluUuBnTuPm3bIslJHpOqXViqRAygum8Zq62jKLSXOOnz2xFHN9n0ihFsHDDj3+Eu +Yc/wfAwPytYb2/rz4v2PiqC/59TvqwcXRyL1D3H27d1wGE1OcJrgxysfS2yndjLVfTX7a8E4v+ KNjwjtUiXmUUb/CBZZsqcthXehF0yT1CDPw1E38gNhxancnpPhQINO9SGIiAdYBAyAv9Td6/jxR OM9dmzfbVm7V9YrkJk X-Received: by 2002:a05:600c:45c6:b0:488:a723:ea53 with SMTP id 5b1f17b1804b1-488d67ce902mr186633235e9.7.1776146131481; Mon, 13 Apr 2026 22:55:31 -0700 (PDT) Received: from localhost ([41.210.143.51]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d6839981sm112966785e9.21.2026.04.13.22.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 22:55:30 -0700 (PDT) Date: Tue, 14 Apr 2026 08:55:24 +0300 From: Dan Carpenter To: deep@crimson.net.eu.org Cc: Dan Carpenter , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: remove unused struct rtw_regulatory Message-ID: References: <20260413154433.1366476-1-deep@crimson.net.eu.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260413154433.1366476-1-deep@crimson.net.eu.org> On Mon, Apr 13, 2026 at 05:44:32PM +0200, deep@crimson.net.eu.org wrote: > > -static void _rtw_regd_init_wiphy(struct rtw_regulatory *reg, > - struct wiphy *wiphy, > +static void _rtw_regd_init_wiphy(struct wiphy *wiphy, > void (*reg_notifier)(struct wiphy *wiphy, > - struct > - regulatory_request * > - request)) > + struct regulatory_request *request)) I wish you hadn't made this extra white space change. It's unrelated and confused me when I was reading the patch. Otherwise the patch looks good. Could you resend without that? regards, dan carpenter