From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2123F23A562 for ; Tue, 14 Apr 2026 05:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776146371; cv=none; b=YSA3ClwwzWpdGGnGT+oENGZ4RL/MXeVtsIoJBOficIO0YxQMXfam+M3/rgR6XPUeXLyYoP4gUm0GQGE+BqY4MBTWbCeM/VOons+4r/Qv0eemEN4tQY4/gFD1id/immnXZNL4GJw1eo38R/T2eejX9UjCf8Vjtgm3ZpWED4i9E0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776146371; c=relaxed/simple; bh=h7gBN58EjRQQMvn8M+1ZSRiH8tjQFGCYIVSdJFxvbXY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YDgN4hEvjtMfMkbuq7ABdWkeLRLn28XBB1tnBCeXJ6A+0F2b+nBHAOym2W+3TKQBBIUbX+Rko0X0oGSSbKh3y1OnnbLr8XBxChsSOkncM2kGqhwgk21FV2/JFFDNrtXZEqNx7KCYOy7PCyiM5SLwbjAG3VO75Tijj0v88g9+74M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=omUtUbmm; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="omUtUbmm" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-43cfd96354aso2912191f8f.1 for ; Mon, 13 Apr 2026 22:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776146368; x=1776751168; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+nV9NMG+kVLWQ/8CwHF5xK3P1P78smFNGOF9gK7QyE8=; b=omUtUbmmjPC0GWw5H9NpNwGilGBmLH9GK6xxXWRyMuUDqfZP8pLh62fan7tczFlEHE DSINNQP4p3SOhnIidnRYNVLr0v39AWZKi8g8K7cF7xq/o89cYPyQnIOZIz/emHkoXZ4E wV22jcwDBdkvvd5w9YoC+HC4pIPH9pSKDlpCRgqClFMsr6OHiFWOinzRAUNUr7lqxlhe FUvIjdTvo/woTRqdVrbDi6+5SeFJHcl7NVyQzTSi0Lon/nZvQLpuabDEDWL5gUCztGJc rXfT4GIR7PJfOLL59D2klq8Zfgxk1nLln4OvGb+oNp0tojZ7xpsMwlpgH/KOiOv97PID rkfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776146368; x=1776751168; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+nV9NMG+kVLWQ/8CwHF5xK3P1P78smFNGOF9gK7QyE8=; b=Tm92oNM0U3gl1O9KMpdv0ZUsxgCxPIHQGs9J5Nemhrz856wNO/L4FwaHrszC2Zh58g oj+eubLs+lFaZXqtE+nH6MQJbez2zcuAKnfualxpD4/GL17Atf1Muj38BDw41YAjEzfO NMPnPnafdTcqg/YFxWh0MMTwTvIfiN4ToIdv9BT59WLEe8SagGueVIhLrwSekOqeMg0Y DUM8dTQ/sbkdmKijvAnj8SZZlkQevg+pPGWJ8Eeazf9QeLuyQyBhVFcQEbcaPatK9GJs GvI6DX5sRUXlxk3CQ4lDnBlh8LE0lxBqrRPW/POalDFDO+nDebwJBIhyf9Pfyo5AKcU/ Jk1A== X-Forwarded-Encrypted: i=1; AFNElJ8V7wu4VJ8Genv9sUjG+BKq7tO790eNAMara5FUwQdunMophNexmIA+2uFKb2tzMhpMCHobDsg385LG38A=@vger.kernel.org X-Gm-Message-State: AOJu0YyIYurxtLsjePkj8opgDFcjVLPepTAthI6KHGUSMOpONC2V+WYL iD/TpNNZN/80TzpxaM5LfvuXCN4kmS1NHbJf7QZdt3IWcf+bUQOHH7J5 X-Gm-Gg: AeBDietejB0FVkM555U0CILTv4QlgIvc9q51haQojPI6f3Ti5JOFlAJIwZqMCEUK20e /cNRazCkUlDVQnDSQTFBVIUXAxXPXbKOHjcKGMAk51lFwI2/uyTGGrCL9tlXrplArBH2yI+na8/ TcAd/BlCyy7t9u/6LF8bsYBlOWKjzP84vSs9LI9hwx8j2wUfpEZ93t59bZk5uFE80K0Ps4buGfx ilqB8sjbq5mcdkVx4MM/Ez6H/PWimD8Dgyw5wqsDD7JeNVfMeG3/gaeiMgV3zqEug4R1v+DZatg A7d9f/RUG6vS+YmGZFnz/5C3fEv0RwtUYvLo4YBsX2+eX62N5iuCPE19OxzgWNvwSVcf+obkW9P GJNyvmrnma/K9BUe2bSsjipWz7omcmf1hYbl0IkPy8z6k7OmDIlnaLvMoSuKGFsr5wM4s6BFQ22 v4bAvNXykC2HCw/BFb X-Received: by 2002:a05:6000:2305:b0:43d:7946:badd with SMTP id ffacd0b85a97d-43d7946bb95mr8982083f8f.35.1776146368461; Mon, 13 Apr 2026 22:59:28 -0700 (PDT) Received: from localhost ([41.210.143.51]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d7794cce5sm15967410f8f.9.2026.04.13.22.59.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 22:59:27 -0700 (PDT) Date: Tue, 14 Apr 2026 08:59:21 +0300 From: Dan Carpenter To: Shyam Sunder Reddy Padira Cc: gregkh@linuxfoundation.org, --to=ethantidmore06@gmail.com, nayana.mariyappa@gmail.com, s9430939@naver.com, andriy.shevchenko@intel.com, kees@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: os_dep: avoid NULL pointer dereference in rtw_cbuf_alloc Message-ID: References: <20260413224417.5674-2-shyamsunderreddypadira@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260413224417.5674-2-shyamsunderreddypadira@gmail.com> On Tue, Apr 14, 2026 at 04:14:17AM +0530, Shyam Sunder Reddy Padira wrote: > The return value of kzalloc_flex() is used without > ensuring that the allocation succeeded, and the > pointer is dereferenced unconditionally. > > Guard the access to the allocated structure to > avoid a potential NULL pointer dereference if the > allocation fails. > > Fixes: 980cd426a25747daf8ed25e2a1904b2d26ffbb3d ("staging: rtl8723bs: replace rtw_zmalloc() with kzalloc()") > > Signed-off-by: Shyam Sunder Reddy Padira > --- > changes in v2: > -Fixed spelling mistakes(dereference, potential) > -Added Fixes tag It should be a 12 char hash: Fixes: 980cd426a257 ("staging: rtl8723bs: replace rtw_zmalloc() with kzalloc()") Remove the blank line between the Fixes tag and the Signed-off-by line. regards, dan carpenter