From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32BB535DA75 for ; Tue, 14 Apr 2026 07:10:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776150611; cv=none; b=W1+naKUDB8D+vKurrpLAaFClKMLzQm9AQHIsw4OOxuL/B4Xm9ZcMcM+z0HK/qCAxMgCdcE9GELnM5+bJMfPt0L0V4OUWqlPDbWbBTGuwK8J3LBapGayx2N/7laFZSpWk0/H/fa8p3a/5PSFWqj9FtfuJKIEwhRsASdQdsXt12e0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776150611; c=relaxed/simple; bh=tDXUB/f+iwNnH9JSR+IN7EJ89hYkaXiImA23ASGPSEI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AEaUf0Iat5voGS0EgIX6nYax7GLzVp4GgAvIFOFjZRWVqVPd9ENKzr4gbgGsrQhLw59RdaXI5cDunKivRPeBvFyzd14X6LdqFIOwf9IKuEmz45ykwauNeRsNuWOJsZ9I9bet2ka6P+8GA1+ls5c5a+IV7vbPpfivn1rSm6EuYJo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BCcQ6UkJ; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BCcQ6UkJ" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-488b0e1b870so82350645e9.2 for ; Tue, 14 Apr 2026 00:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776150608; x=1776755408; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/+E2/69O2+/fU04U0fzvqnZqh3kwzlnmTa71Xox0U58=; b=BCcQ6UkJBiaegPAemz6c3Zc4Db21XaR1E5ASyfc4we9noaz+hMEIxHby7OySIAwf6E kQjzH24ZERORjv77ElImi+kxE31/WumPEkEDvkxIV8C7AfigL1miZqFb0FGYmu864N6h p56WYKy5J7JPj+tkzbLRQ6Glpd8oHG718OYXGVR3GHH3s+LY4dow2gbKSBZVUxIZmmYz Qe62rsFMGaKar4qHG4S95Fff/94p0QhAWDQjFqMpvXg81/m9VDUo55rJnFBo+wSfUmul cOUlCW0gTMOkQb4fW/cDlQ/lkiu8ba/wZd/v6wT/AP6WGC+6nscgld/JnMDgSx8wv1zj TzzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776150608; x=1776755408; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/+E2/69O2+/fU04U0fzvqnZqh3kwzlnmTa71Xox0U58=; b=O+Jgd74VepniHQ/lbnC6fx3Kx1ostlWFjuCTJxKfHNRI8MbqU/2OllJMkoGbaOAvTj 0zavCYRyWRiv9rl8IPxLgxqTS/QixUWOhIYKqP3vW8Na0FgZXG0ND3DTOlgMq511cmNs UWeZOH7DI1bxCZjMAI8jcBc5s5c/PV+DAYUpIQGGlfRxfnGhLeSoGYJ5rapeEFlQwrBI CJ+gZ1vsiTTgYN83jBBECdRP+BFzC0ZGDNL8VdkzH12Tfsj4m8VX+dvnGIq/epm/Ta3P doIU9T/GAKI4Q15ITuVsBh9cgnb+V5q3LJKxQZOPw1jCCE1tz6yj41t8L7LWBVa74wG3 9cgQ== X-Forwarded-Encrypted: i=1; AFNElJ/AVA/Tpgm/BjhW2xWNeAs2N40dJUpMiQF5kAJutbGq8q24D57ywliqW6PDw79xgqpKf3vVl7smyVsm1IA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1Lm1k6J1CqPJgW8qJ3hRy/kVNXOlFpQRA0iWTVyI13KYRiXb1 l5Yc3KrFXp+m1ZdRMiLAyNhmz1Y02YfBEHQ6rw5R6/f1VqaWjK93vYRb X-Gm-Gg: AeBDiespNHcM/xHsEIUGYg7RnHGuKcNozX54stymfkmUbCdXhCMB2xD4NMnQL52jy7+ ezj1XebeAGBhrINvOFFICe9J3DMs2aSfJWWw8Duko2cTupHIydA5SFOh4h1z2axn/VidBcUTvid xHPkDvfvy69rUU6nqmVE3Js+w81dTwq5BcpmIW1YUyuPXVPHdyjKRTqBFcYyNwicw0A0ynDYacz R+Sk21pZ/748RPRXgU25UK8651mfGPmYSVrA72UZx2CnHJZqswANeThe0oCnHTCTqhzgdxLKfm0 qqqHImaulnAQ7jkf3Kts7ldZvbGmu+qRaIyc2WAsA3LD/E9e6aIZf2EGGTAqg71nt1UY9nRbEog lVAEGmuTPeE2OTw7LYu6//fJ+sDklAVFSWQiCvpdiTYSBNu+6pHQ4V2yoXp8CU8j9DtTbn4Xp95 vHWBmoUSvlbXl6Ym/RGl6f1GQae4qYReTKfRO0 X-Received: by 2002:a05:600c:1987:b0:485:5ba3:37d8 with SMTP id 5b1f17b1804b1-488d67bf736mr217231465e9.5.1776150608395; Tue, 14 Apr 2026 00:10:08 -0700 (PDT) Received: from localhost (hf33.n1.ips.mtn.co.ug. [41.210.143.51]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d5d97c65sm115627825e9.6.2026.04.14.00.10.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 00:10:07 -0700 (PDT) Date: Tue, 14 Apr 2026 10:10:01 +0300 From: Dan Carpenter To: Aadarsh Mandal Cc: gregkh@linuxfoundation.org, dan.carpenter@linaro.org, ethantidmore06@gmail.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, luka.gejak@linux.dev, straube.linux@gmail.com Subject: Re: [PATCH v10] staging: rtl8723bs: remove commented-out code Message-ID: References: <20260318021005.6346-1-aadarshmandal9354@gmail.com> <20260414063534.16697-1-aadarshmandal9354@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260414063534.16697-1-aadarshmandal9354@gmail.com> On Tue, Apr 14, 2026 at 12:05:34PM +0530, Aadarsh Mandal wrote: > Remove code that is not used anywhere in driver. > > Signed-off-by: Aadarsh Mandal > --- > v10: > - Change in commit style. Heh. We really do want to know what changed between versions but this is too vague to be useful. The problem is that we are very lazy and forgetful and we can't remember or be bothered to look it up. If we have a note, we easily check if you added a Signed-off-by line we asked for or whatever. So this should have been "The notes under the --- cut off line were misnumbered. Fix that." It's not really fixed. :P But whatever at this point I'm ready to just merge this. Reviewed-by: Dan Carpenter > v9: > - Change in commit style. This should have been "Don't do unrelated white space changes". > v8: > - Restore the formatting of non-commented code. This one was probably intended to be the note for v9. In v7 what we complained about was that you said "no change" and we wondered why you were resending patches with no change. This message should have been "Add better notes under the --- cut off line". > v7: > - Change in commit style. This one was "Add a Signed-off-by line." regards, dan carpenter