From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40D1D37D110 for ; Tue, 14 Apr 2026 07:19:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776151170; cv=none; b=ft5hIVYjVqNC/NO87IZ+ZNFW9BSRoaT+ksTlhRLrZISxzLEI2ari2633bjfYq6bkHN/b8nWRoVytR2Mi8AlcR4NcZCg4ZbakczZ0Syrk0raV2AZ92TIFozOfTqJKnB3yf5gGvUJ2StRghkqWpoTUQIcLAviyaWjEgk39cz23+9Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776151170; c=relaxed/simple; bh=dZbI56v/o2ICtsBYvukydQVhgLyj8yfVR0QIhK4Ejr0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sILwRy3+tNPsjdicF6RAQDWGuZw7U34vevB2DUPzPuysOrbf4muk6sRJTNU2iqhiyv+5hfoeqI5QmwHdabIIppjaPswO2aPTrM2i/+SKQjX9Y0eptkdMWPz6wacEWGZ4bwa8yq1BHqwSwzgyVPO6neUVBpjlpWAb9zVRjl2nnoQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U1V5CMf3; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U1V5CMf3" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-488a041eae5so38318755e9.1 for ; Tue, 14 Apr 2026 00:19:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776151168; x=1776755968; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OSF42xvXrzBa4KmCc83ZJg8r+kL7f44ATnnik3EjWWk=; b=U1V5CMf3UTfaHHKbIGqW57UypOrXDCd0dgoLlEKO4Wx4RVUacK/AvIqIZiqBLCOq4/ ziBrtcP4HYDn33zapojDAgk07987qw5PxlABby+kRyv0ms+7n9g+SDigZmRgsLAXVq1t 8tZ4BAxXscZ8AUdYFg5CJdB4h2EOIYvla/9psqGUbSUZTkrnpCcFw/Gic+pDyvRMjgpA Tp7seBbe7nZCmvNbRvLDwm/poifmAwP1apCD4obqS3ddoCi2FzLFam0hRPPxH2rHqsbW fzcq8w/fO5C5CBMpYeAcOxHAWe3rZ0kTz4UXmNJipHpJgyY+F96YxXh58dgWAGAgQbFe Cwvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776151168; x=1776755968; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OSF42xvXrzBa4KmCc83ZJg8r+kL7f44ATnnik3EjWWk=; b=lb6PE7ePRGIdK4FYfYRu8xHlxfBGda6C1OJ13jyYH2iA7CkEGWBh0XzyGbbtJAJUu6 LZk3saFM3tJkmI/nb9zH91XckWVu6Ll2vYSGapCYEpCPq0DWFr+5LKNrWgiwboh5VNuV i/Mse8veC5s8w86qkw0Nr5RcziZEpodEBCdZPK2T1/qPheqB5N5ogqJRMwEXhs3BNoxL Rw1OTnZ+TX9g/597tIKOiRpK83C0nQdWGHHov94LSWm9tUTTODLX4gnWO0aiQ+dEKJII AN5LfQ4HBDGG7xtY/bwNou7LYCaUdRTCwjlVFJ/BJdMvkRMmtITj5uAohckpQL9EFImM P+Cw== X-Forwarded-Encrypted: i=1; AFNElJ/25XqKGPsr9uiXVYvOBGqbD199Lyzy5rwnOffRdntbluxFVSjmgBN8ly4fsIPJVKWmT1+w4yYOi2Oglbg=@vger.kernel.org X-Gm-Message-State: AOJu0YypqHxtvSDgSX/ibNORrHbTalcEt+sz7ZJNppAMWA3SljTFqgEu hHBmIM9qQi3qA5Wpnv4Q9hQB4cq2VhDHG7bT0yAhqiXsY/KeynbMvV4J X-Gm-Gg: AeBDievpjcBtpASquo6kkyK8Oh4tPe9HeXK0LclTv5GB9aJW4Jowt5XDc4FwW3hyiiT h3hFgQ0UKgnzH9bCozXQsdxi3vecJJVbu176OT3gq8g1tm7b21ui38i5Rxbc46wO47FwSauzJQs ueUL8f9Ltn6Zcc57Elavirc8IVniOmzYM/HQRnAatp6XrbJFieMxoqSmPkmrrogc5PupbFTtRsG OUQ7vbQWVccf6obOzMaP4ZXOSRQNXRQdOv4+vHvusRQrVEca8ZTUHrf1bOB0cIl+bDP/MoE8X0e l4IjPVY24ZrcWyyZCbe4PnWxy2r1e9jtSVy/VCElX4/NUrbH2hsq3d0IiwS5ar6sDRkm+hB9kLc eR+wfuBd38H6DoWq2URDp0lTfUNCRidy+Qlv1twZKcfsySkpyQlAV2ULpx+XqMZBKbLY/ExrNo5 EwyxVI2GZGmElT2CEgjI5tWfL4wwb3YhyvtZ/9 X-Received: by 2002:a05:600c:8709:b0:488:945a:ed63 with SMTP id 5b1f17b1804b1-488d6655adfmr224805675e9.0.1776151167573; Tue, 14 Apr 2026 00:19:27 -0700 (PDT) Received: from localhost (hf33.n1.ips.mtn.co.ug. [41.210.143.51]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488eddb9751sm47593285e9.0.2026.04.14.00.19.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 00:19:27 -0700 (PDT) Date: Tue, 14 Apr 2026 10:19:22 +0300 From: Dan Carpenter To: Shyam Sunder Reddy Padira Cc: gregkh@linuxfoundation.org, ethantidmore06@gmail.com, nayana.mariyappa@gmail.com, s9430939@naver.com, andriy.shevchenko@intel.com, kees@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: rtl8723bs: os_dep: avoid NULL pointer dereference in rtw_cbuf_alloc Message-ID: References: <20260413224417.5674-2-shyamsunderreddypadira@gmail.com> <20260414071308.4781-2-shyamsunderreddypadira@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260414071308.4781-2-shyamsunderreddypadira@gmail.com> On Tue, Apr 14, 2026 at 12:43:06PM +0530, Shyam Sunder Reddy Padira wrote: > The return value of kzalloc_flex() is used without > ensuring that the allocation succeeded, and the > pointer is dereferenced unconditionally. > > Guard the access to the allocated structure to > avoid a potential NULL pointer dereference if the > allocation fails. > > Fixes: 980cd426a257 ("staging: rtl8723bs: replace rtw_zmalloc() with kzalloc()") > Signed-off-by: Shyam Sunder Reddy Padira > --- > changes in v3: > -Shortened commit hash in Fixes tag to 12 characters > -Removed blank line between Signed-off-by and Fixes tag Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter