From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50A4B3D646E for ; Tue, 14 Apr 2026 13:18:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776172701; cv=none; b=XtQc0UvtLaDJWFrMBtdHhxC6Nphl9jyPoQMCGPY4p4irfR5Xs78FBz1+knmSKs1zuLg8GESJbpdRmMg4GlkPbrnhkUKZcOAUyBUK9IAWc5yi7GfgR5rhgrG/XAUcqnIwPFXwyw3LBYezQVPWZUxCMIzC1DRFuq5s/va9WVKmJiI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776172701; c=relaxed/simple; bh=FQ237amPMTpjP/zci9Xg+yDzHtRxKK/XBzxYqEBtSbE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e0RZ6vB7SAgvh9RM3CxsJvsZVcBoAwRU1+xMUha7hCAG7Q198EW1o+1yRSNwjfaCLLaSD5szpjAxU5DrYTCs1MDsPcYxfz/i6C4aLqnelaKUGLO89IisMMKM5DbAGNb/WwDBAgzaVhlpwFcsnq4FrlrF4fYcfxpNA2Jp7ccNozg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=ZWxGBwIf; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ZWxGBwIf" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wSsvXqHkk+zqYvLTBPIs4fKDOVrgYcewrUX/PvzkTYc=; b=ZWxGBwIfHG9Rx/E190VMj7+GOH vVPNv6THSkPLrls9Shm7y7DwgcZ9+3lRIXGAwrmz+f6tL8uNKPEiIHxZDQwIdW8XW6iEKjH6NkucK tpBTp3JoXq1P0W2a4P31VZrMTdgFGUdo7lpNaJVFqESaDIjqTndImTGnDl4GW/0uuj0BgkiFdL4h2 A4+rlqdr52xL82wRksIso/DPrevX1b5YFSJ32P0LJ/o6Q20JhDIwuJfyEDhAorLNhpIu0uLx9iYnV N1Bgf+0SaVjIP9JEjwqszb9dKJAq4HI9kOToTEgBnrgA6pp11bcAWByI651T8g/crvZSmJSdoKAIW 233pMw2A==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1wCdec-0000000Fbs6-2VDp; Tue, 14 Apr 2026 13:18:10 +0000 Date: Tue, 14 Apr 2026 14:18:10 +0100 From: Matthew Wilcox To: Ye Liu Cc: Andrew Morton , linux-mm@kvack.org, Ye Liu , Vlastimil Babka , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] mm/vmstat: simplify folio stat APIs Message-ID: References: <20260414091527.2970844-1-ye.liu@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260414091527.2970844-1-ye.liu@linux.dev> On Tue, Apr 14, 2026 at 05:15:17PM +0800, Ye Liu wrote: > From: Ye Liu > > This series simplifies folio statistics accounting by: > 1. Replacing node_stat_mod_folio/zone_stat_mod_folio with more semantic > add_folio/sub_folio functions > 2. Removing unused __node_stat_* and __zone_stat_* wrapper functions I'm not convinced this is the right approach. We've often computed folio_nr_pages() for use by several different functions, and you're making us recompute it.