From: Krzysztof Kozlowski <krzk@kernel.org>
To: Varada Pavani <v.pavani@samsung.com>,
alim.akhtar@samsung.com, wim@linux-watchdog.org,
linux@roeck-us.net
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
gost.dev@samsung.com, aswani.reddy@samsung.com
Subject: Re: [PATCH] watchdog: s3c2410: Add FSD support
Date: Fri, 29 Aug 2025 16:08:27 +0200 [thread overview]
Message-ID: <ad42068f-8528-4974-80cc-2f99cd628809@kernel.org> (raw)
In-Reply-To: <20250829140003.109588-1-v.pavani@samsung.com>
On 29/08/2025 16:00, Varada Pavani wrote:
> +
> static const struct of_device_id s3c2410_wdt_match[] = {
> { .compatible = "google,gs101-wdt",
> .data = &drv_data_gs101_cl0 },
> @@ -352,6 +380,8 @@ static const struct of_device_id s3c2410_wdt_match[] = {
> .data = &drv_data_exynosautov9_cl0 },
> { .compatible = "samsung,exynosautov920-wdt",
> .data = &drv_data_exynosautov920_cl0 },
> + { .compatible = "tesla,fsd-wdt",
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-29 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250829140010epcas5p1bc06faf0001ab2695f0199db65fe678d@epcas5p1.samsung.com>
2025-08-29 14:00 ` [PATCH] watchdog: s3c2410: Add FSD support Varada Pavani
2025-08-29 14:08 ` Krzysztof Kozlowski [this message]
2025-08-29 14:09 ` Krzysztof Kozlowski
2025-08-29 18:46 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad42068f-8528-4974-80cc-2f99cd628809@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=aswani.reddy@samsung.com \
--cc=gost.dev@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=v.pavani@samsung.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).